From: Christoph Hellwig <hch@lst.de>
To: Greg Ungerer <gerg@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, hch@lst.de, geert@linux-m68k.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] m68knommu: add missing __user annotations
Date: Tue, 8 Sep 2020 15:30:17 +0200 [thread overview]
Message-ID: <20200908133017.GA4042@lst.de> (raw)
In-Reply-To: <20200908132647.923201-1-gerg@linux-m68k.org>
On Tue, Sep 08, 2020 at 11:26:47PM +1000, Greg Ungerer wrote:
> Some of the m68knommu user access functions are not using the __user
> annotation where required. Specifically __clear_user(), strnlen_user()
> and strncpy_from_user() need their user space source address annoted
> with __user.
You'll also need __force annotations to that sparse doesn't complain
inside the function. Btw, it might be worth to just use the helpers
from asm-generic/uaccess.h as they should work for m68knommu.
next prev parent reply other threads:[~2020-09-08 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 13:26 [PATCH] m68knommu: add missing __user annotations Greg Ungerer
2020-09-08 13:30 ` Christoph Hellwig [this message]
2020-09-08 23:26 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908133017.GA4042@lst.de \
--to=hch@lst.de \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.