All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 4/6] package make: build RISC-V nommu builds as linux
Date: Tue, 8 Sep 2020 23:56:14 +0200	[thread overview]
Message-ID: <20200908215614.GG14354@scaer> (raw)
In-Reply-To: <20200908113324.1022230-5-damien.lemoal@wdc.com>

On 2020-09-08 20:33 +0900, Damien Le Moal spake thusly:
> From: Christoph Hellwig <hch@lst.de>
> 
> Using *-uclinux-* seems like an only partially followed convention.
> And at least for RISC-V gcc doesn't know about uclinux tuples, so
> switch back to the normal Linux one for now.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> [Damien]
> * Make the change conditional on BR2_riscv arch being "y".
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>  package/Makefile.in | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/package/Makefile.in b/package/Makefile.in
> index 51f5cbce4f..28c470aea6 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -39,9 +39,14 @@ endif
>  # Compute GNU_TARGET_NAME
>  GNU_TARGET_NAME = $(ARCH)-$(TARGET_VENDOR)-$(TARGET_OS)-$(LIBC)$(ABI)
>  
> -# FLAT binary format needs uclinux
> +# FLAT binary format needs uclinux, except RISC-V which needs
> +# the regular linux name.
>  ifeq ($(BR2_BINFMT_FLAT),y)
> +ifeq ($(BR2_riscv),y)
> +TARGET_OS = linux
> +else
>  TARGET_OS = uclinux
> +endif
>  else
>  TARGET_OS = linux
>  endif

I think I'd like a more compact solution:

    # FLAT binary format needs uclinux, except for riscv which needs the regular linux name.
    ifeq ($(BR2_riscv):$(BR2_BINFMT_FLAT),:y)
    TARGET_OS = uclinux
    else
    TARGET_OS = linux
    endif

No need to resend just for that.

Regards,
Yann E. MORIN.

> -- 
> 2.26.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-09-08 21:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 11:33 [Buildroot] [PATCH v2 0/6] Add support for Kendryte K210 RISC-V boards Damien Le Moal
2020-09-08 11:33 ` [Buildroot] [PATCH v2 1/6] toolchain/buildroot: allow uclibc-ng for riscv Damien Le Moal
2020-09-08 21:49   ` Yann E. MORIN
2020-10-06 21:40   ` Thomas Petazzoni
2020-10-06 22:53     ` Damien Le Moal
2020-10-08 19:33     ` Thomas Petazzoni
2020-10-12  5:00       ` Damien Le Moal
2020-10-12  5:18         ` Waldemar Brodkorb
2020-10-12  5:28           ` Damien Le Moal
2020-09-08 11:33 ` [Buildroot] [PATCH v2 2/6] arch/config: Make RISC-V MMU optional Damien Le Moal
2020-09-09 17:44   ` Alistair Francis
2020-10-06 21:46   ` Thomas Petazzoni
2020-10-06 22:58     ` Damien Le Moal
2020-09-08 11:33 ` [Buildroot] [PATCH v2 3/6] package/elf2flt: add RISC-V support Damien Le Moal
2020-09-09  6:45   ` Peter Korsgaard
2020-09-09  6:48     ` Damien Le Moal
2020-10-06 21:47   ` Thomas Petazzoni
2020-10-06 23:14     ` Damien Le Moal
2020-09-08 11:33 ` [Buildroot] [PATCH v2 4/6] package make: build RISC-V nommu builds as linux Damien Le Moal
2020-09-08 21:56   ` Yann E. MORIN [this message]
2020-09-08 11:33 ` [Buildroot] [PATCH v2 5/6] package/uclibc: fix compilation errors Damien Le Moal
2020-09-08 22:06   ` Yann E. MORIN
2020-09-09  5:38     ` Petr Vorel
2020-09-09  6:21       ` Damien Le Moal
2020-10-06 21:49   ` Thomas Petazzoni
2020-10-06 23:14     ` Damien Le Moal
2020-09-08 11:33 ` [Buildroot] [PATCH v2 6/6] board: Add configuration for Kendryte K210 boards Damien Le Moal
2020-09-09  6:49 ` [Buildroot] [PATCH v2 0/6] Add support for Kendryte K210 RISC-V boards Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908215614.GG14354@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.