From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0589C43461 for ; Wed, 9 Sep 2020 08:20:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D365F2076C for ; Wed, 9 Sep 2020 08:20:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EizrwYT6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D365F2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFvLV-0005is-VQ for qemu-devel@archiver.kernel.org; Wed, 09 Sep 2020 04:20:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFvKU-0004NA-Oi for qemu-devel@nongnu.org; Wed, 09 Sep 2020 04:19:46 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:41439 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kFvKS-000415-Gs for qemu-devel@nongnu.org; Wed, 09 Sep 2020 04:19:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599639583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vqLk/FkfUmIm9HIoVhcuks3zAexmcT1A9IdA6PdQqiQ=; b=EizrwYT6WN0oGnaUvQjQW+u5bgL95jBaPuUMqA6N0zrdPdjMAJ5qQq30zBH2CmJfJKE3tz 5/4EsOn6iNcNrqcNUtClaFCcapdqjy0wqwikCflcXRz8WP9H6Ea0zgiSBdoA8lcpujoTFs dl3p71yGQC02NUufessMSahlK2cq1zI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-9-Nh3-lI8VMBqzgzhc_o2L3A-1; Wed, 09 Sep 2020 04:19:40 -0400 X-MC-Unique: Nh3-lI8VMBqzgzhc_o2L3A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 72F24107464A; Wed, 9 Sep 2020 08:19:38 +0000 (UTC) Received: from linux.fritz.box (ovpn-113-221.ams2.redhat.com [10.36.113.221]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FBCF60C47; Wed, 9 Sep 2020 08:19:33 +0000 (UTC) Date: Wed, 9 Sep 2020 10:19:31 +0200 From: Kevin Wolf To: Yonggang Luo Subject: Re: [PATCH 08/16] block: get file-win32.c handle locking option consistence with file-posix.c Message-ID: <20200909081931.GC5219@linux.fritz.box> References: <20200908194820.702-1-luoyonggang@gmail.com> <20200908194820.702-9-luoyonggang@gmail.com> MIME-Version: 1.0 In-Reply-To: <20200908194820.702-9-luoyonggang@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=kwolf@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/09 03:05:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Lieven , Ed Maste , Michael Roth , qemu-block@nongnu.org, Stefan Weil , Xie Changlong , Richard Henderson , qemu-devel@nongnu.org, Max Reitz , Gerd Hoffmann , Wen Congyang , Li-Wen Hsu , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 08.09.2020 um 21:48 hat Yonggang Luo geschrieben: > Signed-off-by: Yonggang Luo > --- > block/file-win32.c | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) This is almost the same as my separately posted 'file-win32: Fix "locking" option', except that you changed the order of variable definitions which will cause a merge conflict. When you take patches from other people, you should correctly attribute them and not make them look as if they were your own. Commit messages should not be empty, but explain the motivation for the change. In this case, dropping the patch is easiest because my patch is already in a pull request and will probably be merged soon. Kevin