From: Simon Horman <simon.horman@netronome.com>
To: Paul Davey <paul.davey@alliedtelesis.co.nz>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] ipmr: Use full VIF ID in netlink cache reports
Date: Wed, 9 Sep 2020 10:51:30 +0200 [thread overview]
Message-ID: <20200909085128.GA14965@netronome.com> (raw)
In-Reply-To: <20200907220408.32385-4-paul.davey@alliedtelesis.co.nz>
On Tue, Sep 08, 2020 at 10:04:08AM +1200, Paul Davey wrote:
> Insert the full 16 bit VIF ID into ipmr Netlink cache reports.
>
> The VIF_ID attribute has 32 bits of space so can store the full VIF ID
> extracted from the high and low byte fields in the igmpmsg.
>
> Signed-off-by: Paul Davey <paul.davey@alliedtelesis.co.nz>
> ---
> net/ipv4/ipmr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
> index 4809318f591b..939792a38814 100644
> --- a/net/ipv4/ipmr.c
> +++ b/net/ipv4/ipmr.c
> @@ -2432,7 +2432,7 @@ static void igmpmsg_netlink_event(struct mr_table *mrt, struct sk_buff *pkt)
> rtgenm = nlmsg_data(nlh);
> rtgenm->rtgen_family = RTNL_FAMILY_IPMR;
> if (nla_put_u8(skb, IPMRA_CREPORT_MSGTYPE, msg->im_msgtype) ||
> - nla_put_u32(skb, IPMRA_CREPORT_VIF_ID, msg->im_vif) ||
> + nla_put_u32(skb, IPMRA_CREPORT_VIF_ID, msg->im_vif | (msg->im_vif_hi << 8)) ||
nit: the inner parentheses seem unnecessary
Otherwise, FWIIW, this series looks good to me.
> nla_put_in_addr(skb, IPMRA_CREPORT_SRC_ADDR,
> msg->im_src.s_addr) ||
> nla_put_in_addr(skb, IPMRA_CREPORT_DST_ADDR,
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-09-09 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 22:04 [PATCH net-next v2 0/3] Allow more than 255 IPv4 multicast interfaces Paul Davey
2020-09-07 22:04 ` [PATCH net-next v2 1/3] ipmr: Add route table ID to netlink cache reports Paul Davey
2020-09-07 22:04 ` [PATCH net-next v2 2/3] ipmr: Add high byte of VIF ID to igmpmsg Paul Davey
2020-09-07 22:04 ` [PATCH net-next v2 3/3] ipmr: Use full VIF ID in netlink cache reports Paul Davey
2020-09-09 8:51 ` Simon Horman [this message]
2020-09-10 19:26 ` [PATCH net-next v2 0/3] Allow more than 255 IPv4 multicast interfaces David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909085128.GA14965@netronome.com \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.davey@alliedtelesis.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.