From: Kent Gibson <warthog618@gmail.com>
To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
bgolaszewski@baylibre.com, linus.walleij@linaro.org
Subject: Re: [PATCH v7 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL
Date: Wed, 9 Sep 2020 17:24:01 +0800 [thread overview]
Message-ID: <20200909092401.GA1431678@sol> (raw)
In-Reply-To: <20200905133549.24606-8-warthog618@gmail.com>
On Sat, Sep 05, 2020 at 09:35:36PM +0800, Kent Gibson wrote:
> Add support for requesting lines using the GPIO_V2_GET_LINE_IOCTL, and
> returning their current values using GPIO_V2_LINE_GET_VALUES_IOCTL.
>
> The struct linereq implementation is based on the v1 struct linehandle
> implementation.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
>
[snip]
> if (copy_from_user(&offset, ip, sizeof(offset)))
> return -EFAULT;
> @@ -1104,6 +1505,25 @@ int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt)
> MAJOR(devt), gdev->id);
>
> return 0;
> + /*
> + * array sizes must ensure 64-bit alignment and not create holes in
> + * the struct packing.
> + */
> + BUILD_BUG_ON(IS_ALIGNED(GPIO_V2_LINES_MAX, 2));
> + BUILD_BUG_ON(IS_ALIGNED(GPIO_MAX_NAME_SIZE, 8));
> +
> + /*
> + * check that uAPI structs are 64-bit aligned for 32/64-bit
> + * compatibility
> + */
> + BUILD_BUG_ON(IS_ALIGNED(sizeof(struct gpio_v2_line_attribute), 8));
> + BUILD_BUG_ON(IS_ALIGNED(sizeof(struct gpio_v2_line_config_attribute), 8));
> + BUILD_BUG_ON(IS_ALIGNED(sizeof(struct gpio_v2_line_config), 8));
> + BUILD_BUG_ON(IS_ALIGNED(sizeof(struct gpio_v2_line_request), 8));
> + BUILD_BUG_ON(IS_ALIGNED(sizeof(struct gpio_v2_line_info), 8));
> + BUILD_BUG_ON(IS_ALIGNED(sizeof(struct gpio_v2_line_info_changed), 8));
> + BUILD_BUG_ON(IS_ALIGNED(sizeof(struct gpio_v2_line_event), 8));
> + BUILD_BUG_ON(IS_ALIGNED(sizeof(struct gpio_v2_line_values), 8));
> }
>
A couple of things here - these should all be !IS_ALIGNED.
And the BUILD_BUG_ON gets compiled out, and so doesn't fail, if they are
after the return.
How would you like that fixed - v8 or a patch once v7 is in?
Cheers,
Kent.
next prev parent reply other threads:[~2020-09-09 9:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 13:35 [PATCH v7 00/20] gpio: cdev: add uAPI v2 Kent Gibson
2020-09-05 13:35 ` [PATCH v7 01/20] gpiolib: cdev: desc_to_lineinfo should set info offset Kent Gibson
2020-09-05 13:35 ` [PATCH v7 02/20] gpiolib: cdev: replace strncpy with strscpy Kent Gibson
2020-09-05 13:35 ` [PATCH v7 03/20] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes Kent Gibson
2020-09-05 13:35 ` [PATCH v7 04/20] gpio: uapi: define uAPI v2 Kent Gibson
2020-09-05 13:35 ` [PATCH v7 05/20] gpiolib: make cdev a build option Kent Gibson
2020-09-05 13:35 ` [PATCH v7 06/20] gpiolib: add build option for CDEV v1 ABI Kent Gibson
2020-09-05 13:35 ` [PATCH v7 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL Kent Gibson
2020-09-09 9:24 ` Kent Gibson [this message]
2020-09-09 9:26 ` Bartosz Golaszewski
2020-09-09 9:35 ` Kent Gibson
2020-09-09 9:41 ` Bartosz Golaszewski
2020-09-09 9:49 ` Kent Gibson
2020-09-09 9:54 ` Bartosz Golaszewski
2020-09-15 10:31 ` Andy Shevchenko
2020-09-20 11:12 ` Kent Gibson
2020-09-24 13:36 ` Bartosz Golaszewski
2020-09-24 13:40 ` Kent Gibson
2020-09-05 13:35 ` [PATCH v7 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL Kent Gibson
2020-09-05 13:35 ` [PATCH v7 09/20] gpiolib: cdev: support edge detection for uAPI v2 Kent Gibson
2020-09-05 13:35 ` [PATCH v7 10/20] gpiolib: cdev: support GPIO_V2_LINE_SET_CONFIG_IOCTL Kent Gibson
2020-09-05 13:35 ` [PATCH v7 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL Kent Gibson
2020-09-05 13:35 ` [PATCH v7 12/20] gpiolib: cdev: support setting debounce Kent Gibson
2020-09-05 13:35 ` [PATCH v7 13/20] gpio: uapi: document uAPI v1 as deprecated Kent Gibson
2020-09-05 13:35 ` [PATCH v7 14/20] tools: gpio: port lsgpio to v2 uAPI Kent Gibson
2020-09-05 13:35 ` [PATCH v7 15/20] tools: gpio: port gpio-watch " Kent Gibson
2020-09-05 13:35 ` [PATCH v7 16/20] tools: gpio: rename nlines to num_lines Kent Gibson
2020-09-05 13:35 ` [PATCH v7 17/20] tools: gpio: port gpio-hammer to v2 uAPI Kent Gibson
2020-09-05 13:35 ` [PATCH v7 18/20] tools: gpio: port gpio-event-mon " Kent Gibson
2020-09-05 13:35 ` [PATCH v7 19/20] tools: gpio: add multi-line monitoring to gpio-event-mon Kent Gibson
2020-09-05 13:35 ` [PATCH v7 20/20] tools: gpio: add debounce support " Kent Gibson
2020-09-08 16:07 ` [PATCH v7 00/20] gpio: cdev: add uAPI v2 Bartosz Golaszewski
2020-09-09 1:16 ` Kent Gibson
2020-09-09 7:52 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909092401.GA1431678@sol \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.