From: Pavel Machek <pavel@denx.de>
To: Felipe Balbi <balbi@kernel.org>
Cc: "Paul Cercueil" <paul@crapouillou.net>,
周琰杰 <zhouyanjie@wanyeetech.com>, 周正 <sernia.zhou@foxmail.com>,
漆鹏振 <aric.pzqi@ingenic.com>,
od@zcrc.me, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register
Date: Wed, 9 Sep 2020 12:23:45 +0200 [thread overview]
Message-ID: <20200909102345.GA9222@amd> (raw)
In-Reply-To: <87bliwi5kx.fsf@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
Hi!
> >>> - reg = USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT
> >>> | USBPCR_TXPREEMPHTUNE |
> >>> + return USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT |
> >>> USBPCR_TXPREEMPHTUNE |
> >>> USBPCR_COMMONONN | USBPCR_POR;
> >>> - writel(reg, priv->base + REG_USBPCR_OFFSET);
> >>
> >> not a bug fix
> >
> > Well, if you don't like my bug fix, next time wait for my Reviewed-by.
>
> why so angry? Take a break every once in a while. Besides, someone else
> already sent the oneliner before you ;-)
Your behaviour is pretty good explanation for angry people on the
mailing list.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2020-09-09 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 12:43 [PATCH 0/1] USB: PHY: JZ4770: Next time, please test it Paul Cercueil
2020-08-27 12:43 ` [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register Paul Cercueil
2020-08-27 12:58 ` Felipe Balbi
2020-08-27 13:11 ` Paul Cercueil
2020-08-27 13:25 ` Felipe Balbi
2020-08-27 13:50 ` Paul Cercueil
2020-08-27 14:26 ` Felipe Balbi
2020-08-27 15:35 ` Zhou Yanjie
2020-09-09 10:23 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909102345.GA9222@amd \
--to=pavel@denx.de \
--cc=aric.pzqi@ingenic.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=sernia.zhou@foxmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.