From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B913AC43461 for ; Wed, 9 Sep 2020 08:44:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5330A215A4 for ; Wed, 9 Sep 2020 08:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599641091; bh=7aj6TZRYTpnCPLk9ceqzI/NIm/WKHH25lCYgnznwZl4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=m5pvZ8NuQwQMNm58EAfGnBGwLv0yszWB8mltr3L0aCwNuHpPL9Kyx7LhSjZuyCflH U6GCPMECniivieVxlcapzBNNUdkKaWYdhTIbMD5nrB5s8gtDUZJChK7rSJq+nGA9+w KongX8UME9Vbr1Aw4DzBmgQy4GbaNUxkejdrIF78= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728197AbgIIIou (ORCPT ); Wed, 9 Sep 2020 04:44:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:37500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725864AbgIIIot (ORCPT ); Wed, 9 Sep 2020 04:44:49 -0400 Received: from coco.lan (ip5f5ad5d6.dynamic.kabel-deutschland.de [95.90.213.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73B6C207DE; Wed, 9 Sep 2020 08:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599641089; bh=7aj6TZRYTpnCPLk9ceqzI/NIm/WKHH25lCYgnznwZl4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZsJvogeKmYvjXST5nsKvbxhyxSkLRrj5/gPelQBLh2txBWULugJGv9GChFxkM7ftc G6yR1KNd0huzwvhv/ozYfJOFoQGHXSBlXnpx2RMUFbFr0ScooSFFG0bGIEEgtta/5h Z0P5cJ5wWKdwObLhYl5GDGmzF0l7CT6spVfw99uQ= Date: Wed, 9 Sep 2020 10:44:42 +0200 From: Mauro Carvalho Chehab To: Greg Kroah-Hartman Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Yu Chen , John Stultz , Manivannan Sadhasivam , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , "David S. Miller" , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/11] misc: hisi_hikey_usb: Driver to support onboard USB gpio hub on Hikey960 Message-ID: <20200909104442.20f63e9b@coco.lan> In-Reply-To: <20200909083555.GA579996@kroah.com> References: <20200909083555.GA579996@kroah.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, 9 Sep 2020 10:35:55 +0200 Greg Kroah-Hartman escreveu: > On Mon, Sep 07, 2020 at 05:59:32PM +0200, Mauro Carvalho Chehab wrote: > > From: Yu Chen > > > > The HiKey960 has a fairly complex USB configuration due to it > > needing to support a USB-C port for host/device mode and multiple > > USB-A ports in host mode, all using a single USB controller. > > > > See schematics here: > > https://github.com/96boards/documentation/raw/master/consumer/hikey/hikey960/hardware-docs/HiKey960_Schematics.pdf > > > > This driver acts as a usb-role-switch intermediary, intercepting > > the role switch notifications from the tcpm code, and passing > > them on to the dwc3 core. > > > > In doing so, it also controls the onboard hub and power gpios in > > order to properly route the data lines between the USB-C port > > and the onboard hub to the USB-A ports. > > > > Signed-off-by: Yu Chen > > [jstultz: Major rework to make the driver a usb-role-switch > > intermediary] > > Signed-off-by: John Stultz > > Signed-off-by: Mauro Carvalho Chehab > > --- > > MAINTAINERS | 7 ++ > > drivers/misc/Kconfig | 9 ++ > > drivers/misc/Makefile | 1 + > > drivers/misc/hisi_hikey_usb.c | 205 ++++++++++++++++++++++++++++++++++ > > 4 files changed, 222 insertions(+) > > create mode 100644 drivers/misc/hisi_hikey_usb.c > > Can this, and the next patch, go into my char-misc tree independent of > the other patches in this series? Yes, they can go via char-misc tree. The drivers are independent. > Or do they all need to go in together? For USB functionality to actually work, both drivers are needed. The DTS patch assumes both drivers to be merged. While I don't see any big issue if this getting merged via one of the trees (either together with PHY or with misc), if you prefer, I can split it into two different patches (at the cost of probably causing some trivial conflict when both gets merged upstream). Thanks, Mauro