From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] extcon: ptn5150: Do not print error during probe if nothing is attached
Date: Wed, 9 Sep 2020 17:01:29 +0200 [thread overview]
Message-ID: <20200909150129.12476-2-krzk@kernel.org> (raw)
In-Reply-To: <20200909150129.12476-1-krzk@kernel.org>
The commit af71b7e384cd ("extcon: ptn5150: Check current USB mode when
probing") reused code for checking CC status register in the probe path
to determine what is initially connected. However if nothing is
connected, the CC status register will have 0x0 value and print an error
message:
ptn5150 1-003d: Unknown Port status : 0
This is not an error. Also any other unknown port status values are not
really errors but unhandled cases.
Fixes: af71b7e384cd ("extcon: ptn5150: Check current USB mode when probing")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/extcon/extcon-ptn5150.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index 1b68f56d8372..5b9a3cf8df26 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -97,7 +97,6 @@ static void ptn5150_check_state(struct ptn5150_info *info)
extcon_set_state_sync(info->edev, EXTCON_USB_HOST, true);
break;
default:
- dev_err(info->dev, "Unknown Port status : %x\n", port_status);
break;
}
}
--
2.17.1
next prev parent reply other threads:[~2020-09-09 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200909172007epcas1p2fe01380c62ca112a19283f2dc63e75f9@epcas1p2.samsung.com>
2020-09-09 15:01 ` [PATCH 1/2] extcon: ptn5150: Use defines for registers Krzysztof Kozlowski
2020-09-09 15:01 ` Krzysztof Kozlowski [this message]
2020-09-11 3:14 ` Chanwoo Choi
2020-09-11 5:38 ` Krzysztof Kozlowski
2020-09-11 8:03 ` Chanwoo Choi
2020-09-11 7:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909150129.12476-2-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=vijaikumar.kanagarajan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.