From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-next] RDMA/core: Change how failing destroy is handled during uobj abort
Date: Wed, 9 Sep 2020 13:19:26 -0300 [thread overview]
Message-ID: <20200909161926.GA834651@nvidia.com> (raw)
In-Reply-To: <20200902081708.746631-1-leon@kernel.org>
On Wed, Sep 02, 2020 at 11:17:08AM +0300, Leon Romanovsky wrote:
> From: Jason Gunthorpe <jgg@nvidia.com>
>
> Currently it triggers a WARN_ON and then goes ahead and destroys the
> uobject anyhow, leaking any driver memory.
>
> The only place that leaks driver memory should be during FD close() in
> uverbs_destroy_ufile_hw().
>
> Drivers are only allowed to fail destroy uobjects if they guarentee
> destroy will eventually succeed. uverbs_destroy_ufile_hw() provides the
> loop to give the driver that chance.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/core/rdma_core.c | 30 ++++++++++++++---------------
> include/rdma/ib_verbs.h | 5 -----
> 2 files changed, 15 insertions(+), 20 deletions(-)
Applied to for-next
Jason
prev parent reply other threads:[~2020-09-09 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 8:17 [PATCH rdma-next] RDMA/core: Change how failing destroy is handled during uobj abort Leon Romanovsky
2020-09-09 16:19 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909161926.GA834651@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.