From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DB5C43461 for ; Wed, 9 Sep 2020 18:15:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5ED872078E for ; Wed, 9 Sep 2020 18:15:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599675354; bh=uWQl3F1a56D31XTKtlW56i9v22Kw/H48cIk9Ucu5yeI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=B+NF7W0IlGIyVElIpQdtAfboGpiZU7I6b+0pyb8YGmkp243OP3vBabCTvkhnQ3PeF 4crWLL8+bIG7yqdpnb/3BrSYKBhzCv9huaei4DlklcZSAZd4APtp+JzTgRsNUJxVgB wMVjyXsNvmB0+m/AaCHcKxeRhSVeTQvu8QV/wFFY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726726AbgIISPv (ORCPT ); Wed, 9 Sep 2020 14:15:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:34898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725826AbgIISPt (ORCPT ); Wed, 9 Sep 2020 14:15:49 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 42FFF2078E; Wed, 9 Sep 2020 18:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599675348; bh=uWQl3F1a56D31XTKtlW56i9v22Kw/H48cIk9Ucu5yeI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wCIL2ANg0kpJJAT6Xybyfs60+yPM6hkIU0aYTYG+Cd/IKAfRCD8UR5oHSKsk0Hxz+ zSZ3Z+YrgVP8DFr7aaw6FmZEiwhQ430pZ+vbS93I5+LJ4BAhjiqv/GUIDv3ooPckQV U6DEZrdlU4OLUc6yCtJQCSsbKhCfxCpVN5SySIqA= Date: Wed, 9 Sep 2020 20:15:56 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Yu Chen , John Stultz , Manivannan Sadhasivam , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , "David S. Miller" , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/11] misc: hisi_hikey_usb: Driver to support onboard USB gpio hub on Hikey960 Message-ID: <20200909181556.GC1007128@kroah.com> References: <20200909083555.GA579996@kroah.com> <20200909104442.20f63e9b@coco.lan> <20200909115547.1678cd88@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200909115547.1678cd88@coco.lan> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 09, 2020 at 11:55:47AM +0200, Mauro Carvalho Chehab wrote: > Em Wed, 9 Sep 2020 10:44:42 +0200 > Mauro Carvalho Chehab escreveu: > > > Em Wed, 9 Sep 2020 10:35:55 +0200 > > Greg Kroah-Hartman escreveu: > > > > > On Mon, Sep 07, 2020 at 05:59:32PM +0200, Mauro Carvalho Chehab wrote: > > > > From: Yu Chen > > > > > > > > The HiKey960 has a fairly complex USB configuration due to it > > > > needing to support a USB-C port for host/device mode and multiple > > > > USB-A ports in host mode, all using a single USB controller. > > > > > > > > See schematics here: > > > > https://github.com/96boards/documentation/raw/master/consumer/hikey/hikey960/hardware-docs/HiKey960_Schematics.pdf > > > > > > > > This driver acts as a usb-role-switch intermediary, intercepting > > > > the role switch notifications from the tcpm code, and passing > > > > them on to the dwc3 core. > > > > > > > > In doing so, it also controls the onboard hub and power gpios in > > > > order to properly route the data lines between the USB-C port > > > > and the onboard hub to the USB-A ports. > > > > > > > > Signed-off-by: Yu Chen > > > > [jstultz: Major rework to make the driver a usb-role-switch > > > > intermediary] > > > > Signed-off-by: John Stultz > > > > Signed-off-by: Mauro Carvalho Chehab > > > > --- > > > > MAINTAINERS | 7 ++ > > > > drivers/misc/Kconfig | 9 ++ > > > > drivers/misc/Makefile | 1 + > > > > drivers/misc/hisi_hikey_usb.c | 205 ++++++++++++++++++++++++++++++++++ > > > > 4 files changed, 222 insertions(+) > > > > create mode 100644 drivers/misc/hisi_hikey_usb.c > > > > > > Can this, and the next patch, go into my char-misc tree independent of > > > the other patches in this series? > > > > Yes, they can go via char-misc tree. The drivers are independent. > > > > Forgot to ask: should I re-send the patches on a separate series? Sure, that would make things much easier for me so that I "know" I have the right patches to apply. thanks, greg k-h