From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 5/7] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params()
Date: Wed, 09 Sep 2020 20:32:38 +0800 [thread overview]
Message-ID: <202009092005.icpUSDaS%lkp@intel.com> (raw)
In-Reply-To: <20200908182437.2870281-6-bryan.odonoghue@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 9952 bytes --]
Hi Bryan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc4 next-20200908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/net/wireless/ath/wcn36xx/smd.h:20,
from drivers/net/wireless/ath/wcn36xx/smd.c:23:
drivers/net/wireless/ath/wcn36xx/wcn36xx.h:272:42: warning: 'struct wcn36xx_hal_supported_rates_v1' declared inside parameter list will not be visible outside of this definition or declaration
272 | void wcn36xx_set_default_rates_v1(struct wcn36xx_hal_supported_rates_v1 *rates);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c:176:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_vht_params' [-Wmissing-prototypes]
176 | void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_vht_params':
drivers/net/wireless/ath/wcn36xx/smd.c:183:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
183 | sta_params->vht_capable = sta->vht_cap.vht_supported;
| ^~~~~~~~~~~
| ht_capable
drivers/net/wireless/ath/wcn36xx/smd.c:184:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
184 | sta_params->vht_ldpc_enabled =
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:187:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
187 | sta_params->vht_tx_mu_beamformee_capable =
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:189:18: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
189 | if (sta_params->vht_tx_mu_beamformee_capable)
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:190:21: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
190 | sta_params->vht_tx_bf_enabled = 1;
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:192:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
192 | sta_params->vht_tx_mu_beamformee_capable = 0;
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:194:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
194 | sta_params->vht_tx_channel_width_set = 0;
| ^~~~~~~~~~~~~~~~~~~~~~~~
| tx_channel_width_set
drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
>> drivers/net/wireless/ath/wcn36xx/smd.c:198:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_ht_ldpc_params' [-Wmissing-prototypes]
198 | void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_ht_ldpc_params':
drivers/net/wireless/ath/wcn36xx/smd.c:202:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
202 | sta_params->ht_ldpc_enabled =
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
drivers/net/wireless/ath/wcn36xx/smd.c:223:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_vht_params' [-Wmissing-prototypes]
223 | void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_vht_params':
drivers/net/wireless/ath/wcn36xx/smd.c:226:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
226 | if (wcn->rf_id == RF_IRIS_WCN3680) {
| ^~~~~~~~~~~~~~~
| RF_IRIS_WCN3620
drivers/net/wireless/ath/wcn36xx/smd.c:226:20: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/ath/wcn36xx/smd.c:227:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
227 | sta_params->vht_capable = 1;
| ^~~~~~~~~~~
| ht_capable
drivers/net/wireless/ath/wcn36xx/smd.c:228:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
228 | sta_params->vht_tx_mu_beamformee_capable = 1;
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:230:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
230 | sta_params->vht_capable = 0;
| ^~~~~~~~~~~
| ht_capable
drivers/net/wireless/ath/wcn36xx/smd.c:231:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
231 | sta_params->vht_tx_mu_beamformee_capable = 0;
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:234:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
234 | sta_params->vht_ldpc_enabled = 0;
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:235:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
235 | sta_params->vht_tx_channel_width_set = 0;
| ^~~~~~~~~~~~~~~~~~~~~~~~
| tx_channel_width_set
drivers/net/wireless/ath/wcn36xx/smd.c:236:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
236 | sta_params->vht_tx_bf_enabled = 0;
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
drivers/net/wireless/ath/wcn36xx/smd.c:239:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_ht_ldpc_params' [-Wmissing-prototypes]
239 | void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_ht_ldpc_params':
drivers/net/wireless/ath/wcn36xx/smd.c:242:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
242 | if (wcn->rf_id == RF_IRIS_WCN3680)
| ^~~~~~~~~~~~~~~
| RF_IRIS_WCN3620
drivers/net/wireless/ath/wcn36xx/smd.c:243:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
243 | sta_params->ht_ldpc_enabled = 1;
| ^~
drivers/net/wireless/ath/wcn36xx/smd.c:245:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
245 | sta_params->ht_ldpc_enabled = 0;
| ^~
# https://github.com/0day-ci/linux/commit/87028248512b3c9d58fd5ebe519068336a8cab67
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
git checkout 87028248512b3c9d58fd5ebe519068336a8cab67
vim +/wcn36xx_smd_set_sta_ht_ldpc_params +198 drivers/net/wireless/ath/wcn36xx/smd.c
175
176 void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
177 struct ieee80211_sta *sta,
178 struct wcn36xx_hal_config_sta_params_v1 *sta_params)
179 {
180 if (sta->vht_cap.vht_supported) {
181 unsigned long caps = sta->vht_cap.cap;
182
183 sta_params->vht_capable = sta->vht_cap.vht_supported;
184 sta_params->vht_ldpc_enabled =
185 is_cap_supported(caps, IEEE80211_VHT_CAP_RXLDPC);
186 if (get_feat_caps(wcn->fw_feat_caps, MU_MIMO)) {
187 sta_params->vht_tx_mu_beamformee_capable =
188 is_cap_supported(caps, IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE);
189 if (sta_params->vht_tx_mu_beamformee_capable)
190 sta_params->vht_tx_bf_enabled = 1;
191 } else {
> 192 sta_params->vht_tx_mu_beamformee_capable = 0;
193 }
194 sta_params->vht_tx_channel_width_set = 0;
195 }
196 }
197
> 198 void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
199 struct wcn36xx_hal_config_sta_params_v1 *sta_params)
200 {
201 if (sta->ht_cap.ht_supported) {
202 sta_params->ht_ldpc_enabled =
203 is_cap_supported(sta->ht_cap.cap, IEEE80211_HT_CAP_LDPC_CODING);
204 }
205 }
206
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74730 bytes --]
next prev parent reply other threads:[~2020-09-09 12:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 18:24 [PATCH v3 0/7] wcn36xx: Add a set of helpers to enable VHT parameter passing Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 1/7] wcn36xx: Add wcn36xx_set_default_rates_v1 Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 2/7] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params() Bryan O'Donoghue
2020-09-09 7:23 ` kernel test robot
2020-09-09 7:23 ` kernel test robot
2020-09-09 11:58 ` Bryan O'Donoghue
2020-09-09 11:58 ` Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 3/7] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params() Bryan O'Donoghue
2020-09-09 8:49 ` kernel test robot
2020-09-08 18:24 ` [PATCH v3 4/7] wcn36xx: Add wcn36xx_smd_set_sta_vht_params() Bryan O'Donoghue
2020-09-09 10:49 ` kernel test robot
2020-09-08 18:24 ` [PATCH v3 5/7] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params() Bryan O'Donoghue
2020-09-09 12:32 ` kernel test robot [this message]
2020-09-08 18:24 ` [PATCH v3 6/7] wcn36xx: Add wcn36xx_smd_set_bss_vht_params() Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 7/7] wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1() Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009092005.icpUSDaS%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.