From: Rob Herring <robh@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-iio@vger.kernel.org, Andy Gross <agross@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-pm@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Amit Kucheria <amitk@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v3 02/10] dt-bindings: thermal: qcom: add adc-thermal monitor bindings
Date: Wed, 9 Sep 2020 14:51:33 -0600 [thread overview]
Message-ID: <20200909205133.GA3054559@bogus> (raw)
In-Reply-To: <20200909144248.54327-3-dmitry.baryshkov@linaro.org>
On Wed, 09 Sep 2020 17:42:40 +0300, Dmitry Baryshkov wrote:
> Add bindings for thermal monitor, part of Qualcomm PMIC5 chips. It is a
> close counterpart of VADC part of those PMICs.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/thermal/qcom-spmi-adc-tm5.yaml | 141 ++++++++++++++++++
> 1 file changed, 141 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:25.17-30: Warning (reg_format): /example-0/adc@3100/conn-therm@4f:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:33.13-28: Warning (reg_format): /example-0/adc-tm@3500:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:21.31-29.11: Warning (unit_address_vs_reg): /example-0/adc@3100: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:24.27-28.15: Warning (avoid_default_addr_size): /example-0/adc@3100/conn-therm@4f: Relying on default #address-cells value
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:24.27-28.15: Warning (avoid_default_addr_size): /example-0/adc@3100/conn-therm@4f: Relying on default #size-cells value
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size'
Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dts:39.26-45.15: Warning (io_channels_property): /example-0/adc-tm@3500/conn-therm@0: Missing property '#io-channel-cells' in node /example-0/adc@3100 or bad phandle (referred from io-channels[0])
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: example-0: adc-tm@3500:reg:0: [13568] is too short
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: adc@3100: 'reg' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: adc@3100: '#address-cells' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: adc@3100: '#size-cells' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.example.dt.yaml: adc@3100: '#io-channel-cells' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
See https://patchwork.ozlabs.org/patch/1360722
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-09-09 20:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 14:42 [PATCH v3 00/10] qcom: pm8150: add support for thermal monitoring Dmitry Baryshkov
2020-09-09 14:42 ` [PATCH v3 01/10] iio: adc: qcom-spmi-adc5: fix driver name Dmitry Baryshkov
2020-09-09 14:42 ` [PATCH v3 02/10] dt-bindings: thermal: qcom: add adc-thermal monitor bindings Dmitry Baryshkov
2020-09-09 18:22 ` Jonathan Cameron
2020-09-09 20:51 ` Rob Herring [this message]
2020-09-09 14:42 ` [PATCH v3 03/10] fixp-arith: add a linear interpolation function Dmitry Baryshkov
2020-09-09 14:42 ` [PATCH v3 04/10] iio: adc: qcom-vadc: move several adc5 functions to common file Dmitry Baryshkov
2020-09-09 14:42 ` [PATCH v3 05/10] iio: adc: qcom-vadc-common: use fixp_linear_interpolate Dmitry Baryshkov
2020-09-09 14:42 ` [PATCH v3 06/10] iio: adc: qcom-spmi-adc5: use of_device_get_match_data Dmitry Baryshkov
2020-09-09 18:05 ` Jonathan Cameron
2020-09-09 14:42 ` [PATCH v3 07/10] iio: provide of_iio_channel_get_by_name() and devm_ version it Dmitry Baryshkov
2020-09-09 18:09 ` Jonathan Cameron
2020-09-09 14:42 ` [PATCH v3 08/10] thermal: qcom: add support for adc-tm5 PMIC thermal monitor Dmitry Baryshkov
2020-09-09 18:18 ` Jonathan Cameron
2020-09-09 14:42 ` [PATCH v3 09/10] arm64: dts: qcom: pm8150x: add definitions for adc-tm5 part Dmitry Baryshkov
2020-09-09 14:42 ` [PATCH v3 10/10] arm64: dts: sm8250-mtp: add thermal zones using pmic's adc-tm5 Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909205133.GA3054559@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.