All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD"
Date: Wed, 9 Sep 2020 23:47:22 +0200	[thread overview]
Message-ID: <20200909214722.GV14354@scaer> (raw)
In-Reply-To: <20200909213404.1105535-1-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2020-09-09 23:34 +0200, Thomas Petazzoni spake thusly:
> Since commit efa95b19aeab6bdcd7d5a620e199c2c32cf2516b
> ("package/libxml-parser-perl: make host build use correct compiler"),
> we pass $(HOST_CONFIGURE_OPTS) when building host-libxml-parser-perl,
> in order to use the correct host compiler.
> 
> However, this means that LD="$(HOSTLD)" is passed. However, the
> host-libxml-parser-perl passes compiler arguments to LD, so it really
> assumes that LD is gcc, not ld. For example, it tries to pass
> -mtune=generic.
> 
> So, let's tell host-libxml-parser-perl that LD is "$(HOSTCC)".
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/2ed2e5ccefe9047c597f84d5880de2e8de2bdd94/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, after adding the tested-by tag Joseph gave during our
live discussion on IRC... Thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libxml-parser-perl/libxml-parser-perl.mk | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libxml-parser-perl/libxml-parser-perl.mk b/package/libxml-parser-perl/libxml-parser-perl.mk
> index 100c49633c..37cef2e418 100644
> --- a/package/libxml-parser-perl/libxml-parser-perl.mk
> +++ b/package/libxml-parser-perl/libxml-parser-perl.mk
> @@ -12,9 +12,14 @@ LIBXML_PARSER_PERL_LICENSE = Artistic or GPL-1.0+
>  LIBXML_PARSER_PERL_LICENSE_FILES = README
>  LIBXML_PARSER_PERL_RUN_PERL = `which perl`
>  
> +HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS = \
> +	$(HOST_CONFIGURE_OPTS) \
> +	LD="$(HOSTCC)"
> +
>  define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
>  	(cd $(@D) ; \
> -		$(HOST_CONFIGURE_OPTS) $(LIBXML_PARSER_PERL_RUN_PERL) Makefile.PL \
> +		$(HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS) \
> +			$(LIBXML_PARSER_PERL_RUN_PERL) Makefile.PL \
>  			PREFIX=$(HOST_DIR) \
>  			EXPATLIBPATH=$(HOST_DIR)/lib \
>  			EXPATINCPATH=$(HOST_DIR)/include \
> @@ -25,7 +30,7 @@ define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
>  endef
>  
>  define HOST_LIBXML_PARSER_PERL_BUILD_CMDS
> -	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
> +	$(HOST_MAKE_ENV) $(MAKE) $(HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS) -C $(@D)
>  endef
>  
>  define HOST_LIBXML_PARSER_PERL_INSTALL_CMDS
> -- 
> 2.26.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2020-09-09 21:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 21:34 [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD" Thomas Petazzoni
2020-09-09 21:43 ` Joseph Kogut
2020-09-09 21:47 ` Yann E. MORIN [this message]
2020-09-11 21:19 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909214722.GV14354@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.