From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dave Airlie <airlied@redhat.com>, maarten.lankhorst@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [bug report] drm/i915: Use per object locking in execbuf, v12.
Date: Thu, 10 Sep 2020 11:36:17 +0300 [thread overview]
Message-ID: <20200910083617.GA64330@mwanda> (raw)
Hey Dave,
I think this is a bad merge:
The patch c43ce12328df: "drm/i915: Use per object locking in execbuf,
v12." from Aug 19, 2020, leads to the following static checker
warning:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1459 __reloc_entry_gpu()
warn: signedness bug returning '(-35)'
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
1440 static bool __reloc_entry_gpu(struct i915_execbuffer *eb,
^^^^
This should be int.
1441 struct i915_vma *vma,
1442 u64 offset,
1443 u64 target_addr)
1444 {
1445 const unsigned int gen = eb->reloc_cache.gen;
1446 unsigned int len;
1447 u32 *batch;
1448 u64 addr;
1449
1450 if (gen >= 8)
1451 len = offset & 7 ? 8 : 5;
1452 else if (gen >= 4)
1453 len = 4;
1454 else
1455 len = 3;
1456
1457 batch = reloc_gpu(eb, vma, len);
1458 if (batch == ERR_PTR(-EDEADLK))
1459 return (s64)-EDEADLK;
No need for this cast, btw.
1460 else if (IS_ERR(batch))
1461 return false;
1462
1463 addr = gen8_canonical_addr(vma->node.start + offset);
1464 if (gen >= 8) {
1465 if (offset & 7) {
1466 *batch++ = MI_STORE_DWORD_IMM_GEN4;
1467 *batch++ = lower_32_bits(addr);
1468 *batch++ = upper_32_bits(addr);
1469 *batch++ = lower_32_bits(target_addr);
1470
1471 addr = gen8_canonical_addr(addr + 4);
1472
1473 *batch++ = MI_STORE_DWORD_IMM_GEN4;
1474 *batch++ = lower_32_bits(addr);
1475 *batch++ = upper_32_bits(addr);
regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
reply other threads:[~2020-09-10 8:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910083617.GA64330@mwanda \
--to=dan.carpenter@oracle.com \
--cc=airlied@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.