From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matt Porter <mporter@kernel.crashing.org>, linux-kernel@vger.kernel.org
Cc: Alexandre Bounine <alexandre.bounine@idt.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v1] rapidio: Make it dependent to DMADEVICES
Date: Thu, 10 Sep 2020 12:06:25 +0300 [thread overview]
Message-ID: <20200910090625.GL1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20190813143906.9865-1-andriy.shevchenko@linux.intel.com>
On Tue, Aug 13, 2019 at 05:39:06PM +0300, Andy Shevchenko wrote:
> DMADEVICES option depends on HAS_DMA, and this dependency is ignored
> when DMADEVICES is being selected.
>
> Replace 'select' by 'depends on' in Kconfig for RAPIDIO_DMA_ENGINE.
Yeah, I'm wondering why we got this into kernel much later (as
d2b861002450 ("rapidio: Replace 'select' DMAENGINES 'with depends on'") in
linux next and no one commented on this...
> Fixes: e42d98ebe7d7 ("rapidio: add DMA engine support for RIO data transfers")
> Cc: Alexandre Bounine <alexandre.bounine@idt.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/rapidio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig
> index 677d1aff61b7..788e7830771b 100644
> --- a/drivers/rapidio/Kconfig
> +++ b/drivers/rapidio/Kconfig
> @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS
> config RAPIDIO_DMA_ENGINE
> bool "DMA Engine support for RapidIO"
> depends on RAPIDIO
> - select DMADEVICES
> + depends on DMADEVICES
> select DMA_ENGINE
> help
> Say Y here if you want to use DMA Engine frameork for RapidIO data
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-09-10 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 14:39 [PATCH v1] rapidio: Make it dependent to DMADEVICES Andy Shevchenko
2019-12-09 16:42 ` Andy Shevchenko
2020-09-10 9:06 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910090625.GL1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.bounine@idt.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.