From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: linux-next: Tree for Sep 9 (drivers/usb/typec/mux/intel_pmc_mux.c)
Date: Thu, 10 Sep 2020 13:49:11 +0300 [thread overview]
Message-ID: <20200910104911.GA3709033@kuha.fi.intel.com> (raw)
In-Reply-To: <f2de7078-db94-6914-87af-c0a553daa5cc@infradead.org>
On Wed, Sep 09, 2020 at 09:04:53AM -0700, Randy Dunlap wrote:
> On 9/9/20 3:26 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20200908:
> >
>
> on x86_64:
>
> CC [M] drivers/usb/typec/mux/intel_pmc_mux.o
> ../drivers/usb/typec/mux/intel_pmc_mux.c: In function ‘update_port_status’:
> ../drivers/usb/typec/mux/intel_pmc_mux.c:151:21: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
> port->iom_status = readl(port->pmc->iom_base + IOM_PORT_STATUS_OFFSET +
> ^~~~~
> ../drivers/usb/typec/mux/intel_pmc_mux.c: In function ‘is_memory’:
> ../drivers/usb/typec/mux/intel_pmc_mux.c:524:10: error: implicit declaration of function ‘acpi_dev_resource_memory’; did you mean ‘acpi_os_read_memory’? [-Werror=implicit-function-declaration]
> return !acpi_dev_resource_memory(res, &r);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> acpi_os_read_memory
> ../drivers/usb/typec/mux/intel_pmc_mux.c: In function ‘pmc_usb_probe_iom’:
> ../drivers/usb/typec/mux/intel_pmc_mux.c:539:8: error: implicit declaration of function ‘acpi_dev_get_resources’; did you mean ‘acpi_get_event_resources’? [-Werror=implicit-function-declaration]
> ret = acpi_dev_get_resources(adev, &resource_list, is_memory, NULL);
> ^~~~~~~~~~~~~~~~~~~~~~
> acpi_get_event_resources
> CC drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o
> ../drivers/usb/typec/mux/intel_pmc_mux.c:547:2: error: implicit declaration of function ‘acpi_dev_free_resource_list’; did you mean ‘acpi_get_event_resources’? [-Werror=implicit-function-declaration]
> acpi_dev_free_resource_list(&resource_list);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> acpi_get_event_resources
> ../drivers/usb/typec/mux/intel_pmc_mux.c:550:19: error: dereferencing pointer to incomplete type ‘struct acpi_device’
> put_device(&adev->dev);
It looks like we are missing ACPI dependency in Kconfig and a include.
I'll prepare the fixes.
Thanks Randy,
--
heikki
next prev parent reply other threads:[~2020-09-10 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 10:26 linux-next: Tree for Sep 9 Stephen Rothwell
2020-09-09 16:04 ` linux-next: Tree for Sep 9 (drivers/usb/typec/mux/intel_pmc_mux.c) Randy Dunlap
2020-09-10 10:49 ` Heikki Krogerus [this message]
2020-09-09 17:48 ` linux-next: Tree for Sep 9 (ath11k) Randy Dunlap
2020-09-09 17:48 ` Randy Dunlap
2020-09-10 6:38 ` Kalle Valo
2020-09-10 7:23 ` Kalle Valo
2020-09-10 7:23 ` Kalle Valo
2020-09-10 6:38 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910104911.GA3709033@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.