From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC54C43461 for ; Thu, 10 Sep 2020 11:45:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 206192145D for ; Thu, 10 Sep 2020 11:45:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="RdROvRb0"; dkim=temperror (0-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="is4L3/we"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="N9nu+XDe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 206192145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3C254167B; Thu, 10 Sep 2020 13:44:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3C254167B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599738311; bh=bTEkbH6HW2DF1vdX3JYDJeAfUG5HiHQcw2e4k35usng=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RdROvRb04u6pK5COomftJF9WH/enTb3RqDSceCkq60huW6vIB9B1gzjkHY4jGaF6n yBpWDNMqrCCaamGSlFBEm5mtxfJtsgXHubQp4taCi3YbfB0277lUes/EblmcuDvWiq iJY2aQA5VC8MKljqGp03ZX6MzTz9qJrJNxoqsmVE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B29C5F801F2; Thu, 10 Sep 2020 13:44:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A4C0FF80264; Thu, 10 Sep 2020 13:44:19 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BCCAEF800E9 for ; Thu, 10 Sep 2020 13:44:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BCCAEF800E9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="is4L3/we"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="N9nu+XDe" Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 15634A63; Thu, 10 Sep 2020 07:44:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 10 Sep 2020 07:44:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=L6aec+5VNbg1vuEtr0xqvRZBfyk s20mU6sou+wJVr80=; b=is4L3/welnEADmGHMW7dOsdulV5uq8EMbOE7hRlp5XM tJXb44jh0k9Q6qWn6M/oKft4ZjZvz2PXqh6y/vnwdkinPbInJcd4biLK3SfJ9DY2 XHDe3zZNU+X46D51BxwSmHAdStIpjCWO592Yq2dgwfPrZvOfIqReX1VjBkusw1gt x8gtKXdDIRDLgEP580YN4u2NFHwTIDZdNZUpEiNKU6IBEIUHpervcd1ViS6NgruO jWtcfOZJUfoyhsI68e8A0gqTowloyx7m93lffCmpl0avLy0S6T1Py8X2+xWrYBWb kTm6Uu0nukizM8V816JQ/OHRlR48+d2lxSEXxksqCMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=L6aec+ 5VNbg1vuEtr0xqvRZBfyks20mU6sou+wJVr80=; b=N9nu+XDemjwZm2oO2kQXBz FcCqOUerb1lPfTEJTWcjH0qE/mTtTgjgthejVQak6AwOakYoaBKQwh5u7F9BCtP9 q7JP3TUqIK7BykRVQgMNfa6H3QxM3X03i/zbQ8amgcGUL0EvZGmDJQoKwSE9QBB1 kjQRJbbgvOoSldRHrE5zyFhQ10ITvjxbUWXU1s8NQ9asFZfwJ7OamRJ4U7v3q+Vj S8le0OUs6LxEIEQYuvKLlQsvyTLx+u3chTOXNgvaSIAmlDM4FkzA4oiUj3z53/uy rEVkWoddarPBZWoSL36PvgDe756b9JXLGm53MRYejHxp8nUudcE+nwF7f1Zb+UFQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehjedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvrghkrghs hhhiucfurghkrghmohhtohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjh hpqeenucggtffrrghtthgvrhhnpeelhfeugedvjefgjefgudekfedutedvtddutdeuieev tddtgeetjeekvdefgeefhfenucfkphepudektddrvdefhedrfedrheegnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhhihes shgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Received: from workstation (ad003054.dynamic.ppp.asahi-net.or.jp [180.235.3.54]) by mail.messagingengine.com (Postfix) with ESMTPA id 681A73064685; Thu, 10 Sep 2020 07:44:02 -0400 (EDT) Date: Thu, 10 Sep 2020 20:43:59 +0900 From: Takashi Sakamoto To: Takashi Iwai Subject: Re: [PATCH v2] ALSA: firewire: Replace tasklet with work Message-ID: <20200910114359.GA16550@workstation> Mail-Followup-To: Takashi Iwai , alsa-devel@alsa-project.org References: <20200909163659.21708-1-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200909163659.21708-1-tiwai@suse.de> Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, On Wed, Sep 09, 2020 at 06:36:59PM +0200, Takashi Iwai wrote: > The tasklet is an old API that should be deprecated, usually can be > converted to another decent API. In FireWire driver, a tasklet is > still used for offloading the AMDTP PCM stream handling. It can be > achieved gracefully with a work queued, too. > > This patch replaces the tasklet usage in firewire-lib driver with a > simple work. The conversion is fairly straightforward but for the > in_interrupt() checks that are replaced with the check using the > current_work(). > > Note that in_interrupt() in amdtp_packet tracepoint is still kept as > is. This is the place that is probed by both softirq of 1394 OHCI and > a user task of a PCM application, and the work handling is already > filtered in amdtp_domain_stream_pcm_pointer(). > > Signed-off-by: Takashi Iwai > --- > v1->v2: Drop in_interrupt() conversion in tracepoint > > sound/firewire/amdtp-stream.c | 25 +++++++++++++------------ > sound/firewire/amdtp-stream.h | 2 +- > 2 files changed, 14 insertions(+), 13 deletions(-) The v2 patch looks good to me. Tested-by: Takashi Sakamoto Acked-by: Takashi Sakamoto Thanks for your work! Regards Takashi Sakamoto