From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] fanotify10: Treat ignore mask bug as TCONF for < v5.9
Date: Thu, 10 Sep 2020 17:30:35 +0200 [thread overview]
Message-ID: <20200910153035.GA12601@yuki.lan> (raw)
In-Reply-To: <20200910121628.18505-1-pvorel@suse.cz>
Hi!
> if (ret > 0) {
> - tst_res(TFAIL, "group %d (%x) with %s and "
> - "%s ignore mask got event",
> + tst_res((tst_kvercmp(5, 9, 0)) < 0 ? TCONF : TFAIL,
> + "group %d (%x) with %s and %s ignore mask got event",
> i, fanotify_class[p], mark->name, ignore_mark->name);
I do not like that much, how the tst_kvercmp() is sandwitched inside of
the tst_res() call, since it makes it easier to be overlooked.
The question is how can we do better, maybe set a variable in test
setup?
Other than that it looks fine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-09-10 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 12:16 [LTP] [PATCH 1/1] fanotify10: Treat ignore mask bug as TCONF for < v5.9 Petr Vorel
2020-09-10 14:14 ` Amir Goldstein
2020-09-10 15:25 ` Petr Vorel
2020-09-10 16:11 ` Jan Kara
2020-09-10 15:30 ` Cyril Hrubis [this message]
2020-09-11 2:06 ` Amir Goldstein
2020-09-11 6:56 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910153035.GA12601@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.