From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-comment-return-1449-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id E4BF6985FC1 for ; Thu, 10 Sep 2020 15:07:00 +0000 (UTC) Date: Thu, 10 Sep 2020 17:05:19 +0200 From: Cornelia Huck Message-ID: <20200910170519.478ef661.cohuck@redhat.com> In-Reply-To: References: <159836664741.231431.2775539890399592989.stgit@ahduyck-workstation> <20200825170120.429b3ee8.cohuck@redhat.com> <20200901103356-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Subject: [virtio-comment] Re: [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: Alexander Duyck , "Michael S. Tsirkin" Cc: David Hildenbrand , virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, "Wang, Wei W" List-ID: On Thu, 10 Sep 2020 07:50:29 -0700 Alexander Duyck wrote: > On Tue, Sep 1, 2020 at 7:34 AM Michael S. Tsirkin wrote: > > > > On Tue, Aug 25, 2020 at 01:40:25PM -0700, Alexander Duyck wrote: > > > On Tue, Aug 25, 2020 at 8:01 AM Cornelia Huck wrote: > > > > > > > > On Tue, 25 Aug 2020 07:44:55 -0700 > > > > Alexander Duyck wrote: > > > > > > > > > This patch set is meant to add documentation for balloon features that have > > > > > been recently added to the Linux kernel[1,2] and that were recently added > > > > > to QEMU[3]. > > > > > > > > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/84 > > > > > > > > > > Changes since RFC: > > > > > Incorporated suggestions from Cornelia Huck > > > > > Fixed a few additional spelling errors > > > > > > > > > > Changes since v1: > > > > > Incorporated additional suggestions from Cornelia Huck > > > > > Dropped documentation referring to free page reporting from page poison patch > > > > > > > > > > Changes since v2: > > > > > Rewrote multiple statements based on input from David Hildenbrand > > > > > Dropped use of balloon and deflate from page hinting description > > > > > Dropped use of free page reporting from page poison description > > > > > Cleaned up several spots that didn't match RFC2119 style comments > > > > > Added conformance links. > > > > > Various other clean-ups. > > > > > Updated balloon command IDs based on input from Cornelia Huck > > > > > > > > > > Changes since v3: > > > > > Reordered patches to place free page hinting at end of patch set > > > > > Moved contents out of patch to poison and free page reporting patches > > > > > Updated patch description to document some known issues with feature > > > > > Further clean-ups based on input from David Hildenbrand > > > > > > > > > > Changes since v4: > > > > > Further clean-ups for page hinting based on input from David Hildenbrand > > > > > > > > > > Changes since v5: > > > > > Reverted patcher order changes from v3 placing hinting as first patch > > > > > Addressed comments and added Reviewed-by from Cornelia Huck > > > > > Addressed further items I found in free page hinting > > > > > Added requirement that output buffers be 4 bytes in size > > > > > Replaced reference to descriptor with buffer > > > > > Replaced references to free_page_hint_vq with free_page_vq > > > > > > > > > > Changes since v6: > > > > > Fixed line that was left over from a merge conflict > > > > > Added Reviewed-by from David Hildenbrand > > > > > Created issue and added "Fixes" to cover page > > > > > > > > > > Changes since v7: > > > > > Removed comments from patch 1 describing issues that we fixed or addressed > > > > > Added Acked-by for patch 1 from Cornelia Huck > > > > > > > > > > [1]: https://lore.kernel.org/lkml/20200211224416.29318.44077.stgit@localhost.localdomain/ > > > > > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc > > > > > [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html > > > > > > > > > > --- > > > > > > > > > > Alexander Duyck (3): > > > > > content: Document balloon feature free page hints > > > > > content: Document balloon feature page poison > > > > > content: Document balloon feature free page reporting > > > > > > > > > > > > > > > conformance.tex | 6 + > > > > > content.tex | 286 ++++++++++++++++++++++++++++++++++++++++++++++++++++++- > > > > > 2 files changed, 286 insertions(+), 6 deletions(-) > > > > > > > > > > -- > > > > > > > > > > > > > I think this is good to vote on now. > > > > > > Thanks for the review feedback. If there are no other comments then I > > > request a vote for inclusion. > > > > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/84 > > > > > > - Alex > > > > Ballot created at https://www.oasis-open.org/committees/ballot.php?id=3521 > > Once it concludes, would appreciate a reminder to merge the patch. > > Thanks! > > So it looks like it was voted down due to a bad link in the ballot. Yeah, that wrong link was really unfortunate. > The correct link that references the patch set is in the bugzilla. Do > I need to resubmit the patch set or can a new ballot be created? I think we just need a new vote -- Michael? > > Thanks. > > - Alex > This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/