All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: David Milburn <dmilburn@redhat.com>
Cc: kbusch@kernel.org, david.fugate@linux.intel.com, hch@lst.de,
	linux-nvme@lists.infradead.org, esandeen@redhat.com
Subject: Re: [PATCH] nvme-pci: disable write zeros command for Intel 600P/P3100
Date: Fri, 11 Sep 2020 07:32:27 +0200	[thread overview]
Message-ID: <20200911053227.GA20950@lst.de> (raw)
In-Reply-To: <1599772730-23806-1-git-send-email-dmilburn@redhat.com>

On Thu, Sep 10, 2020 at 04:18:50PM -0500, David Milburn wrote:
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 5e07d5628864..d31e298669a9 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3153,7 +3153,8 @@ static const struct pci_device_id nvme_id_table[] = {
>  	{ PCI_VDEVICE(INTEL, 0xf1a5),	/* Intel 600P/P3100 */
>  		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
>  				NVME_QUIRK_MEDIUM_PRIO_SQ |
> -				NVME_QUIRK_NO_TEMP_THRESH_CHANGE },
> +				NVME_QUIRK_NO_TEMP_THRESH_CHANGE |
> +				NVME_QUIRK_DISABLE_WRITE_ZEROES, },

That's one amazingly buggy driver :)  Wasn't it the one with the
corruptions with 512 byte writes as well that got fixed by the firmware
upgrade?

But yes, we'll have to work around it, so:

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2020-09-11  5:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 21:18 [PATCH] nvme-pci: disable write zeros command for Intel 600P/P3100 David Milburn
2020-09-10 22:48 ` Eric Sandeen
2020-09-11  5:32 ` Christoph Hellwig [this message]
2020-09-11 13:21   ` Eric Sandeen
2020-09-15  5:59 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200911053227.GA20950@lst.de \
    --to=hch@lst.de \
    --cc=david.fugate@linux.intel.com \
    --cc=dmilburn@redhat.com \
    --cc=esandeen@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.