From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D4FC433E2 for ; Fri, 11 Sep 2020 07:54:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E113E221E3 for ; Fri, 11 Sep 2020 07:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599810896; bh=eOOJoBImDE1TPm96YQNh+LjDOxBzOMInIn5eSZSA4wI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=v6Kf5aqITEMmmgfkbD26HupsJBozsfWUGo981awKXJZBmVXBbrG14tNlXoDq1liBK AsLUvCDtSV8VAWlGjlSHQbG2RChowJBnPFe2bWgTCOJlMHLpZXPIF+f3gz+TXVNvJ3 EYhvlBWz5JgTDfLTtlU9/hILbGSeZOnSSuDXsr/Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725794AbgIKHyy (ORCPT ); Fri, 11 Sep 2020 03:54:54 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:35958 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgIKHyo (ORCPT ); Fri, 11 Sep 2020 03:54:44 -0400 Received: by mail-ed1-f67.google.com with SMTP id w1so9042503edr.3 for ; Fri, 11 Sep 2020 00:54:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0I/ZdGkuIr3JoP7rRmJ+zxyQ7oEKoTVS9yur/NkoIf0=; b=XCpd6c6wvB21N4iEWrPlinEy2i0ydrccsWkCDTc/Gv90ApogN+Dy9EgPWOS/JklTmJ 2UxGkUkklpHMy2lR498rQfSOvLg4ndLFQi/F4d3EOPPJcVXgzZ+1j4MZgHuhB0FUk1nM blzo5hYACFXGuzGOU3UZO1SvAZ12tclSw+WaqhcSN7T7VtEn6/Pe0Cs5zq3Th2Vu8rC4 YoM744U6xL1Z4ZUei6F6rjcoj+xsSfQcOF7nSDNuCFqVQQhUGri6dfn7s920c3o4NHVp GHsPrgLOo8FQYaHsxqCRyn8E5+ywJ5op9zsHAUnSOf5wKH/nU/ZX/B1L8R9HSwdPX5E3 G9jg== X-Gm-Message-State: AOAM532uGktptvZqvJ/nFG0ebZAtM7qOpnXfAfd7eOsJqvmbAhHxNqoz PLhzWwsDJBsQUiskKgFBlys= X-Google-Smtp-Source: ABdhPJzRtQ0X94H2fDvUJZrcp+Dm9AfI6lguQAi5pLjGbvPo4Kyp8wvCKu96XByy4lPTumbGN5/T0Q== X-Received: by 2002:a50:d4ce:: with SMTP id e14mr776330edj.126.1599810881793; Fri, 11 Sep 2020 00:54:41 -0700 (PDT) Received: from kozik-lap ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id i7sm1031530ejo.22.2020.09.11.00.54.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Sep 2020 00:54:40 -0700 (PDT) Date: Fri, 11 Sep 2020 09:54:39 +0200 From: Krzysztof Kozlowski To: Chanwoo Choi Cc: MyungJoo Ham , Vijai Kumar K , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] extcon: ptn5150: Use defines for registers Message-ID: <20200911075439.GA11145@kozik-lap> References: <20200909150129.12476-1-krzk@kernel.org> <7571e535-f0ff-2371-1669-734c3996aacf@samsung.com> <20200911053805.GA2954@kozik-lap> <6e621023-530a-727c-fff7-e8435ca4a4d2@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6e621023-530a-727c-fff7-e8435ca4a4d2@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2020 at 05:03:02PM +0900, Chanwoo Choi wrote: > On 9/11/20 2:38 PM, Krzysztof Kozlowski wrote: > > On Fri, Sep 11, 2020 at 12:14:19PM +0900, Chanwoo Choi wrote: > >> On 9/10/20 12:01 AM, Krzysztof Kozlowski wrote: > >>> The register addresses are not continuous, so use simple defines for > >>> them. This also makes it easier to find the address for register. > >>> > >>> No functional change. > >>> > >>> Signed-off-by: Krzysztof Kozlowski > >>> --- > >>> drivers/extcon/extcon-ptn5150.c | 22 ++++++++++------------ > >>> 1 file changed, 10 insertions(+), 12 deletions(-) > >>> > >>> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c > >>> index dda5b3a3a908..1b68f56d8372 100644 > >>> --- a/drivers/extcon/extcon-ptn5150.c > >>> +++ b/drivers/extcon/extcon-ptn5150.c > >>> @@ -19,18 +19,16 @@ > >>> #include > >>> > >>> /* PTN5150 registers */ > >>> -enum ptn5150_reg { > >>> - PTN5150_REG_DEVICE_ID = 0x01, > >>> - PTN5150_REG_CONTROL, > >>> - PTN5150_REG_INT_STATUS, > >>> - PTN5150_REG_CC_STATUS, > >>> - PTN5150_REG_CON_DET = 0x09, > >>> - PTN5150_REG_VCONN_STATUS, > >>> - PTN5150_REG_RESET, > >>> - PTN5150_REG_INT_MASK = 0x18, > >>> - PTN5150_REG_INT_REG_STATUS, > >>> - PTN5150_REG_END, > >>> -}; > >>> +#define PTN5150_REG_DEVICE_ID 0x01 > >>> +#define PTN5150_REG_CONTROL 0x02 > >>> +#define PTN5150_REG_INT_STATUS 0x03 > >>> +#define PTN5150_REG_CC_STATUS 0x04 > >>> +#define PTN5150_REG_CON_DET 0x09 > >>> +#define PTN5150_REG_VCONN_STATUS 0x0a > >>> +#define PTN5150_REG_RESET 0x0b > >>> +#define PTN5150_REG_INT_MASK 0x18 > >>> +#define PTN5150_REG_INT_REG_STATUS 0x19 > >>> +#define PTN5150_REG_END PTN5150_REG_INT_REG_STATUS > >> > >> PTN5150_REG_END should be (PTN5150_REG_INT_REG_STATUS + 1) > >> for regmap operation of PTN5150_REG_INT_REG_STATUS. > > > > Why? This goes to regmap's max_register which is the last register > > allowed to read: > > > > drivers/base/regmap/regmap-debugfs.c: for (i = 0; i <= map->max_register; i += map->reg_stride) { > > drivers/base/regmap/regmap.c: if (map->max_register && reg > map->max_register) > > It is my mismake. You're right. > Applied them. Thanks. Great, thank you! Best regards, Krzysztof