From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ns-tools/set_ipv4addr: Use ip command as default
Date: Fri, 11 Sep 2020 10:37:03 +0200 [thread overview]
Message-ID: <20200911083703.GA697@dell5510> (raw)
In-Reply-To: <1599746191-2012-1-git-send-email-chen_han_xiao@126.com>
Hi Chen,
> Set iproute as the default as ifconfig
> has been deprecated on some of the distributions.
> testcases/network/stress/ns-tools/set_ipv4addr | 40 +++++++++++++++++++++-----
Thanks for your patch. While I appreciate you work on LTP networking tests, I'm
against this change for a simple reason: everything which uses ns-tools needs to
be rewritten to use new LTP network shell API (tst_net.sh). Only very simple
fixes for really broken things like 4cf2f2bfd should be accepted.
Thus, please put your effort into rewriting these tests.
FYI Although it's a low priority for me I plan to work on these (I have wip at
least for rmmod). Feel free to join this effort.
See https://github.com/linux-test-project/ltp/issues/310
Kind regards,
Petr
prev parent reply other threads:[~2020-09-11 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 13:56 [LTP] [PATCH] ns-tools/set_ipv4addr: Use ip command as default Chen Hanxiao
2020-09-11 8:37 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911083703.GA697@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.