From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] ls-files: respect 'submodule.recurse' config
Date: Sun, 13 Sep 2020 17:47:03 +0700 [thread overview]
Message-ID: <20200913104703.GA2034@danh.dev> (raw)
In-Reply-To: <45EB4E9E-1819-41D6-839E-A3812456478C@gmail.com>
On 2020-09-11 09:05:42-0400, Philippe Blain <levraiphilippeblain@gmail.com> wrote:
> I understand, but I would argue that such a user could easily adapt their
> script to add '--no-recurse-submodules' to their ls-files invocation if that
> is the case, no ?
There're people still live in the past, for example those poor souls
still live in Ubuntu 16.04 LTS, they don't have the luxury of using
Git with ls-files that understand --recurse-submodules and
--no-recurse-submodules.
> > So, no. I am not enthused to see this change.
>
> OK, if I'm not able to change your mind, what would you think of a separate
> config variable then, say `ls-files.recurseSubmodules` ? This would be more granular,
> so less chance of breaking existing scripts, but still provide for a way to configure
> Git to always recurse in submodules, including for 'ls-files'...
If you're really buy into configuration and using ls-files
interactively, I think it's better to make a Git-alias instead.
alias.ls = ls-files --recurse-submodules
--
Danh
next prev parent reply other threads:[~2020-09-13 10:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 3:07 [PATCH] ls-files: respect 'submodule.recurse' config Philippe Blain via GitGitGadget
2020-09-10 4:25 ` Junio C Hamano
2020-09-10 4:50 ` Junio C Hamano
2020-09-11 13:11 ` Philippe Blain
2020-09-11 14:30 ` Philippe Blain
2020-09-11 13:05 ` Philippe Blain
2020-09-11 19:19 ` Junio C Hamano
2020-09-13 10:47 ` Đoàn Trần Công Danh [this message]
2020-09-13 10:51 ` Đoàn Trần Công Danh
2020-09-11 13:48 ` Philippe Blain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200913104703.GA2034@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.