Re: [PATCH v6 2/3] irqchip: Add Actions Semi Owl SIRQ controller

[Cristian Ciocaltea <cristian.ciocaltea@gmail.com>]

On Mon, Sep 14, 2020 at 09:07:18AM +0100, Marc Zyngier wrote:
> Cristian,
> 
> On 2020-09-14 08:02, Cristian Ciocaltea wrote:
> > Hi Marc,
> > 
> > On Fri, Sep 11, 2020 at 05:22:41PM +0100, Marc Zyngier wrote:
> > > On 2020-09-08 09:20, Cristian Ciocaltea wrote:
> > > > This interrupt controller is found in the Actions Semi Owl SoCs (S500,
> > > > S700 and S900) and provides support for handling up to 3 external
> > > > interrupt lines.
> > > >
> > > > Each line can be independently configured as interrupt and triggers on
> > > > either of the edges or either of the levels. Additionally, each line
> > > > can also be masked individually.
> > > >
> > > > The patch is based on the work started by Parthiban Nallathambi:
> > > > https://lore.kernel.org/lkml/20181126100356.2840578-1-pn@denx.de/
> > > >
> > > > Signed-off-by: Parthiban Nallathambi <pn@denx.de>
> > > > Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> > > > [cristi: optimized DT, various fixes/cleanups/improvements]
> > > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > > 
> > > Who is the author of these patches? If this is a co-development,
> > > please
> > > use the relevant tags. Otherwise, the author of the patch must come as
> > > the first SoB.
> > 
> > I took the authorship for the driver patch, as mentioned in the cover
> > letter. So, if I understand correctly, my SoB should be moved on top and
> > I assume I also need to drop the related comment line.
> 
> Not quite. Please look at Documentation/process/submitting-patches.rst.

Yes, I have read it, but most probably I missed the information that
clarifies this authorship change handling.

> If Parthiban and Saravanan haven't authored anything in this patch,
> then drop them from the SoB list.

Sorry I haven't properly explained this before!

Their contributions to the driver code stopped in 2018, when v3 of the
patch series has been submitted.

> If they have contributed to the
> patch (which I expect), then their SoB must be preceded by their own
> Co-developed-by: tag.

Starting with v4, the work has been done exclusively by myself.

> To sum it up, it probably should look like:
> 
> Co-developed-by: Parthiban Nallathambi <pn@denx.de>
> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
> Co-developed-by: Saravanan Sekar <sravanhome@gmail.com>
> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> 
> This is of course an assumption, and you should check it with the
> individuals above.

I have recently contacted Parthiban and he agreed that I can take the
authorship. So I should proceed with the 1st approach?

> Thanks,
> 
>         M.
> -- 
> Jazz is not dead. It just smells funny...

Thanks,
Cristi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel