All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>,
	Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.19 05/19] regulator: pwm: Fix machine constraints application
Date: Mon, 14 Sep 2020 09:04:48 -0400	[thread overview]
Message-ID: <20200914130502.1804708-5-sashal@kernel.org> (raw)
In-Reply-To: <20200914130502.1804708-1-sashal@kernel.org>

From: Vincent Whitchurch <vincent.whitchurch@axis.com>

[ Upstream commit 59ae97a7a9e1499c2070e29841d1c4be4ae2994a ]

If the zero duty cycle doesn't correspond to any voltage in the voltage
table, the PWM regulator returns an -EINVAL from get_voltage_sel() which
results in the core erroring out with a "failed to get the current
voltage" and ending up not applying the machine constraints.

Instead, return -ENOTRECOVERABLE which makes the core set the voltage
since it's at an unknown value.

For example, with this device tree:

	fooregulator {
		compatible = "pwm-regulator";
		pwms = <&foopwm 0 100000>;
		regulator-min-microvolt = <2250000>;
		regulator-max-microvolt = <2250000>;
		regulator-name = "fooregulator";
		regulator-always-on;
		regulator-boot-on;
		voltage-table = <2250000 30>;
	};

Before this patch:

  fooregulator: failed to get the current voltage(-22)

After this patch:

  fooregulator: Setting 2250000-2250000uV
  fooregulator: 2250 mV

Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Link: https://lore.kernel.org/r/20200902130952.24880-1-vincent.whitchurch@axis.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/regulator/pwm-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index a2fd140eff81a..34f3b9778ffa1 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -285,7 +285,7 @@ static int pwm_regulator_init_table(struct platform_device *pdev,
 		return ret;
 	}
 
-	drvdata->state			= -EINVAL;
+	drvdata->state			= -ENOTRECOVERABLE;
 	drvdata->duty_cycle_table	= duty_cycle_table;
 	memcpy(&drvdata->ops, &pwm_regulator_voltage_table_ops,
 	       sizeof(drvdata->ops));
-- 
2.25.1


  parent reply	other threads:[~2020-09-14 14:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 13:04 [PATCH AUTOSEL 4.19 01/19] NFSv4.1 handle ERR_DELAY error reclaiming locking state on delegation recall Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 02/19] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 03/19] scsi: libfc: Fix for double free() Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 04/19] scsi: lpfc: Fix FLOGI/PLOGI receive race condition in pt2pt discovery Sasha Levin
2020-09-14 13:04 ` Sasha Levin [this message]
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 06/19] spi: spi-loopback-test: Fix out-of-bounds read Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 07/19] NFS: Zero-stateid SETATTR should first return delegation Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 08/19] SUNRPC: stop printk reading past end of string Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 09/19] rapidio: Replace 'select' DMAENGINES 'with depends on' Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 10/19] kobject: Drop unneeded conditional in __kobject_del() Sasha Levin
2020-09-14 13:04 ` [OpenRISC] [PATCH AUTOSEL 4.19 11/19] openrisc: Fix cache API compile issue when not inlining Sasha Levin
2020-09-14 13:04   ` Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 12/19] nvme-fc: cancel async events before freeing event struct Sasha Levin
2020-09-14 13:04   ` Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 13/19] nvme-rdma: " Sasha Levin
2020-09-14 13:04   ` Sasha Levin
2020-09-14 13:04 ` [f2fs-dev] [PATCH AUTOSEL 4.19 14/19] f2fs: fix indefinite loop scanning for free nid Sasha Levin
2020-09-14 13:04   ` Sasha Levin
2020-09-14 13:04 ` [f2fs-dev] [PATCH AUTOSEL 4.19 15/19] f2fs: Return EOF on unaligned end of file DIO read Sasha Levin
2020-09-14 13:04   ` Sasha Levin
2020-09-14 13:04 ` [PATCH AUTOSEL 4.19 16/19] i2c: algo: pca: Reapply i2c bus settings after reset Sasha Levin
2020-09-14 13:05 ` [PATCH AUTOSEL 4.19 17/19] spi: Fix memory leak on splited transfers Sasha Levin
2020-09-14 13:05 ` [PATCH AUTOSEL 4.19 18/19] gcov: add support for GCC 10.1 Sasha Levin
2020-09-14 13:05 ` [PATCH AUTOSEL 4.19 19/19] KVM: MIPS: Change the definition of kvm type Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200914130502.1804708-5-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vincent.whitchurch@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.