From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAB6C43461 for ; Mon, 14 Sep 2020 19:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 516A321BE5 for ; Mon, 14 Sep 2020 19:39:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AquWfEQU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726048AbgINTjJ (ORCPT ); Mon, 14 Sep 2020 15:39:09 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:24974 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725914AbgINTjH (ORCPT ); Mon, 14 Sep 2020 15:39:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600112346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1C8ReAVP9iJ7tu3Zp3XFtgTWDt9VPAWgSvPubq0gHHk=; b=AquWfEQUJYWo06KyJZplE/+kr34J3YghWHr3S/OhYKmyiGnOUUfdb+AqyqLbqwkUDQ8gL6 n+We7XHxfeBXa8OyajCX08ECOvi0gXltlmxw1EbsgJTMqmP+Qa6luQDi9pfbeSv25zsrlG wuIzTDrBgQRpF8mLLx3JvOp/HxtVqB0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-544-MzY3j9SPN1CbCuCVLHWzFQ-1; Mon, 14 Sep 2020 15:39:04 -0400 X-MC-Unique: MzY3j9SPN1CbCuCVLHWzFQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7243E1005E72; Mon, 14 Sep 2020 19:39:02 +0000 (UTC) Received: from krava (unknown [10.40.192.180]) by smtp.corp.redhat.com (Postfix) with SMTP id 9F2E17B7AC; Mon, 14 Sep 2020 19:38:57 +0000 (UTC) Date: Mon, 14 Sep 2020 21:38:56 +0200 From: Jiri Olsa To: Song Liu Cc: Namhyung Kim , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Michael Petlan , Song Liu , "Frank Ch. Eigler" , Ian Rogers , Stephane Eranian , Alexey Budankov , Andi Kleen , Adrian Hunter Subject: Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event Message-ID: <20200914193856.GN1714160@krava> References: <20200913210313.1985612-1-jolsa@kernel.org> <20200913210313.1985612-3-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2020 at 11:20:31PM -0700, Song Liu wrote: > On Sun, Sep 13, 2020 at 10:40 PM Namhyung Kim wrote: > > > > On Mon, Sep 14, 2020 at 6:03 AM Jiri Olsa wrote: > > > > > > Add new version of mmap event. The MMAP3 record is an > > > augmented version of MMAP2, it adds build id value to > > > identify the exact binary object behind memory map: > > > > > > struct { > > > struct perf_event_header header; > > > > > > u32 pid, tid; > > > u64 addr; > > > u64 len; > > > u64 pgoff; > > > u32 maj; > > > u32 min; > > > u64 ino; > > > u64 ino_generation; > > > u32 prot, flags; > > > u32 reserved; > > I guess we need reserved _after_ buildid, no? it's there to align the size to 8 bytes, so the sample_id is in proper place but yes, perhaps after buildid would make more sense > > > > u8 buildid[20]; > > > > Do we need maj, min, ino, ino_generation for mmap3 event? > > I think they are to compare binaries, then we can do it with > > build-id (and I think it'd be better).. > > +1 we shouldn't need maj, min, etc. right, and as peter already wrote buildid could fit in that space.. yay :) thanks, jirka > > Thanks, > Song > > [...] >