All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Conor Davis via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Conor Davis <git@conor.fastmail.fm>
Subject: Re: [PATCH] commit-graph-format.txt: fix no-parent value
Date: Tue, 15 Sep 2020 00:26:07 -0400	[thread overview]
Message-ID: <20200915042607.GA19144@nand.local> (raw)
In-Reply-To: <pull.733.git.1600142634326.gitgitgadget@gmail.com>

Hi Conor,

On Tue, Sep 15, 2020 at 04:03:53AM +0000, Conor Davis via GitGitGadget wrote:
> -      of the ith commit. Stores value 0x7000000 if no parent in that
> +      of the ith commit. Stores value 0x70000000 if no parent in that

Thnaks for fixing this up. This dates back to a9aa3c0927 (commit-graph:
fix documentation inconsistencies, 2018-06-28) which mentions the
correct value in the commit message, but uses the incorrect value in the
patch itself.

For what it's worth, I can hardly blame the author of a9aa3c0927, since
I had to flip back and forth between the two a couple of times to
convince myself which one was which.

Anyway, this is obviously correct. Thank you for your contribution!

  Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks,
Taylor

  reply	other threads:[~2020-09-15  4:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15  4:03 [PATCH] commit-graph-format.txt: fix no-parent value Conor Davis via GitGitGadget
2020-09-15  4:26 ` Taylor Blau [this message]
2020-09-15 12:16   ` Derrick Stolee
2020-09-15 23:12     ` Conor Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915042607.GA19144@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@conor.fastmail.fm \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.