From: Cornelia Huck <cohuck@redhat.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: mst@redhat.com, david@redhat.com,
virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, wei.w.wang@intel.com
Subject: [virtio-comment] Re: [PATCH v8 4/3] content: Minor change to clarify free_page_hint_cmd_id
Date: Tue, 15 Sep 2020 08:56:44 +0200 [thread overview]
Message-ID: <20200915085644.503fd837.cohuck@redhat.com> (raw)
In-Reply-To: <160011251967.38663.1066997200552457824.stgit@ahduyck-workstation>
On Mon, 14 Sep 2020 12:44:09 -0700
Alexander Duyck <alexander.duyck@gmail.com> wrote:
> From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
>
> The original wording was a bit unclear and could have been misinterpreted
> as indicating that VIRTIO_BALLOON_FREE_PAGE_HINT was read-only instead of
> the field free_page_hint_cmd_id. To clarify that break it up into two
> sentences making it clear that the field is only available if the feature
> is negotiated, and that the field is read-only.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> ---
>
> So this patch addresses a minor nit that was pointed out after the ballot
> had already been created. If need be I can either open a new bugzilla and
> request a ballot to have it added.
>
> content.tex | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/content.tex b/content.tex
> index 76dfce919b97..f74090491534 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -5052,8 +5052,8 @@ \subsection{Device configuration layout}\label{sec:Device Types / Memory Balloon
> \field{num_pages} and \field{actual} are always available.
>
> \field{free_page_hint_cmd_id} is available if
> - VIRTIO_BALLOON_F_FREE_PAGE_HINT has been negotiated and is read-only by
> - the driver.
> + VIRTIO_BALLOON_F_FREE_PAGE_HINT has been negotiated. The field is
> + read-only by the driver.
>
> \begin{lstlisting}
> struct virtio_balloon_config {
>
>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2020-09-15 6:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 14:44 [virtio-comment] [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features Alexander Duyck
2020-08-25 14:45 ` [virtio-comment] [PATCH v8 1/3] content: Document balloon feature free page hints Alexander Duyck
2020-09-04 15:19 ` [virtio-comment] Re: [virtio-dev] " Jan Kiszka
2020-09-04 16:56 ` Alexander Duyck
2020-09-11 5:28 ` Jan Kiszka
2020-09-11 15:11 ` Alexander Duyck
2020-09-14 6:13 ` Cornelia Huck
2020-09-14 19:44 ` [virtio-comment] [PATCH v8 4/3] content: Minor change to clarify free_page_hint_cmd_id Alexander Duyck
2020-09-15 6:56 ` Cornelia Huck [this message]
2020-09-16 13:28 ` [virtio-comment] Re: [virtio-dev] [PATCH v8 1/3] content: Document balloon feature free page hints Michael S. Tsirkin
2020-11-11 18:03 ` Cornelia Huck
2020-11-11 22:09 ` Alexander Duyck
2020-11-12 7:45 ` Cornelia Huck
2020-11-12 22:58 ` Alexander Duyck
2020-08-25 14:45 ` [virtio-comment] [PATCH v8 2/3] content: Document balloon feature page poison Alexander Duyck
2020-08-25 14:45 ` [virtio-comment] [PATCH v8 3/3] content: Document balloon feature free page reporting Alexander Duyck
2020-08-25 15:01 ` [virtio-comment] Re: [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features Cornelia Huck
2020-08-25 20:40 ` Alexander Duyck
2020-09-01 14:34 ` Michael S. Tsirkin
2020-09-10 14:50 ` Alexander Duyck
2020-09-10 15:05 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915085644.503fd837.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=david@redhat.com \
--cc=mst@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.