From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [RFT] mmc: tmio: reset device on timeout, too
Date: Tue, 15 Sep 2020 12:05:09 +0200 [thread overview]
Message-ID: <20200915100509.GC2381@ninjato> (raw)
In-Reply-To: <CAPDyKFoPn_x_NDp7pXpf9q8Kvf_fVA+xwJSfm4g-oLubmU9nyQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
> > Ah, now I get it. "upper layers" as in consumers. And because consumers
> > sit on a card, this guarantees that mmc_card is still there. Correct?
>
> Yes.
Good, I'll prepare a patch, hopefully in the next days.
> Maybe something like "mmc_controller_card_reset" could work, but it's
> not going to be that straight forward. In the end, we depend on the
> context for when the host driver would call such a function. In some
> cases it must call mmc_claim_host() while in others it shouldn't.
I see. It seems we should try to handle it locally in the driver then.
> BTW, I see that tmio_mmc_reset() is called at
> tmio_mmc_host_runtime_resume(). This seems to work fine without having
> to make a full reset of the card. Why can't you do something similar
> to that instead?
Good question. I'll investigate that. I am a bit afraid that it neither
works and only RPM never kicked in because of a workaround. But I need
to prove that, maybe it is something else...
Thanks for the help, Ulf!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-09-15 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 8:16 [RFT] mmc: tmio: reset device on timeout, too Wolfram Sang
2020-08-28 12:18 ` Yoshihiro Shimoda
2020-08-28 12:35 ` Ulf Hansson
2020-08-30 13:03 ` Wolfram Sang
2020-09-09 11:24 ` Ulf Hansson
2020-09-09 11:37 ` Wolfram Sang
2020-09-09 12:45 ` Ulf Hansson
2020-09-15 10:05 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915100509.GC2381@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.