From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54DCEC43461 for ; Tue, 15 Sep 2020 09:23:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F00502078D for ; Tue, 15 Sep 2020 09:23:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LmoSMD9K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F00502078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yJlbsGFRyVGYwN1JYUbiQ1ThR3J9CY9+5rq1qP4Coi0=; b=LmoSMD9Ko80JM6MAJIhdtCYHj bx1fnaJ5lUsjgsUTW6BXtqiLyCWVrAhSFlRvLzLGQENMKkgtgpcuuP6wO5NKRq+smgIeLijz/Z2nW rMnvFAAF09jqqghgKnHmdkipC8g+CgLklPFA3thpQBqe1grXeaeaWnnm3idzba0Jx/65D+wnZwbFC F7B9W2YlTQshtfVncFs4HG9fwsPAmHhoiKND47vnTeJtuQ8eMQyhd7QuX6g3pSovTzkW2O23VrlaI H3HHNlUbaTsi21evnS9oz7Jx8OJEYlg+Ke1kIkRIF43JacyL5HopYb3RW4qPsZ5z7tf+m7BjkyPiG xqUXfpFKA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI7BN-0006bZ-8j; Tue, 15 Sep 2020 09:23:25 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI7BI-0006aT-S1; Tue, 15 Sep 2020 09:23:21 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0895B2000C; Tue, 15 Sep 2020 09:23:16 +0000 (UTC) Date: Tue, 15 Sep 2020 11:23:15 +0200 From: Miquel Raynal To: Yifeng Zhao Subject: Re: [PATCH v8 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20200915112315.310d89c8@xps13> In-Reply-To: <20200915100728.5c866f89@xps13> References: <20200717092420.19798-1-yifeng.zhao@rock-chips.com> <20200717092420.19798-3-yifeng.zhao@rock-chips.com> <20200915100728.5c866f89@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_052321_050212_7506DE3D X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, vigneshr@ti.com, richard@nod.at, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, heiko@sntech.de Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Ck1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+IHdyb3RlIG9uIFR1ZSwg MTUgU2VwIDIwMjAKMTA6MDc6MjggKzAyMDA6Cgo+IEhpIFlpZmVuZywKPiAKPiBJIGFtIHZlcnkg c29ycnkgZm9yIHRoZSBkZWxheSBpdCB0b29rIG1lIHRvIHJldmlldyB0aGlzIGRyaXZlciwgYnV0 Cj4gdGhlcmUgYXJlIHN0aWxsIHNvbWUgc21hbGwgaW5jb2hlcmVuY2VzIElNSE8sIHNlZSBiZWxv dy4KCk9uZSBsYXN0IGltcG9ydGFudCBjb21tZW50IGJlbG93Cgo+ID4gK3N0YXRpYyBpbnQgcmtf bmZjX2F0dGFjaF9jaGlwKHN0cnVjdCBuYW5kX2NoaXAgKmNoaXApCj4gPiArewo+ID4gKwlzdHJ1 Y3QgbXRkX2luZm8gKm10ZCA9IG5hbmRfdG9fbXRkKGNoaXApOwo+ID4gKwlzdHJ1Y3QgZGV2aWNl ICpkZXYgPSBtdGQtPmRldi5wYXJlbnQ7Cj4gPiArCXN0cnVjdCBya19uZmMgKm5mYyA9IG5hbmRf Z2V0X2NvbnRyb2xsZXJfZGF0YShjaGlwKTsKPiA+ICsJc3RydWN0IHJrX25mY19uYW5kX2NoaXAg KnJrbmFuZCA9IHRvX3JrbmFuZChjaGlwKTsKPiA+ICsJc3RydWN0IG5hbmRfZWNjX2N0cmwgKmVj YyA9ICZjaGlwLT5lY2M7Cj4gPiArCWludCBsZW47Cj4gPiArCWludCByZXQ7Cj4gPiArCj4gPiAr CWlmIChjaGlwLT5vcHRpb25zICYgTkFORF9CVVNXSURUSF8xNikgewo+ID4gKwkJZGV2X2Vycihk ZXYsICIxNiBiaXRzIGJ1cyB3aWR0aCBub3Qgc3VwcG9ydGVkIik7Cj4gPiArCQlyZXR1cm4gLUVJ TlZBTDsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAoZWNjLT5tb2RlICE9IE5BTkRfRUNDX0hXKQo+ ID4gKwkJcmV0dXJuIDA7Cj4gPiArCj4gPiArCXJldCA9IHJrX25mY19lY2NfaW5pdChkZXYsIG10 ZCk7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwlya25hbmQtPnNwYXJl X3Blcl9zZWN0b3IgPSBlY2MtPmJ5dGVzICsgTkZDX1NZU19EQVRBX1NJWkU7Cj4gPiArCXJrbmFu ZC0+bWV0YWRhdGFfc2l6ZSA9IE5GQ19TWVNfREFUQV9TSVpFICogZWNjLT5zdGVwczsKPiA+ICsK PiA+ICsJaWYgKHJrbmFuZC0+bWV0YWRhdGFfc2l6ZSA8IE5GQ19TWVNfREFUQV9TSVpFICsgMikg ewo+ID4gKwkJZGV2X2VycihkZXYsCj4gPiArCQkJIkRyaXZlciBuZWVkcyBhdCBsZWFzdCAlZCBi eXRlcyBvZiBtZXRhIGRhdGFcbiIsCj4gPiArCQkJTkZDX1NZU19EQVRBX1NJWkUgKyAyKTsKPiA+ ICsJCXJldHVybiAtRUlPOwo+ID4gKwl9Cj4gPiArCS8qIENoZWNrIGJ1ZmZlciBmaXJzdCwgYXZv aWQgZHVwbGljYXRlIGFsbG9jIGJ1ZmZlci4gKi8KPiA+ICsJaWYgKG5mYy0+YnVmZmVyKQo+ID4g KwkJcmV0dXJuIDA7ICAKPiAKPiBZb3UgY2FuJ3QgZG8gdGhhdCB0aGlzIHdheTogd2hhdCBpZiB0 aGUgZmlyc3QgbXRkIHRvIGJlIHJlZ2lzdGVyZWQgdXNlcwo+IGEgc21hbGxlciBwYWdlIHNpemUg dGhhbiB0aGUgc2Vjb25kPwo+IAo+ID4gKwo+ID4gKwlsZW4gPSBtdGQtPndyaXRlc2l6ZSArIG10 ZC0+b29ic2l6ZTsKPiA+ICsJbmZjLT5idWZmZXIgPSBkZXZtX2t6YWxsb2MoZGV2LCBsZW4sIEdG UF9LRVJORUwgfCBHRlBfRE1BKTsKCkkgZG9uJ3QgdGhpbmsgdGhpcyBmaXRzIHlvdXIgcHVycG9z ZS4gWW91IHNob3VsZCBwcm9iYWJseSBhbGxvY2F0ZSB3aXRoCmt6YWxsb2Mgb3IgcGVyaGFwcyBk bWFfYWxsb2MqLgoKVGhlbiwgeW91J2xsIGFsc28gaGF2ZSB0byBmcmVlIHRoaXMgbWVtb3J5LgoK PiA+ICsJaWYgKCFuZmMtPmJ1ZmZlcikKPiA+ICsJCXJldHVybiAtRU5PTUVNOwo+ID4gKwo+ID4g KwluZmMtPnBhZ2VfYnVmID0gbmZjLT5idWZmZXI7Cj4gPiArCWxlbiA9IGVjYy0+c3RlcHMgKiBO RkNfTUFYX09PQl9QRVJfU1RFUDsKPiA+ICsJbmZjLT5vb2JfYnVmID0gZGV2bV9remFsbG9jKGRl diwgbGVuLCBHRlBfS0VSTkVMIHwgR0ZQX0RNQSk7Cj4gPiArCWlmICghbmZjLT5vb2JfYnVmKSB7 Cj4gPiArCQluZmMtPmJ1ZmZlciA9IE5VTEw7Cj4gPiArCQluZmMtPm9vYl9idWYgPSBOVUxMOyAg Cj4gCj4gSSBkb24ndCB0aGluayB0aGlzIGlzIG5lZWRlZAo+IAo+ID4gKwkJcmV0dXJuIC1FTk9N RU07Cj4gPiArCX0KPiA+ICsKPiA+ICsJY2hpcC0+ZWNjLndyaXRlX3BhZ2VfcmF3ID0gcmtfbmZj X3dyaXRlX3BhZ2VfcmF3Owo+ID4gKwljaGlwLT5lY2Mud3JpdGVfcGFnZSA9IHJrX25mY193cml0 ZV9wYWdlX2h3ZWNjOwo+ID4gKwljaGlwLT5lY2Mud3JpdGVfb29iX3JhdyA9IHJrX25mY193cml0 ZV9vb2Jfc3RkOwo+ID4gKwljaGlwLT5lY2Mud3JpdGVfb29iID0gcmtfbmZjX3dyaXRlX29vYl9z dGQ7Cj4gPiArCj4gPiArCWNoaXAtPmVjYy5yZWFkX3BhZ2VfcmF3ID0gcmtfbmZjX3JlYWRfcGFn ZV9yYXc7Cj4gPiArCWNoaXAtPmVjYy5yZWFkX3BhZ2UgPSBya19uZmNfcmVhZF9wYWdlX2h3ZWNj Owo+ID4gKwljaGlwLT5lY2MucmVhZF9vb2JfcmF3ID0gcmtfbmZjX3JlYWRfb29iX3N0ZDsKPiA+ ICsJY2hpcC0+ZWNjLnJlYWRfb29iID0gcmtfbmZjX3JlYWRfb29iX3N0ZDsgIAo+IAo+IEkgZG9u J3QgbGlrZSB0aGUgX3N0ZCBwcmVmaXgsIGJ1dCBpdCBzaG91bGQgYmUgZ29uZSB3aGVuIHNwbGl0 dGluZyB0aGUKPiBmdW5jdGlvbnMgYXMgYWR2aXNlZC4KPiAKPiA+ICsKPiA+ICsJcmV0dXJuIDA7 Cj4gPiArfQoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0 Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E50C433E2 for ; Tue, 15 Sep 2020 09:23:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 354782078D for ; Tue, 15 Sep 2020 09:23:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hsU+QHMa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 354782078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ojU2er9sw/4uU580G5/ooV+t3uRhbqeEmtWwUcasd80=; b=hsU+QHMa2MVMmMR1cqtjU7dlx aLkbmeQC6+sm2ME2WuzhnuFSTB74U/wGJa+EAERlm9FT5wiIIsGxxnxSxXqO4NG80dsJ/rEW/2yya KeHzDBc9A0FaU5T1KaOa47hqVeKH0/KtVesYDgmLP3Z9kcYskj/D4jElsugydaddJEoBIeH1eXOWH Z9Pb7qjqtLaBkd1kg7igTZFnp2P7LmS2b8XnprBFTVHGeoYD+zX7uG25huXmn483DAA2WGFWVGOwN jFyFDMCXenv9W66nxIXVACcVQpb1X6xVLk8fkn5n/ZDqrwv67cf+sDaCztSWB9gIN3fNZsYdaKjni GqXT4PW/w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI7BU-0006dc-Gj; Tue, 15 Sep 2020 09:23:32 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI7BI-0006aT-S1; Tue, 15 Sep 2020 09:23:21 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0895B2000C; Tue, 15 Sep 2020 09:23:16 +0000 (UTC) Date: Tue, 15 Sep 2020 11:23:15 +0200 From: Miquel Raynal To: Yifeng Zhao Subject: Re: [PATCH v8 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20200915112315.310d89c8@xps13> In-Reply-To: <20200915100728.5c866f89@xps13> References: <20200717092420.19798-1-yifeng.zhao@rock-chips.com> <20200717092420.19798-3-yifeng.zhao@rock-chips.com> <20200915100728.5c866f89@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_052321_050212_7506DE3D X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, vigneshr@ti.com, richard@nod.at, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, heiko@sntech.de Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Ck1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+IHdyb3RlIG9uIFR1ZSwg MTUgU2VwIDIwMjAKMTA6MDc6MjggKzAyMDA6Cgo+IEhpIFlpZmVuZywKPiAKPiBJIGFtIHZlcnkg c29ycnkgZm9yIHRoZSBkZWxheSBpdCB0b29rIG1lIHRvIHJldmlldyB0aGlzIGRyaXZlciwgYnV0 Cj4gdGhlcmUgYXJlIHN0aWxsIHNvbWUgc21hbGwgaW5jb2hlcmVuY2VzIElNSE8sIHNlZSBiZWxv dy4KCk9uZSBsYXN0IGltcG9ydGFudCBjb21tZW50IGJlbG93Cgo+ID4gK3N0YXRpYyBpbnQgcmtf bmZjX2F0dGFjaF9jaGlwKHN0cnVjdCBuYW5kX2NoaXAgKmNoaXApCj4gPiArewo+ID4gKwlzdHJ1 Y3QgbXRkX2luZm8gKm10ZCA9IG5hbmRfdG9fbXRkKGNoaXApOwo+ID4gKwlzdHJ1Y3QgZGV2aWNl ICpkZXYgPSBtdGQtPmRldi5wYXJlbnQ7Cj4gPiArCXN0cnVjdCBya19uZmMgKm5mYyA9IG5hbmRf Z2V0X2NvbnRyb2xsZXJfZGF0YShjaGlwKTsKPiA+ICsJc3RydWN0IHJrX25mY19uYW5kX2NoaXAg KnJrbmFuZCA9IHRvX3JrbmFuZChjaGlwKTsKPiA+ICsJc3RydWN0IG5hbmRfZWNjX2N0cmwgKmVj YyA9ICZjaGlwLT5lY2M7Cj4gPiArCWludCBsZW47Cj4gPiArCWludCByZXQ7Cj4gPiArCj4gPiAr CWlmIChjaGlwLT5vcHRpb25zICYgTkFORF9CVVNXSURUSF8xNikgewo+ID4gKwkJZGV2X2Vycihk ZXYsICIxNiBiaXRzIGJ1cyB3aWR0aCBub3Qgc3VwcG9ydGVkIik7Cj4gPiArCQlyZXR1cm4gLUVJ TlZBTDsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAoZWNjLT5tb2RlICE9IE5BTkRfRUNDX0hXKQo+ ID4gKwkJcmV0dXJuIDA7Cj4gPiArCj4gPiArCXJldCA9IHJrX25mY19lY2NfaW5pdChkZXYsIG10 ZCk7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwlya25hbmQtPnNwYXJl X3Blcl9zZWN0b3IgPSBlY2MtPmJ5dGVzICsgTkZDX1NZU19EQVRBX1NJWkU7Cj4gPiArCXJrbmFu ZC0+bWV0YWRhdGFfc2l6ZSA9IE5GQ19TWVNfREFUQV9TSVpFICogZWNjLT5zdGVwczsKPiA+ICsK PiA+ICsJaWYgKHJrbmFuZC0+bWV0YWRhdGFfc2l6ZSA8IE5GQ19TWVNfREFUQV9TSVpFICsgMikg ewo+ID4gKwkJZGV2X2VycihkZXYsCj4gPiArCQkJIkRyaXZlciBuZWVkcyBhdCBsZWFzdCAlZCBi eXRlcyBvZiBtZXRhIGRhdGFcbiIsCj4gPiArCQkJTkZDX1NZU19EQVRBX1NJWkUgKyAyKTsKPiA+ ICsJCXJldHVybiAtRUlPOwo+ID4gKwl9Cj4gPiArCS8qIENoZWNrIGJ1ZmZlciBmaXJzdCwgYXZv aWQgZHVwbGljYXRlIGFsbG9jIGJ1ZmZlci4gKi8KPiA+ICsJaWYgKG5mYy0+YnVmZmVyKQo+ID4g KwkJcmV0dXJuIDA7ICAKPiAKPiBZb3UgY2FuJ3QgZG8gdGhhdCB0aGlzIHdheTogd2hhdCBpZiB0 aGUgZmlyc3QgbXRkIHRvIGJlIHJlZ2lzdGVyZWQgdXNlcwo+IGEgc21hbGxlciBwYWdlIHNpemUg dGhhbiB0aGUgc2Vjb25kPwo+IAo+ID4gKwo+ID4gKwlsZW4gPSBtdGQtPndyaXRlc2l6ZSArIG10 ZC0+b29ic2l6ZTsKPiA+ICsJbmZjLT5idWZmZXIgPSBkZXZtX2t6YWxsb2MoZGV2LCBsZW4sIEdG UF9LRVJORUwgfCBHRlBfRE1BKTsKCkkgZG9uJ3QgdGhpbmsgdGhpcyBmaXRzIHlvdXIgcHVycG9z ZS4gWW91IHNob3VsZCBwcm9iYWJseSBhbGxvY2F0ZSB3aXRoCmt6YWxsb2Mgb3IgcGVyaGFwcyBk bWFfYWxsb2MqLgoKVGhlbiwgeW91J2xsIGFsc28gaGF2ZSB0byBmcmVlIHRoaXMgbWVtb3J5LgoK PiA+ICsJaWYgKCFuZmMtPmJ1ZmZlcikKPiA+ICsJCXJldHVybiAtRU5PTUVNOwo+ID4gKwo+ID4g KwluZmMtPnBhZ2VfYnVmID0gbmZjLT5idWZmZXI7Cj4gPiArCWxlbiA9IGVjYy0+c3RlcHMgKiBO RkNfTUFYX09PQl9QRVJfU1RFUDsKPiA+ICsJbmZjLT5vb2JfYnVmID0gZGV2bV9remFsbG9jKGRl diwgbGVuLCBHRlBfS0VSTkVMIHwgR0ZQX0RNQSk7Cj4gPiArCWlmICghbmZjLT5vb2JfYnVmKSB7 Cj4gPiArCQluZmMtPmJ1ZmZlciA9IE5VTEw7Cj4gPiArCQluZmMtPm9vYl9idWYgPSBOVUxMOyAg Cj4gCj4gSSBkb24ndCB0aGluayB0aGlzIGlzIG5lZWRlZAo+IAo+ID4gKwkJcmV0dXJuIC1FTk9N RU07Cj4gPiArCX0KPiA+ICsKPiA+ICsJY2hpcC0+ZWNjLndyaXRlX3BhZ2VfcmF3ID0gcmtfbmZj X3dyaXRlX3BhZ2VfcmF3Owo+ID4gKwljaGlwLT5lY2Mud3JpdGVfcGFnZSA9IHJrX25mY193cml0 ZV9wYWdlX2h3ZWNjOwo+ID4gKwljaGlwLT5lY2Mud3JpdGVfb29iX3JhdyA9IHJrX25mY193cml0 ZV9vb2Jfc3RkOwo+ID4gKwljaGlwLT5lY2Mud3JpdGVfb29iID0gcmtfbmZjX3dyaXRlX29vYl9z dGQ7Cj4gPiArCj4gPiArCWNoaXAtPmVjYy5yZWFkX3BhZ2VfcmF3ID0gcmtfbmZjX3JlYWRfcGFn ZV9yYXc7Cj4gPiArCWNoaXAtPmVjYy5yZWFkX3BhZ2UgPSBya19uZmNfcmVhZF9wYWdlX2h3ZWNj Owo+ID4gKwljaGlwLT5lY2MucmVhZF9vb2JfcmF3ID0gcmtfbmZjX3JlYWRfb29iX3N0ZDsKPiA+ ICsJY2hpcC0+ZWNjLnJlYWRfb29iID0gcmtfbmZjX3JlYWRfb29iX3N0ZDsgIAo+IAo+IEkgZG9u J3QgbGlrZSB0aGUgX3N0ZCBwcmVmaXgsIGJ1dCBpdCBzaG91bGQgYmUgZ29uZSB3aGVuIHNwbGl0 dGluZyB0aGUKPiBmdW5jdGlvbnMgYXMgYWR2aXNlZC4KPiAKPiA+ICsKPiA+ICsJcmV0dXJuIDA7 Cj4gPiArfQoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2No aXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5FEC433E2 for ; Tue, 15 Sep 2020 09:25:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7399206A1 for ; Tue, 15 Sep 2020 09:25:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wz/1LuFH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7399206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Pzu8PjpzoYx3npjTaogu1Pjoj4RcABslY38qBIsHHtc=; b=Wz/1LuFHQ+pV/XyXeOI9D460T +0GAfq+68LS2lpaehiSigPFYzCp25vrQck5kkzm++/rNIhKFdq8QMpIWdlsBcQCV8aSl/aPIlHEhh 0gcuVDC2XuJ6ie4N5SIaJ899JwSt+OAhKFY8uE8YNjuPfE0xiB6zZ+yaNCZF7DSlxta1aIemqJurs GSiG4ZNTWxetrL+VjG67ZT7+x5qCiAztKQUoNO7kU/xVGn4nZKB8vcyyfKDyJZ+gT1U/+86gBoElh aipOcc0b1sEi7+rsN3P04keiUWbu1Ik/new5D2C7rBLr6N177F8milH0vXe05gXUkoyZwXv0deS98 K+1wOMcBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI7BL-0006b8-2i; Tue, 15 Sep 2020 09:23:23 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI7BI-0006aT-S1; Tue, 15 Sep 2020 09:23:21 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0895B2000C; Tue, 15 Sep 2020 09:23:16 +0000 (UTC) Date: Tue, 15 Sep 2020 11:23:15 +0200 From: Miquel Raynal To: Yifeng Zhao Subject: Re: [PATCH v8 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20200915112315.310d89c8@xps13> In-Reply-To: <20200915100728.5c866f89@xps13> References: <20200717092420.19798-1-yifeng.zhao@rock-chips.com> <20200717092420.19798-3-yifeng.zhao@rock-chips.com> <20200915100728.5c866f89@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_052321_050212_7506DE3D X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, vigneshr@ti.com, richard@nod.at, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, heiko@sntech.de Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+IHdyb3RlIG9uIFR1ZSwg MTUgU2VwIDIwMjAKMTA6MDc6MjggKzAyMDA6Cgo+IEhpIFlpZmVuZywKPiAKPiBJIGFtIHZlcnkg c29ycnkgZm9yIHRoZSBkZWxheSBpdCB0b29rIG1lIHRvIHJldmlldyB0aGlzIGRyaXZlciwgYnV0 Cj4gdGhlcmUgYXJlIHN0aWxsIHNvbWUgc21hbGwgaW5jb2hlcmVuY2VzIElNSE8sIHNlZSBiZWxv dy4KCk9uZSBsYXN0IGltcG9ydGFudCBjb21tZW50IGJlbG93Cgo+ID4gK3N0YXRpYyBpbnQgcmtf bmZjX2F0dGFjaF9jaGlwKHN0cnVjdCBuYW5kX2NoaXAgKmNoaXApCj4gPiArewo+ID4gKwlzdHJ1 Y3QgbXRkX2luZm8gKm10ZCA9IG5hbmRfdG9fbXRkKGNoaXApOwo+ID4gKwlzdHJ1Y3QgZGV2aWNl ICpkZXYgPSBtdGQtPmRldi5wYXJlbnQ7Cj4gPiArCXN0cnVjdCBya19uZmMgKm5mYyA9IG5hbmRf Z2V0X2NvbnRyb2xsZXJfZGF0YShjaGlwKTsKPiA+ICsJc3RydWN0IHJrX25mY19uYW5kX2NoaXAg KnJrbmFuZCA9IHRvX3JrbmFuZChjaGlwKTsKPiA+ICsJc3RydWN0IG5hbmRfZWNjX2N0cmwgKmVj YyA9ICZjaGlwLT5lY2M7Cj4gPiArCWludCBsZW47Cj4gPiArCWludCByZXQ7Cj4gPiArCj4gPiAr CWlmIChjaGlwLT5vcHRpb25zICYgTkFORF9CVVNXSURUSF8xNikgewo+ID4gKwkJZGV2X2Vycihk ZXYsICIxNiBiaXRzIGJ1cyB3aWR0aCBub3Qgc3VwcG9ydGVkIik7Cj4gPiArCQlyZXR1cm4gLUVJ TlZBTDsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAoZWNjLT5tb2RlICE9IE5BTkRfRUNDX0hXKQo+ ID4gKwkJcmV0dXJuIDA7Cj4gPiArCj4gPiArCXJldCA9IHJrX25mY19lY2NfaW5pdChkZXYsIG10 ZCk7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwlya25hbmQtPnNwYXJl X3Blcl9zZWN0b3IgPSBlY2MtPmJ5dGVzICsgTkZDX1NZU19EQVRBX1NJWkU7Cj4gPiArCXJrbmFu ZC0+bWV0YWRhdGFfc2l6ZSA9IE5GQ19TWVNfREFUQV9TSVpFICogZWNjLT5zdGVwczsKPiA+ICsK PiA+ICsJaWYgKHJrbmFuZC0+bWV0YWRhdGFfc2l6ZSA8IE5GQ19TWVNfREFUQV9TSVpFICsgMikg ewo+ID4gKwkJZGV2X2VycihkZXYsCj4gPiArCQkJIkRyaXZlciBuZWVkcyBhdCBsZWFzdCAlZCBi eXRlcyBvZiBtZXRhIGRhdGFcbiIsCj4gPiArCQkJTkZDX1NZU19EQVRBX1NJWkUgKyAyKTsKPiA+ ICsJCXJldHVybiAtRUlPOwo+ID4gKwl9Cj4gPiArCS8qIENoZWNrIGJ1ZmZlciBmaXJzdCwgYXZv aWQgZHVwbGljYXRlIGFsbG9jIGJ1ZmZlci4gKi8KPiA+ICsJaWYgKG5mYy0+YnVmZmVyKQo+ID4g KwkJcmV0dXJuIDA7ICAKPiAKPiBZb3UgY2FuJ3QgZG8gdGhhdCB0aGlzIHdheTogd2hhdCBpZiB0 aGUgZmlyc3QgbXRkIHRvIGJlIHJlZ2lzdGVyZWQgdXNlcwo+IGEgc21hbGxlciBwYWdlIHNpemUg dGhhbiB0aGUgc2Vjb25kPwo+IAo+ID4gKwo+ID4gKwlsZW4gPSBtdGQtPndyaXRlc2l6ZSArIG10 ZC0+b29ic2l6ZTsKPiA+ICsJbmZjLT5idWZmZXIgPSBkZXZtX2t6YWxsb2MoZGV2LCBsZW4sIEdG UF9LRVJORUwgfCBHRlBfRE1BKTsKCkkgZG9uJ3QgdGhpbmsgdGhpcyBmaXRzIHlvdXIgcHVycG9z ZS4gWW91IHNob3VsZCBwcm9iYWJseSBhbGxvY2F0ZSB3aXRoCmt6YWxsb2Mgb3IgcGVyaGFwcyBk bWFfYWxsb2MqLgoKVGhlbiwgeW91J2xsIGFsc28gaGF2ZSB0byBmcmVlIHRoaXMgbWVtb3J5LgoK PiA+ICsJaWYgKCFuZmMtPmJ1ZmZlcikKPiA+ICsJCXJldHVybiAtRU5PTUVNOwo+ID4gKwo+ID4g KwluZmMtPnBhZ2VfYnVmID0gbmZjLT5idWZmZXI7Cj4gPiArCWxlbiA9IGVjYy0+c3RlcHMgKiBO RkNfTUFYX09PQl9QRVJfU1RFUDsKPiA+ICsJbmZjLT5vb2JfYnVmID0gZGV2bV9remFsbG9jKGRl diwgbGVuLCBHRlBfS0VSTkVMIHwgR0ZQX0RNQSk7Cj4gPiArCWlmICghbmZjLT5vb2JfYnVmKSB7 Cj4gPiArCQluZmMtPmJ1ZmZlciA9IE5VTEw7Cj4gPiArCQluZmMtPm9vYl9idWYgPSBOVUxMOyAg Cj4gCj4gSSBkb24ndCB0aGluayB0aGlzIGlzIG5lZWRlZAo+IAo+ID4gKwkJcmV0dXJuIC1FTk9N RU07Cj4gPiArCX0KPiA+ICsKPiA+ICsJY2hpcC0+ZWNjLndyaXRlX3BhZ2VfcmF3ID0gcmtfbmZj X3dyaXRlX3BhZ2VfcmF3Owo+ID4gKwljaGlwLT5lY2Mud3JpdGVfcGFnZSA9IHJrX25mY193cml0 ZV9wYWdlX2h3ZWNjOwo+ID4gKwljaGlwLT5lY2Mud3JpdGVfb29iX3JhdyA9IHJrX25mY193cml0 ZV9vb2Jfc3RkOwo+ID4gKwljaGlwLT5lY2Mud3JpdGVfb29iID0gcmtfbmZjX3dyaXRlX29vYl9z dGQ7Cj4gPiArCj4gPiArCWNoaXAtPmVjYy5yZWFkX3BhZ2VfcmF3ID0gcmtfbmZjX3JlYWRfcGFn ZV9yYXc7Cj4gPiArCWNoaXAtPmVjYy5yZWFkX3BhZ2UgPSBya19uZmNfcmVhZF9wYWdlX2h3ZWNj Owo+ID4gKwljaGlwLT5lY2MucmVhZF9vb2JfcmF3ID0gcmtfbmZjX3JlYWRfb29iX3N0ZDsKPiA+ ICsJY2hpcC0+ZWNjLnJlYWRfb29iID0gcmtfbmZjX3JlYWRfb29iX3N0ZDsgIAo+IAo+IEkgZG9u J3QgbGlrZSB0aGUgX3N0ZCBwcmVmaXgsIGJ1dCBpdCBzaG91bGQgYmUgZ29uZSB3aGVuIHNwbGl0 dGluZyB0aGUKPiBmdW5jdGlvbnMgYXMgYWR2aXNlZC4KPiAKPiA+ICsKPiA+ICsJcmV0dXJuIDA7 Cj4gPiArfQoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9922C43461 for ; Tue, 15 Sep 2020 09:23:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AB082078D for ; Tue, 15 Sep 2020 09:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726185AbgIOJXV convert rfc822-to-8bit (ORCPT ); Tue, 15 Sep 2020 05:23:21 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:51595 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbgIOJXV (ORCPT ); Tue, 15 Sep 2020 05:23:21 -0400 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0895B2000C; Tue, 15 Sep 2020 09:23:16 +0000 (UTC) Date: Tue, 15 Sep 2020 11:23:15 +0200 From: Miquel Raynal To: Yifeng Zhao Cc: richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Message-ID: <20200915112315.310d89c8@xps13> In-Reply-To: <20200915100728.5c866f89@xps13> References: <20200717092420.19798-1-yifeng.zhao@rock-chips.com> <20200717092420.19798-3-yifeng.zhao@rock-chips.com> <20200915100728.5c866f89@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Miquel Raynal wrote on Tue, 15 Sep 2020 10:07:28 +0200: > Hi Yifeng, > > I am very sorry for the delay it took me to review this driver, but > there are still some small incoherences IMHO, see below. One last important comment below > > +static int rk_nfc_attach_chip(struct nand_chip *chip) > > +{ > > + struct mtd_info *mtd = nand_to_mtd(chip); > > + struct device *dev = mtd->dev.parent; > > + struct rk_nfc *nfc = nand_get_controller_data(chip); > > + struct rk_nfc_nand_chip *rknand = to_rknand(chip); > > + struct nand_ecc_ctrl *ecc = &chip->ecc; > > + int len; > > + int ret; > > + > > + if (chip->options & NAND_BUSWIDTH_16) { > > + dev_err(dev, "16 bits bus width not supported"); > > + return -EINVAL; > > + } > > + > > + if (ecc->mode != NAND_ECC_HW) > > + return 0; > > + > > + ret = rk_nfc_ecc_init(dev, mtd); > > + if (ret) > > + return ret; > > + rknand->spare_per_sector = ecc->bytes + NFC_SYS_DATA_SIZE; > > + rknand->metadata_size = NFC_SYS_DATA_SIZE * ecc->steps; > > + > > + if (rknand->metadata_size < NFC_SYS_DATA_SIZE + 2) { > > + dev_err(dev, > > + "Driver needs at least %d bytes of meta data\n", > > + NFC_SYS_DATA_SIZE + 2); > > + return -EIO; > > + } > > + /* Check buffer first, avoid duplicate alloc buffer. */ > > + if (nfc->buffer) > > + return 0; > > You can't do that this way: what if the first mtd to be registered uses > a smaller page size than the second? > > > + > > + len = mtd->writesize + mtd->oobsize; > > + nfc->buffer = devm_kzalloc(dev, len, GFP_KERNEL | GFP_DMA); I don't think this fits your purpose. You should probably allocate with kzalloc or perhaps dma_alloc*. Then, you'll also have to free this memory. > > + if (!nfc->buffer) > > + return -ENOMEM; > > + > > + nfc->page_buf = nfc->buffer; > > + len = ecc->steps * NFC_MAX_OOB_PER_STEP; > > + nfc->oob_buf = devm_kzalloc(dev, len, GFP_KERNEL | GFP_DMA); > > + if (!nfc->oob_buf) { > > + nfc->buffer = NULL; > > + nfc->oob_buf = NULL; > > I don't think this is needed > > > + return -ENOMEM; > > + } > > + > > + chip->ecc.write_page_raw = rk_nfc_write_page_raw; > > + chip->ecc.write_page = rk_nfc_write_page_hwecc; > > + chip->ecc.write_oob_raw = rk_nfc_write_oob_std; > > + chip->ecc.write_oob = rk_nfc_write_oob_std; > > + > > + chip->ecc.read_page_raw = rk_nfc_read_page_raw; > > + chip->ecc.read_page = rk_nfc_read_page_hwecc; > > + chip->ecc.read_oob_raw = rk_nfc_read_oob_std; > > + chip->ecc.read_oob = rk_nfc_read_oob_std; > > I don't like the _std prefix, but it should be gone when splitting the > functions as advised. > > > + > > + return 0; > > +} Thanks, Miquèl