From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com,
mkubecek@suse.cz, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: dp83869: Add ability to advertise Fiber connection
Date: Tue, 15 Sep 2020 22:17:18 +0200 [thread overview]
Message-ID: <20200915201718.GD3526428@lunn.ch> (raw)
In-Reply-To: <20200915181708.25842-3-dmurphy@ti.com>
> + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT,
> + phydev->supported);
> + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Half_BIT,
> + phydev->supported);
> +
> + /* Auto neg is not supported in 100base FX mode */
Hi Dan
If it does not support auto neg, how do you decide to do half duplex?
I don't see any code here which allows the user to configure it.
Andrew
next prev parent reply other threads:[~2020-09-15 20:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 18:17 [PATCH net-next 0/3] 100base Fx link modes Dan Murphy
2020-09-15 18:17 ` [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries Dan Murphy
2020-09-15 20:10 ` Andrew Lunn
2020-09-15 23:26 ` Dan Murphy
2020-09-15 20:21 ` Andrew Lunn
2020-09-15 23:29 ` Dan Murphy
2020-09-17 15:03 ` Dan Murphy
2020-09-15 18:17 ` [PATCH net-next 2/3] net: dp83869: Add ability to advertise Fiber connection Dan Murphy
2020-09-15 20:17 ` Andrew Lunn [this message]
2020-09-16 20:54 ` Dan Murphy
2020-09-16 22:13 ` Andrew Lunn
2020-09-17 14:57 ` Dan Murphy
2020-09-15 18:17 ` [PATCH net-next 3/3] net: phy: dp83822: Update the fiber advertisement for speed Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915201718.GD3526428@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.