From: Eric Biggers <ebiggers@kernel.org>
To: linux-fsdevel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Daeho Jeong <daeho43@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] vfs: don't unnecessarily clone write access for writable fds
Date: Tue, 15 Sep 2020 20:59:14 -0700 [thread overview]
Message-ID: <20200916035914.GA825@sol.localdomain> (raw)
In-Reply-To: <20200629165014.GA20492@sol.localdomain>
On Mon, Jun 29, 2020 at 09:50:14AM -0700, Eric Biggers wrote:
> On Thu, Jun 11, 2020 at 09:05:34AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > There's no need for mnt_want_write_file() to increment mnt_writers when
> > the file is already open for writing, provided that
> > mnt_drop_write_file() is changed to conditionally decrement it.
> >
> > We seem to have ended up in the current situation because
> > mnt_want_write_file() used to be paired with mnt_drop_write(), due to
> > mnt_drop_write_file() not having been added yet. So originally
> > mnt_want_write_file() had to always increment mnt_writers.
> >
> > But later mnt_drop_write_file() was added, and all callers of
> > mnt_want_write_file() were paired with it. This makes the compatibility
> > between mnt_want_write_file() and mnt_drop_write() no longer necessary.
> >
> > Therefore, make __mnt_want_write_file() and __mnt_drop_write_file() skip
> > incrementing mnt_writers on files already open for writing. This
> > removes the only caller of mnt_clone_write(), so remove that too.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Al, any thoughts on this patch?
>
Ping?
next prev parent reply other threads:[~2020-09-16 3:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 16:05 [PATCH v2] vfs: don't unnecessarily clone write access for writable fds Eric Biggers
2020-06-29 16:50 ` Eric Biggers
2020-09-16 3:59 ` Eric Biggers [this message]
2020-09-17 0:54 ` Al Viro
2020-09-22 16:41 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916035914.GA825@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=daeho43@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.