From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/firmware/qcom_scm.c:181:12: warning: Redundant condition: cpus. '!cpus || (cpus && cpumask_empty(cpus))' is equivalent to '!cpus || cpumask_empty(cpus)'
Date: Wed, 16 Sep 2020 06:58:37 +0800 [thread overview]
Message-ID: <202009160633.L0lkkCbC%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4517 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Elliot Berman <eberman@codeaurora.org>
CC: Bjorn Andersson <bjorn.andersson@linaro.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fc4f28bb3daf3265d6bc5f73b497306985bb23ab
commit: 57d3b816718c1cf832e2929a754da3564c6127cc firmware: qcom_scm: Remove thin wrappers
date: 8 months ago
:::::: branch date: 24 hours ago
:::::: commit date: 8 months ago
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck warnings: (new ones prefixed by >>)
>> drivers/firmware/qcom_scm.c:181:12: warning: Redundant condition: cpus. '!cpus || (cpus && cpumask_empty(cpus))' is equivalent to '!cpus || cpumask_empty(cpus)' [redundantCondition]
if (!cpus || (cpus && cpumask_empty(cpus)))
^
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=57d3b816718c1cf832e2929a754da3564c6127cc
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 57d3b816718c1cf832e2929a754da3564c6127cc
vim +181 drivers/firmware/qcom_scm.c
2ce76a6ad32fa0 Lina Iyer 2015-03-02 155
2ce76a6ad32fa0 Lina Iyer 2015-03-02 156 /**
65f0c90b7d4685 Elliot Berman 2020-01-07 157 * qcom_scm_set_cold_boot_addr() - Set the cold boot address for cpus
2ce76a6ad32fa0 Lina Iyer 2015-03-02 158 * @entry: Entry point function for the cpus
2ce76a6ad32fa0 Lina Iyer 2015-03-02 159 * @cpus: The cpumask of cpus that will use the entry point
2ce76a6ad32fa0 Lina Iyer 2015-03-02 160 *
65f0c90b7d4685 Elliot Berman 2020-01-07 161 * Set the cold boot address of the cpus. Any cpu outside the supported
65f0c90b7d4685 Elliot Berman 2020-01-07 162 * range would be removed from the cpu present mask.
2ce76a6ad32fa0 Lina Iyer 2015-03-02 163 */
65f0c90b7d4685 Elliot Berman 2020-01-07 164 int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
2ce76a6ad32fa0 Lina Iyer 2015-03-02 165 {
57d3b816718c1c Elliot Berman 2020-01-07 166 int flags = 0;
57d3b816718c1c Elliot Berman 2020-01-07 167 int cpu;
57d3b816718c1c Elliot Berman 2020-01-07 168 int scm_cb_flags[] = {
57d3b816718c1c Elliot Berman 2020-01-07 169 QCOM_SCM_FLAG_COLDBOOT_CPU0,
57d3b816718c1c Elliot Berman 2020-01-07 170 QCOM_SCM_FLAG_COLDBOOT_CPU1,
57d3b816718c1c Elliot Berman 2020-01-07 171 QCOM_SCM_FLAG_COLDBOOT_CPU2,
57d3b816718c1c Elliot Berman 2020-01-07 172 QCOM_SCM_FLAG_COLDBOOT_CPU3,
57d3b816718c1c Elliot Berman 2020-01-07 173 };
57d3b816718c1c Elliot Berman 2020-01-07 174 struct qcom_scm_desc desc = {
57d3b816718c1c Elliot Berman 2020-01-07 175 .svc = QCOM_SCM_SVC_BOOT,
57d3b816718c1c Elliot Berman 2020-01-07 176 .cmd = QCOM_SCM_BOOT_SET_ADDR,
57d3b816718c1c Elliot Berman 2020-01-07 177 .arginfo = QCOM_SCM_ARGS(2),
57d3b816718c1c Elliot Berman 2020-01-07 178 .owner = ARM_SMCCC_OWNER_SIP,
57d3b816718c1c Elliot Berman 2020-01-07 179 };
57d3b816718c1c Elliot Berman 2020-01-07 180
57d3b816718c1c Elliot Berman 2020-01-07 @181 if (!cpus || (cpus && cpumask_empty(cpus)))
57d3b816718c1c Elliot Berman 2020-01-07 182 return -EINVAL;
57d3b816718c1c Elliot Berman 2020-01-07 183
57d3b816718c1c Elliot Berman 2020-01-07 184 for_each_cpu(cpu, cpus) {
57d3b816718c1c Elliot Berman 2020-01-07 185 if (cpu < ARRAY_SIZE(scm_cb_flags))
57d3b816718c1c Elliot Berman 2020-01-07 186 flags |= scm_cb_flags[cpu];
57d3b816718c1c Elliot Berman 2020-01-07 187 else
57d3b816718c1c Elliot Berman 2020-01-07 188 set_cpu_present(cpu, false);
57d3b816718c1c Elliot Berman 2020-01-07 189 }
57d3b816718c1c Elliot Berman 2020-01-07 190
57d3b816718c1c Elliot Berman 2020-01-07 191 desc.args[0] = flags;
57d3b816718c1c Elliot Berman 2020-01-07 192 desc.args[1] = virt_to_phys(entry);
57d3b816718c1c Elliot Berman 2020-01-07 193
57d3b816718c1c Elliot Berman 2020-01-07 194 return qcom_scm_call_atomic(__scm ? __scm->dev : NULL, &desc, NULL);
2ce76a6ad32fa0 Lina Iyer 2015-03-02 195 }
65f0c90b7d4685 Elliot Berman 2020-01-07 196 EXPORT_SYMBOL(qcom_scm_set_cold_boot_addr);
767b0235dd4765 Lina Iyer 2015-03-02 197
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2020-09-15 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 22:58 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-10 7:11 drivers/firmware/qcom_scm.c:181:12: warning: Redundant condition: cpus. '!cpus || (cpus && cpumask_empty(cpus))' is equivalent to '!cpus || cpumask_empty(cpus)' kernel test robot
2020-12-10 8:37 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009160633.L0lkkCbC%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.