From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25E5DC433E2 for ; Wed, 16 Sep 2020 08:00:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 977DB2078D for ; Wed, 16 Sep 2020 08:00:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="BgAIs1lY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 977DB2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D53061660; Wed, 16 Sep 2020 09:59:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D53061660 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1600243216; bh=VB+iul707xQHJB3MPFHg18/n/MFhXSGhTa9PlCiNdNg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BgAIs1lYwGfuliDhHPL9Ga0tWRN6eYx+of3sf6no+6R1YgskjV0p158T5n5/xpUNt Bh/HXsjpS41JblJai9T7SqHNlEaRhv9ZRkxPolDdZ76D3yq6i8oo1HD+ubJ/D0yqgV ulY+YaiXmO3ew9S1W90qxUgmJysA+Y8uyqesPPq8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 41730F80150; Wed, 16 Sep 2020 09:59:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2DE4EF8015A; Wed, 16 Sep 2020 09:59:23 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CDA67F800E8 for ; Wed, 16 Sep 2020 09:59:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CDA67F800E8 Received: by mail-wm1-f66.google.com with SMTP id k18so1910001wmj.5 for ; Wed, 16 Sep 2020 00:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f9vR3Ti7HGJjlVupS35gCwKRPU2ouBmpdxOZm0a6pHg=; b=F8By3H+ntmi1GHBeHc2c+wCUNXyi0yLeBEh6o1gxC0CtOlsnHyYiyw5wqlG4j71hrD dUcr2yOW65/QvAR2mLgnCBoR0RpN35obSbBLpCyNvGac16IbRYHYXiDSG9cW6rqc/hA5 vqipUyP8KyiYYUYIN19+vfAJLtjsKgFpoCROpK0QmKEoBxrLUTpeG7TEPmCvwnkIZ2LD Ey6DrHi43sWyfsGQqpHjtoeoCYdVahQqUgBzs+MMlnvu0k1dwxSwxXSBWhbvrn7E081L u3HVVle5o2N2ZisxC91bi/MCxfRq1aTj+2gtwPcK8LX5De0J7h0mweUGeWLlIn8P9eNk 5RPA== X-Gm-Message-State: AOAM532o3PT2yfnK8OZtKJoo31zvLS82tlSZT1fYWzMFWg3iTw/5fKGV 4PYTXARLJJWV5fqDAvA/haU= X-Google-Smtp-Source: ABdhPJxvAiLHTzMl+wXAqNoAvB4Yv/BV83AUKMAclJ4hQWRQUQ98jocoP+WC+dpkBraRRwrLGVhbrg== X-Received: by 2002:a1c:7c1a:: with SMTP id x26mr3467656wmc.112.1600243151114; Wed, 16 Sep 2020 00:59:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.124]) by smtp.googlemail.com with ESMTPSA id a81sm4022587wmf.32.2020.09.16.00.59.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Sep 2020 00:59:09 -0700 (PDT) Date: Wed, 16 Sep 2020 09:59:07 +0200 From: Krzysztof Kozlowski To: Andrzej Hajda Subject: Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Message-ID: <20200916075907.GA10270@kozik-lap> References: <20200829142501.31478-1-krzk@kernel.org> <20200829142501.31478-9-krzk@kernel.org> <4eb7d0d9-29e2-9162-4521-10e4422f9c71@samsung.com> <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Chanwoo Choi , David Airlie , Mark Brown , Daniel Lezcano , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Sangbeom Kim , Bartlomiej Zolnierkiewicz , Kukjin Kim , dri-devel@lists.freedesktop.org, Daniel Vetter , Thomas Gleixner , Sylwester Nawrocki , Lee Jones , linux-arm-kernel@lists.infradead.org, Marek Szyprowski X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Sep 02, 2020 at 01:23:50PM +0200, Andrzej Hajda wrote: > > On 31.08.2020 14:50, Marek Szyprowski wrote: > > Hi Krzysztof, > > > > On 29.08.2020 16:25, Krzysztof Kozlowski wrote: > >> The USB-C connector bindings require port@0. Such port was already > >> described in DTS but outside of the connector itself. Put it into > >> proper place to fix dtbs_check warnings like: > >> > >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property > >> > >> Signed-off-by: Krzysztof Kozlowski > > I'm not sure if topic should be about USB-C, I will call it simply USB > > connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector, > > which has nothing in common with USB Type-C. > > > > Anyway, this patch breaks DWC3 (tested in Device mode) driver operation, > > so something has to be somehow adjusted or fixed. Added CC Andrzej > > Hajda, who actually worked on this. > > > >> --- > >> > >> Not tested on HQ. Please kindly review and test. > >> > >> Best regards, > >> Krzysztof > >> --- > >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++-------- > >> 1 file changed, 7 insertions(+), 8 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> index 6246cce2a15e..bab6c1addd5f 100644 > >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> @@ -871,6 +871,13 @@ > >> #address-cells = <1>; > >> #size-cells = <0>; > >> > >> + port@0 { > >> + reg = <0>; > >> + muic_to_usb: endpoint { > >> + remote-endpoint = <&usb_to_muic>; > >> + }; > >> + }; > >> + > > > According to not-yet-yaml documentation of dt-bindings (patch 05/10): > > -Required nodes: > > -- any data bus to the connector should be modeled using the OF graph bindings > > - specified in bindings/graph.txt, unless the bus is between parent node and > > - the connector. > > This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary. > > > >> port@3 { > >> reg = <3>; > >> musb_con_to_mhl: endpoint { > >> @@ -879,14 +886,6 @@ > >> }; > >> }; > >> }; > >> - > >> - ports { > >> - port { > >> - muic_to_usb: endpoint { > >> - remote-endpoint = <&usb_to_muic>; > >> - }; > >> - }; > > > And this port belongs to MUIC - it describes connection between USB-HOST > and MUIC, it has nothing to do with the connector, and is necessary. Thanks for checking this. It's really appreciated! I'll work on v2 later to address the schema warning, hopefully without breaking things... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4CC7C433E2 for ; Wed, 16 Sep 2020 07:59:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AC9C2080C for ; Wed, 16 Sep 2020 07:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600243155; bh=VB+iul707xQHJB3MPFHg18/n/MFhXSGhTa9PlCiNdNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HeIFJ8rmNDeq8pBMxaUGr7xQ2o0nBYKnFYKEhsPZqp4Ikc+SnnhiVxOUqjwzGqI2R 5ddxDnGfiDhJD56RCpAcnSVleuF2Wl6PEuoqi5OvZKk+K0sJKwpm/PKlG0JnDaJjzm b2FdBnyprjCRIn/WcfDh8EZCqmOIfxN9tQvcDT8k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbgIPH7P (ORCPT ); Wed, 16 Sep 2020 03:59:15 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:33514 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbgIPH7N (ORCPT ); Wed, 16 Sep 2020 03:59:13 -0400 Received: by mail-wm1-f68.google.com with SMTP id e11so1643363wme.0; Wed, 16 Sep 2020 00:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f9vR3Ti7HGJjlVupS35gCwKRPU2ouBmpdxOZm0a6pHg=; b=BmuQBVVSUC2pe7DhJ4tbxn9qCGs3gOOhWAmdEuzUuHsjCRvEBEq6Q9jwU/k25KWu5Z mSRa2w8K5yQ3LQ0ackCIfxI0TzdKrzTqvfGBhl7luuEAnvaF7Jr/YtOTr/7L+m043xku aPgV/0A13JtZ3RsznqMLNoGNCGTSblJJl22ePdGFx4rDd3ySJSr+X7moEfvvVmvREZye Wg7w3ry9w1XNBKWX2SrIZnFW7T8FpHILeOqfoFPUqFYJywOQMAemgqY2JDNFLwqz/iO2 jqRdGun0DIuA4F215lMgAPw9P+pzB2EYBoDT1sl/czYOZ5UWWtzJKMov9CWBFs/+EyLT bdcQ== X-Gm-Message-State: AOAM532E4cHjIWXC/Y4UdPy8EdJMdmjvf022S1rXiVMkRNONKJYiCkrW UoGzBk8pquPlKmn2mwR5TC4= X-Google-Smtp-Source: ABdhPJxvAiLHTzMl+wXAqNoAvB4Yv/BV83AUKMAclJ4hQWRQUQ98jocoP+WC+dpkBraRRwrLGVhbrg== X-Received: by 2002:a1c:7c1a:: with SMTP id x26mr3467656wmc.112.1600243151114; Wed, 16 Sep 2020 00:59:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.124]) by smtp.googlemail.com with ESMTPSA id a81sm4022587wmf.32.2020.09.16.00.59.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Sep 2020 00:59:09 -0700 (PDT) Date: Wed, 16 Sep 2020 09:59:07 +0200 From: Krzysztof Kozlowski To: Andrzej Hajda Cc: Marek Szyprowski , Kukjin Kim , Rob Herring , David Airlie , Daniel Vetter , Lee Jones , Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Daniel Lezcano , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org, Sylwester Nawrocki , Chanwoo Choi , Bartlomiej Zolnierkiewicz Subject: Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Message-ID: <20200916075907.GA10270@kozik-lap> References: <20200829142501.31478-1-krzk@kernel.org> <20200829142501.31478-9-krzk@kernel.org> <4eb7d0d9-29e2-9162-4521-10e4422f9c71@samsung.com> <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Sep 02, 2020 at 01:23:50PM +0200, Andrzej Hajda wrote: > > On 31.08.2020 14:50, Marek Szyprowski wrote: > > Hi Krzysztof, > > > > On 29.08.2020 16:25, Krzysztof Kozlowski wrote: > >> The USB-C connector bindings require port@0. Such port was already > >> described in DTS but outside of the connector itself. Put it into > >> proper place to fix dtbs_check warnings like: > >> > >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property > >> > >> Signed-off-by: Krzysztof Kozlowski > > I'm not sure if topic should be about USB-C, I will call it simply USB > > connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector, > > which has nothing in common with USB Type-C. > > > > Anyway, this patch breaks DWC3 (tested in Device mode) driver operation, > > so something has to be somehow adjusted or fixed. Added CC Andrzej > > Hajda, who actually worked on this. > > > >> --- > >> > >> Not tested on HQ. Please kindly review and test. > >> > >> Best regards, > >> Krzysztof > >> --- > >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++-------- > >> 1 file changed, 7 insertions(+), 8 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> index 6246cce2a15e..bab6c1addd5f 100644 > >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> @@ -871,6 +871,13 @@ > >> #address-cells = <1>; > >> #size-cells = <0>; > >> > >> + port@0 { > >> + reg = <0>; > >> + muic_to_usb: endpoint { > >> + remote-endpoint = <&usb_to_muic>; > >> + }; > >> + }; > >> + > > > According to not-yet-yaml documentation of dt-bindings (patch 05/10): > > -Required nodes: > > -- any data bus to the connector should be modeled using the OF graph bindings > > - specified in bindings/graph.txt, unless the bus is between parent node and > > - the connector. > > This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary. > > > >> port@3 { > >> reg = <3>; > >> musb_con_to_mhl: endpoint { > >> @@ -879,14 +886,6 @@ > >> }; > >> }; > >> }; > >> - > >> - ports { > >> - port { > >> - muic_to_usb: endpoint { > >> - remote-endpoint = <&usb_to_muic>; > >> - }; > >> - }; > > > And this port belongs to MUIC - it describes connection between USB-HOST > and MUIC, it has nothing to do with the connector, and is necessary. Thanks for checking this. It's really appreciated! I'll work on v2 later to address the schema warning, hopefully without breaking things... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE494C433E2 for ; Wed, 16 Sep 2020 08:00:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66BAD206B6 for ; Wed, 16 Sep 2020 08:00:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mZFlFEHo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66BAD206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NWGqP4iKqwQxGrL9FUw2QUI030CQW32oiSu9ICYcTpE=; b=mZFlFEHoq5nJEp4cITn9OWfl+ Mfw2P8w4Iw7AbeYVAC4gxcgTdMAudlWeoVoJ6yxWffAcB9c5WxtedZEajm0JsDS8cUeArgoEdBr6x k4hBJ9ABtyMpOmAftL3nAzycvR4LgBchUt5Ugf2hHSb8U1ewIoC7GDCwxQrr+xAI6GfRwQDRQ6MhY iA5KEtBOaZfPJaS0BFMeJwjKKWFK+ExfStEL2gyipVtFVBJwaakXW41a2g4gnaNPhrn3LFOcx0NAD R/DUHV8r5eEhw5XUqWAEb2jEddF5ifv9BldvG1zT0u25cuheldQ05UvA6Zv4bZ3nzIqMcBXxdHMDr ipBiRzmCw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kISLU-00044m-6N; Wed, 16 Sep 2020 07:59:16 +0000 Received: from mail-wm1-f66.google.com ([209.85.128.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kISLQ-00043q-OW for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 07:59:14 +0000 Received: by mail-wm1-f66.google.com with SMTP id l15so1640877wmh.1 for ; Wed, 16 Sep 2020 00:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f9vR3Ti7HGJjlVupS35gCwKRPU2ouBmpdxOZm0a6pHg=; b=CGxQDShwatuASyR56GzYndl8hdSI0N9f2I26u1dzliCr5j+Pio5b7J6j0mlWj9DoWW 5jAiDqxRMQqPBuGckm7uATCxgMU9QA8a9oeRHXElvwQHoc+jOAPJW5DTvOCLK8jxQij3 X0AIM3g/p2L94MrPGokXsOTeiKqGom5WhCwGkIlk9Jc3r7B4OCZ72db/mjbbcxNqByZC tpht7kHvUZ2XfvynWAh5ZXf5kO6uMQySK2mAVH1ltntmI9ImstUUnf7Q5oQ/idVBCEdm ktuKKFcPkEwYCI764aDKwqnyNYrjjZEqJTu1OVA5T9JDuzF2/bnEoH5mNLjNMcn/R9nD YHCA== X-Gm-Message-State: AOAM532t6w7T32QRaGC34kRDb0HUcIeTnC+N8SEh1TugrEgsst1PQThd s2VJJAxfFhDoTb50Ypyz1fs= X-Google-Smtp-Source: ABdhPJxvAiLHTzMl+wXAqNoAvB4Yv/BV83AUKMAclJ4hQWRQUQ98jocoP+WC+dpkBraRRwrLGVhbrg== X-Received: by 2002:a1c:7c1a:: with SMTP id x26mr3467656wmc.112.1600243151114; Wed, 16 Sep 2020 00:59:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.124]) by smtp.googlemail.com with ESMTPSA id a81sm4022587wmf.32.2020.09.16.00.59.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Sep 2020 00:59:09 -0700 (PDT) Date: Wed, 16 Sep 2020 09:59:07 +0200 From: Krzysztof Kozlowski To: Andrzej Hajda Subject: Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Message-ID: <20200916075907.GA10270@kozik-lap> References: <20200829142501.31478-1-krzk@kernel.org> <20200829142501.31478-9-krzk@kernel.org> <4eb7d0d9-29e2-9162-4521-10e4422f9c71@samsung.com> <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_035913_083353_0E774E7D X-CRM114-Status: GOOD ( 27.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , Chanwoo Choi , David Airlie , Mark Brown , Daniel Lezcano , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Sangbeom Kim , Bartlomiej Zolnierkiewicz , Kukjin Kim , dri-devel@lists.freedesktop.org, Daniel Vetter , Thomas Gleixner , Sylwester Nawrocki , Lee Jones , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 02, 2020 at 01:23:50PM +0200, Andrzej Hajda wrote: > > On 31.08.2020 14:50, Marek Szyprowski wrote: > > Hi Krzysztof, > > > > On 29.08.2020 16:25, Krzysztof Kozlowski wrote: > >> The USB-C connector bindings require port@0. Such port was already > >> described in DTS but outside of the connector itself. Put it into > >> proper place to fix dtbs_check warnings like: > >> > >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property > >> > >> Signed-off-by: Krzysztof Kozlowski > > I'm not sure if topic should be about USB-C, I will call it simply USB > > connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector, > > which has nothing in common with USB Type-C. > > > > Anyway, this patch breaks DWC3 (tested in Device mode) driver operation, > > so something has to be somehow adjusted or fixed. Added CC Andrzej > > Hajda, who actually worked on this. > > > >> --- > >> > >> Not tested on HQ. Please kindly review and test. > >> > >> Best regards, > >> Krzysztof > >> --- > >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++-------- > >> 1 file changed, 7 insertions(+), 8 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> index 6246cce2a15e..bab6c1addd5f 100644 > >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> @@ -871,6 +871,13 @@ > >> #address-cells = <1>; > >> #size-cells = <0>; > >> > >> + port@0 { > >> + reg = <0>; > >> + muic_to_usb: endpoint { > >> + remote-endpoint = <&usb_to_muic>; > >> + }; > >> + }; > >> + > > > According to not-yet-yaml documentation of dt-bindings (patch 05/10): > > -Required nodes: > > -- any data bus to the connector should be modeled using the OF graph bindings > > - specified in bindings/graph.txt, unless the bus is between parent node and > > - the connector. > > This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary. > > > >> port@3 { > >> reg = <3>; > >> musb_con_to_mhl: endpoint { > >> @@ -879,14 +886,6 @@ > >> }; > >> }; > >> }; > >> - > >> - ports { > >> - port { > >> - muic_to_usb: endpoint { > >> - remote-endpoint = <&usb_to_muic>; > >> - }; > >> - }; > > > And this port belongs to MUIC - it describes connection between USB-HOST > and MUIC, it has nothing to do with the connector, and is necessary. Thanks for checking this. It's really appreciated! I'll work on v2 later to address the schema warning, hopefully without breaking things... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0146C43461 for ; Wed, 16 Sep 2020 07:59:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C3832078D for ; Wed, 16 Sep 2020 07:59:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C3832078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 014D16E9D5; Wed, 16 Sep 2020 07:59:13 +0000 (UTC) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8319E6E9D5 for ; Wed, 16 Sep 2020 07:59:12 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id w2so1811762wmi.1 for ; Wed, 16 Sep 2020 00:59:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f9vR3Ti7HGJjlVupS35gCwKRPU2ouBmpdxOZm0a6pHg=; b=JwLxRV0V+C8Fu+GDwqLtJjWRK90N0LOZUeeW04E96sqhTLeT7EzLKLvClFGHJ9H/P1 gy/G8u8F/0McjqX9mIX8lRWvFdAYmdoilWBdVTggsrcsBSeCgc2eklkXrOXFl37jZ9fM xYMtXiUfE8xFQd0dJ75mvAuUfhhlRW2uo05fQwS3cUGZoEiQL6Mvjyde4VX9cMz6a+gW UPAuTpjmF5S0jbIZjgFlRNt0+sRfEPnbY7S6C5DoKUB12Ue3XkNyXWz9PgaoxzzD/Fkd MAXH1z0l+TkCNSLw7z7LSjhvQ5cMfKX9fv1bv8WJ9xe/qJVByhNwR8kmwzkxvnusCc9K e2Ag== X-Gm-Message-State: AOAM531z59NCtkf02SmhC4vP7jiBHUh86bch5o2i7TDCDEkeXf3faHBg bj52cVbrdEIZEyOlmRU3G58= X-Google-Smtp-Source: ABdhPJxvAiLHTzMl+wXAqNoAvB4Yv/BV83AUKMAclJ4hQWRQUQ98jocoP+WC+dpkBraRRwrLGVhbrg== X-Received: by 2002:a1c:7c1a:: with SMTP id x26mr3467656wmc.112.1600243151114; Wed, 16 Sep 2020 00:59:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.124]) by smtp.googlemail.com with ESMTPSA id a81sm4022587wmf.32.2020.09.16.00.59.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Sep 2020 00:59:09 -0700 (PDT) Date: Wed, 16 Sep 2020 09:59:07 +0200 From: Krzysztof Kozlowski To: Andrzej Hajda Subject: Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Message-ID: <20200916075907.GA10270@kozik-lap> References: <20200829142501.31478-1-krzk@kernel.org> <20200829142501.31478-9-krzk@kernel.org> <4eb7d0d9-29e2-9162-4521-10e4422f9c71@samsung.com> <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , Chanwoo Choi , David Airlie , Mark Brown , Daniel Lezcano , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Sangbeom Kim , Bartlomiej Zolnierkiewicz , Kukjin Kim , dri-devel@lists.freedesktop.org, Thomas Gleixner , Sylwester Nawrocki , Lee Jones , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 02, 2020 at 01:23:50PM +0200, Andrzej Hajda wrote: > > On 31.08.2020 14:50, Marek Szyprowski wrote: > > Hi Krzysztof, > > > > On 29.08.2020 16:25, Krzysztof Kozlowski wrote: > >> The USB-C connector bindings require port@0. Such port was already > >> described in DTS but outside of the connector itself. Put it into > >> proper place to fix dtbs_check warnings like: > >> > >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property > >> > >> Signed-off-by: Krzysztof Kozlowski > > I'm not sure if topic should be about USB-C, I will call it simply USB > > connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector, > > which has nothing in common with USB Type-C. > > > > Anyway, this patch breaks DWC3 (tested in Device mode) driver operation, > > so something has to be somehow adjusted or fixed. Added CC Andrzej > > Hajda, who actually worked on this. > > > >> --- > >> > >> Not tested on HQ. Please kindly review and test. > >> > >> Best regards, > >> Krzysztof > >> --- > >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++-------- > >> 1 file changed, 7 insertions(+), 8 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> index 6246cce2a15e..bab6c1addd5f 100644 > >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> @@ -871,6 +871,13 @@ > >> #address-cells = <1>; > >> #size-cells = <0>; > >> > >> + port@0 { > >> + reg = <0>; > >> + muic_to_usb: endpoint { > >> + remote-endpoint = <&usb_to_muic>; > >> + }; > >> + }; > >> + > > > According to not-yet-yaml documentation of dt-bindings (patch 05/10): > > -Required nodes: > > -- any data bus to the connector should be modeled using the OF graph bindings > > - specified in bindings/graph.txt, unless the bus is between parent node and > > - the connector. > > This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary. > > > >> port@3 { > >> reg = <3>; > >> musb_con_to_mhl: endpoint { > >> @@ -879,14 +886,6 @@ > >> }; > >> }; > >> }; > >> - > >> - ports { > >> - port { > >> - muic_to_usb: endpoint { > >> - remote-endpoint = <&usb_to_muic>; > >> - }; > >> - }; > > > And this port belongs to MUIC - it describes connection between USB-HOST > and MUIC, it has nothing to do with the connector, and is necessary. Thanks for checking this. It's really appreciated! I'll work on v2 later to address the schema warning, hopefully without breaking things... Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel