All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: zangchunxin@bytedance.com
Cc: akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node
Date: Wed, 16 Sep 2020 12:24:52 +0100	[thread overview]
Message-ID: <20200916112452.GA85476@chrisdown.name> (raw)
In-Reply-To: <20200916025359.70203-1-zangchunxin@bytedance.com>

zangchunxin@bytedance.com writes:
>From: Chunxin Zang <zangchunxin@bytedance.com>
>
>On our server, there are about 10k memcg in one machine. They use memory
>very frequently. We have observed that drop_caches can take a
>considerable amount of time, and can't stop it.
>
>There are two reasons:
>1. There is somebody constantly generating more objects to reclaim
>  on drop_caches, result the 'freed' always bigger than 10.
>2. The process has no chance to process signals.
>
>We can get the following info through 'ps':
>
> root:~# ps -aux | grep drop
> root  357956 ... R    Aug25 21119854:55 echo 3 > /proc/sys/vm/drop_caches
> root 1771385 ... R    Aug16 21146421:17 echo 3 > /proc/sys/vm/drop_caches
>
>Add a bail out on the fatal signals in the main loop so that the
>operation can be terminated by userspace.
>
>Signed-off-by: Chunxin Zang <zangchunxin@bytedance.com>
>Signed-off-by: Muchun Song <songmuchun@bytedance.com>

Acked-by: Chris Down <chris@chrisdown.name>


  parent reply	other threads:[~2020-09-16 11:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16  2:53 [PATCH v5] mm/vmscan: add a fatal signals check in drop_slab_node zangchunxin
2020-09-16  6:08 ` Michal Hocko
2020-09-16 11:24 ` Chris Down [this message]
2020-09-16 13:17 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916112452.GA85476@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=songmuchun@bytedance.com \
    --cc=vbabka@suse.cz \
    --cc=zangchunxin@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.