From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "吳昊澄 Ricky" <ricky_wu@realtek.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"rui_feng@realsil.com.cn" <rui_feng@realsil.com.cn>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"puranjay12@gmail.com" <puranjay12@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"vailbhavgupta40@gmail.com" <vailbhavgupta40@gmail.com>
Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter
Date: Wed, 16 Sep 2020 16:28:16 +0200 [thread overview]
Message-ID: <20200916142816.GA2979962@kroah.com> (raw)
In-Reply-To: <20200916133226.GA1535437@bjorn-Precision-5520>
On Wed, Sep 16, 2020 at 08:32:26AM -0500, Bjorn Helgaas wrote:
> > So is it ok to take this patch now, or does it need to be changed any?
>
> Yes, it's OK with me if you take this patch.
>
> The ASPM hardware feature is designed to work without any driver
> support. It does need to be configured, which involves both the
> device and the upstream bridge, so it should be done by the BIOS or
> the PCI core. There are a few drivers (amdgpu, radeon, hfi1, e1000e,
> iwlegacy, ath10k, ath9k, mt76, rtlwifi, rtw88, and these rts
> cardreader drivers) that do it themselves, incorrectly.
>
> But this particular patch only *reads* the ASPM control registers,
> without writing them, so it shouldn't make anything worse.
Ok, thanks for the review, now queued up.
greg k-h
prev parent reply other threads:[~2020-09-16 19:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 10:07 [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter ricky_wu
2020-09-08 22:28 ` Bjorn Helgaas
2020-09-09 7:10 ` 吳昊澄 Ricky
2020-09-09 17:44 ` Bjorn Helgaas
2020-09-11 8:18 ` 吳昊澄 Ricky
2020-09-11 14:56 ` Bjorn Helgaas
2020-09-15 8:24 ` 吳昊澄 Ricky
2020-09-15 15:28 ` Bjorn Helgaas
2020-09-16 12:30 ` gregkh
2020-09-16 13:32 ` Bjorn Helgaas
2020-09-16 14:28 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916142816.GA2979962@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=ricky_wu@realtek.com \
--cc=rui_feng@realsil.com.cn \
--cc=ulf.hansson@linaro.org \
--cc=vailbhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.