From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Scally <djrscally@gmail.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
gregkh@linuxfoundation.org, rafael@kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
heikki.krogerus@linux.intel.com, kieran.bingham@ideasonboard.com,
jorhand@linux.microsoft.com, kitakar@gmail.com
Subject: Re: [PATCH v2] software_node: Add support for fwnode_graph*() family of functions
Date: Wed, 16 Sep 2020 17:32:41 +0300 [thread overview]
Message-ID: <20200916143241.GL3956970@smile.fi.intel.com> (raw)
In-Reply-To: <7b81d743-736d-62d1-7072-d08759a0d5d7@gmail.com>
On Wed, Sep 16, 2020 at 02:22:10PM +0100, Dan Scally wrote:
> On 16/09/2020 10:17, Sakari Ailus wrote:
> > On Wed, Sep 16, 2020 at 12:28:27AM +0100, Daniel Scally wrote:
...
> >> @@ -450,7 +455,7 @@ software_node_get_next_child(const struct fwnode_handle *fwnode,
> >> c = list_next_entry(c, entry);
> >> else
> >> c = list_first_entry(&p->children, struct swnode, entry);
> >> - return &c->fwnode;
> >> + return software_node_get(&c->fwnode);
> > This looks like a bugfix that probably should or could be backported. Could
> > you make it a separate patch, with a Fixes: tag?
> Yes, sure. That does change how some of the other code would need to
> work though if this patch were applied but not the separated one. Sorry;
> not sure what's the best way to proceed in that case. Should I just note
> that this patch depends on the prior application of the separated one?
It's easy to achieve. You may create a series of two, where the second one
dependant on the first one and first one has a Fixes tag and subject to
backport. I guess that's what Sakari meant.
> >> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-16 20:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 23:28 [PATCH v2] software_node: Add support for fwnode_graph*() family of functions Daniel Scally
2020-09-16 9:17 ` Sakari Ailus
2020-09-16 13:22 ` Dan Scally
2020-09-16 14:32 ` Andy Shevchenko [this message]
2020-09-16 15:06 ` Kieran Bingham
2020-09-16 16:10 ` Andy Shevchenko
2020-09-18 6:22 ` Sakari Ailus
2020-09-18 6:49 ` Dan Scally
2020-09-18 7:34 ` Sakari Ailus
2020-09-18 7:46 ` Dan Scally
2020-09-18 7:57 ` Sakari Ailus
[not found] ` <20200918085709.GA1630537@kuha.fi.intel.com>
2020-09-18 9:10 ` Dan Scally
2020-09-18 9:15 ` Sakari Ailus
2020-09-18 9:22 ` Dan Scally
2020-09-18 12:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916143241.GL3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jorhand@linux.microsoft.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=kitakar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.