From: Cornelia Huck <cohuck@redhat.com>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alex.williamson@redhat.com>, <wanghaibin.wang@huawei.com>
Subject: Re: [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver
Date: Thu, 17 Sep 2020 13:26:34 +0200 [thread overview]
Message-ID: <20200917132634.4df6ff60.cohuck@redhat.com> (raw)
In-Reply-To: <20200917033128.872-1-yuzenghui@huawei.com>
On Thu, 17 Sep 2020 11:31:27 +0800
Zenghui Yu <yuzenghui@huawei.com> wrote:
> It was added by commit 137e5531351d ("vfio/pci: Add sriov_configure
> support") and actually unnecessary. Remove it.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/vfio/pci/vfio_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index 1ab1f5cda4ac..da68e2f86622 100644
> --- a/drivers/vfio/pci/vfio_pci.c
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -1862,7 +1862,6 @@ static const struct vfio_device_ops vfio_pci_ops = {
>
> static int vfio_pci_reflck_attach(struct vfio_pci_device *vdev);
> static void vfio_pci_reflck_put(struct vfio_pci_reflck *reflck);
> -static struct pci_driver vfio_pci_driver;
>
> static int vfio_pci_bus_notifier(struct notifier_block *nb,
> unsigned long action, void *data)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-09-17 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 3:31 [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver Zenghui Yu
2020-09-17 3:31 ` [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device Zenghui Yu
2020-09-17 11:35 ` Cornelia Huck
2020-09-17 22:07 ` Alex Williamson
2020-09-19 1:54 ` Zenghui Yu
2020-09-19 2:11 ` Alex Williamson
2020-09-19 2:39 ` Zenghui Yu
2020-09-17 11:26 ` Cornelia Huck [this message]
2020-09-17 22:22 ` [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver Alex Williamson
2020-09-19 1:56 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917132634.4df6ff60.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.