From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C5F8C43465 for ; Thu, 17 Sep 2020 22:17:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE113208DB for ; Thu, 17 Sep 2020 22:17:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="j5oYloPv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE113208DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4F836E0CF; Thu, 17 Sep 2020 22:17:07 +0000 (UTC) Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E6186EC36 for ; Thu, 17 Sep 2020 14:35:53 +0000 (UTC) Received: by mail-qk1-x744.google.com with SMTP id o16so2379667qkj.10 for ; Thu, 17 Sep 2020 07:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4FMmUqw3Ogf5DWfrcaBYE+88tcXzyk3qcn9Gd5hl3YQ=; b=j5oYloPvYL7s4CPTt81wv4olgyoI/6IlhT6aI8lDvNqHADWP/JsUZ4WNwSAnarJJVd Jdd7y5LK3H4qrJDXIzo4GzxtRtRdSn74TO+sPmBQ+A3UTKrWoV2qqwIgla/t6cN1mEzh YgB03e2F1hYq89gJy2In7h5LX8mfdp/lJ8vauS8eQJrPZEuv9vFNxus3W1QS8aEEh2jU aNgxQzkQEHZvN34u0lGhLEgUFKJXoYCaI/tF+nC0CovO/q9P121VcOoAOdmqbPSwPlwQ 9k8ecPtmJZWZCMPSONUM47C13l3uQbZ64/zvk+EFKCwijs/wPUYHVUJBOSzB9UTR274e bIsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4FMmUqw3Ogf5DWfrcaBYE+88tcXzyk3qcn9Gd5hl3YQ=; b=sxeaBPmDwAi2rEItxoYXgTtvcgHa1pR2R9Enr3QYe23J2/ClAai2/Iup1TRY9QFUMm zjPFu2EtG/caJjlYFALDUoRDIhu2pWaBWo+Y7pRGg3I4sLHdhgg4K37Ex4pXf5p2L11z I1qsiIj+7/obx69puXMrVaGZLRrHf7pG+5KFcZvVQkc5J4uZuA2N4TvigLZNkBSId3mx vYr1l3/ElLan2o4klFMYWNfiGxYxignL+XL4KngMm72vIV5Bv6s5YszrP2rBrAD3NB6I TtF1n3wCgG2IDtDXXLXbPvPFkyNb/+LIGoKQ+dJVpmuvdK1w3h1p5l51q6X0s4B99STs K+/Q== X-Gm-Message-State: AOAM531B7WgXtSIhojQtwzSt2kzGH/do/oVoC8eqWyTwDasEogd4Fo0z yX3ntkYMhz/noGA7oQtmIj8sTg== X-Google-Smtp-Source: ABdhPJzS5DvFjFRz09F8HD5ZwD/CTVt6TV63hE1mZt++JvtsXfCWDtAegDUHikgXHQCiEAeg2s8xdA== X-Received: by 2002:a05:620a:15ac:: with SMTP id f12mr27633534qkk.19.1600353352699; Thu, 17 Sep 2020 07:35:52 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id m36sm20906770qtd.10.2020.09.17.07.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 07:35:52 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kIv0p-000VC1-Ed; Thu, 17 Sep 2020 11:35:51 -0300 Date: Thu, 17 Sep 2020 11:35:51 -0300 From: Jason Gunthorpe To: christian.koenig@amd.com Subject: Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap() Message-ID: <20200917143551.GG8409@ziepe.ca> References: <8db2474f-ecb7-0e17-5f5b-145708fe44d5@amd.com> <8d8693db-a3f0-4f5f-3e32-57d23ca620f8@amd.com> <20200917113110.GE8409@ziepe.ca> <6fd74b84-959c-8b3b-c27b-e9fbf66396c7@gmail.com> <20200917121858.GF8409@ziepe.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Thu, 17 Sep 2020 22:17:03 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Mailing List , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Linux MM , Andrew Morton , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCBTZXAgMTcsIDIwMjAgYXQgMDI6MjQ6MjlQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbSAxNy4wOS4yMCB1bSAxNDoxOCBzY2hyaWViIEphc29uIEd1bnRob3JwZToK PiA+IE9uIFRodSwgU2VwIDE3LCAyMDIwIGF0IDAyOjAzOjQ4UE0gKzAyMDAsIENocmlzdGlhbiBL w7ZuaWcgd3JvdGU6Cj4gPiA+IEFtIDE3LjA5LjIwIHVtIDEzOjMxIHNjaHJpZWIgSmFzb24gR3Vu dGhvcnBlOgo+ID4gPiA+IE9uIFRodSwgU2VwIDE3LCAyMDIwIGF0IDEwOjA5OjEyQU0gKzAyMDAs IERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiA+ID4gCj4gPiA+ID4gPiBZZWFoLCBidXQgaXQgZG9l c24ndCB3b3JrIHdoZW4gZm9yd2FyZGluZyBmcm9tIHRoZSBkcm0gY2hhcmRldiB0byB0aGUKPiA+ ID4gPiA+IGRtYS1idWYgb24gdGhlIGltcG9ydGVyIHNpZGUsIHNpbmNlIHlvdSdkIG5lZWQgYSB0 b24gb2YgZGlmZmVyZW50Cj4gPiA+ID4gPiBhZGRyZXNzIHNwYWNlcy4gQW5kIHlvdSBzdGlsbCBy ZWx5IG9uIHRoZSBjb3JlIGNvZGUgcGlja2luZyB1cCB5b3VyCj4gPiA+ID4gPiBwZ29mZiBtYW5n bGluZywgd2hpY2ggZmVlbHMgYWJvdXQgYXMgcmlza3kgdG8gbWUgYXMgdGhlIHZtYSBmaWxlCj4g PiA+ID4gPiBwb2ludGVyIHdyYW5nbGluZyAtIGlmIGl0J3Mgbm90IGNvbnNpc3RlbnRseSBhcHBs aWVkIHRoZSByZXZlcnNlIG1hcAo+ID4gPiA+ID4gaXMgdG9hc3QgYW5kIHVubWFwX21hcHBpbmdf cmFuZ2UgZG9lc24ndCB3b3JrIGNvcnJlY3RseSBmb3Igb3VyIG5lZWRzLgo+ID4gPiA+IEkgd291 bGQgdGhpbmsgdGhlIHBnb2ZmIGhhcyB0byBiZSB0cmFuc2xhdGVkIGF0IHRoZSBzYW1lIHRpbWUg dGhlCj4gPiA+ID4gdm0tPnZtX2ZpbGUgaXMgY2hhbmdlZD8KPiA+ID4gPiAKPiA+ID4gPiBUaGUg b3duZXIgb2YgdGhlIGRtYV9idWYgc2hvdWxkIGhhdmUgb25lIHZpcnR1YWwgYWRkcmVzcyBzcGFj ZSBhbmQgRkQsCj4gPiA+ID4gYWxsIGl0cyBkbWEgYnVmcyBzaG91bGQgYmUgbGlua2VkIHRvIGl0 LCBhbmQgYWxsIHBnb2ZmcyB0cmFuc2xhdGVkIHRvCj4gPiA+ID4gdGhhdCBzcGFjZS4KPiA+ID4g WWVhaCwgdGhhdCBpcyBleGFjdGx5IGxpa2UgYW1kZ3B1IGlzIGRvaW5nIGl0Lgo+ID4gPiAKPiA+ ID4gR29pbmcgdG8gZG9jdW1lbnQgdGhhdCBzb21laG93IHdoZW4gSSdtIGRvbmUgd2l0aCBUVE0g Y2xlYW51cHMuCj4gPiBCVFcsIHdoaWxlIHBlb3BsZSBhcmUgbG9va2luZyBhdCB0aGlzLCBpcyB0 aGVyZSBhIHdheSB0byBnbyBmcm9tIGEgVk1BCj4gPiB0byBhIGRtYV9idWYgdGhhdCBvd25zIGl0 Pwo+IAo+IE9ubHkgYSBkcml2ZXIgc3BlY2lmaWMgb25lLgoKU291bmRzIE9LCgo+IEZvciBUVE0g ZHJpdmVycyB2bWEtPnZtX3ByaXZhdGVfZGF0YSBwb2ludHMgdG8gdGhlIGJ1ZmZlciBvYmplY3Qu IE5vdCBzdXJlCj4gYWJvdXQgdGhlIGRyaXZlcnMgdXNpbmcgR0VNIG9ubHkuCgpXaHkgYXJlIGRy aXZlcnMgaW4gY29udHJvbCBvZiB0aGUgdm1hPyBJIHdvdWxkIHRoaW5rIGRtYV9idWYgc2hvdWxk IGJlCnRoZSB2bWEgb3duZXIuIElJUkMgbW9kdWxlIGxpZmV0aW1lIGNvcnJlY3RuZXNzIGVzc2Vu dGlhbGx5IGhpbmdzIG9uCnRoZSBtb2R1bGUgb3duZXIgb2YgdGhlIHN0cnVjdCBmaWxlCgo+IFdo eSBhcmUgeW91IGFza2luZz8KCkknbSB0aGlua2luZyBhYm91dCB1c2luZyBmaW5kX3ZtYSBvbiBz b21ldGhpbmcgdGhhdCBpcyBub3QKZ2V0X3VzZXJfcGFnZXMoKSdhYmxlIHRvIGdvIHRvIHRoZSB1 bmRlcmx5aW5nIG9iamVjdCwgaW4gdGhpcyBjYXNlIGRtYQpidWYuCgpTbywgdXNlciBWQSAtPiBm aW5kX3ZtYSAtPiBkbWFfYnVmIG9iamVjdCAtPiBkbWFfYnVmIG9wZXJhdGlvbnMgb24gdGhlCm1l bW9yeSBpdCByZXByZXNlbnRzCgpKYXNvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92FC2C35269 for ; Thu, 17 Sep 2020 14:43:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 541ED206DB for ; Thu, 17 Sep 2020 14:43:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="j5oYloPv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727561AbgIQOhy (ORCPT ); Thu, 17 Sep 2020 10:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727221AbgIQOgr (ORCPT ); Thu, 17 Sep 2020 10:36:47 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F1A9C061355 for ; Thu, 17 Sep 2020 07:35:53 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id q63so2422934qkf.3 for ; Thu, 17 Sep 2020 07:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4FMmUqw3Ogf5DWfrcaBYE+88tcXzyk3qcn9Gd5hl3YQ=; b=j5oYloPvYL7s4CPTt81wv4olgyoI/6IlhT6aI8lDvNqHADWP/JsUZ4WNwSAnarJJVd Jdd7y5LK3H4qrJDXIzo4GzxtRtRdSn74TO+sPmBQ+A3UTKrWoV2qqwIgla/t6cN1mEzh YgB03e2F1hYq89gJy2In7h5LX8mfdp/lJ8vauS8eQJrPZEuv9vFNxus3W1QS8aEEh2jU aNgxQzkQEHZvN34u0lGhLEgUFKJXoYCaI/tF+nC0CovO/q9P121VcOoAOdmqbPSwPlwQ 9k8ecPtmJZWZCMPSONUM47C13l3uQbZ64/zvk+EFKCwijs/wPUYHVUJBOSzB9UTR274e bIsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4FMmUqw3Ogf5DWfrcaBYE+88tcXzyk3qcn9Gd5hl3YQ=; b=d5cT4X9Z44DkO4+32jqeLYvYyQimwXZtYatCZ72iVCb4w9rIfwwdfpMueYPlst+4g8 TnLQr7MWa5fAZjP0ycOeBA2V6psp0uTehijSzvV0JQM2FcTBKeCG4QlUaArrjypMmLCM BM9GBFLtj/wbjjVCRuIiXV5ngbCUe85WrhomJp8eLfy7GMBsI0VkRPua6o4Ptec0XdR9 3me2jVkoJtNatt8XyTcnW//LBeiYwyQtkzvPF0JpM29P8qOYDT8/O2zp3fpD8VhJlWrb uj7aneaa/j4M5tea2RoMVYwDblBEcXDV60volZYvZupZYX0ESZbSSqeAARk8jkiYeh46 wrXw== X-Gm-Message-State: AOAM532ATAA8CU16XDOCCS4wGV57MRquVoIpKwScnwvEpdq2M3sPCPAG +1iTc26nAA18mTdsuRC6LrWDnA== X-Google-Smtp-Source: ABdhPJzS5DvFjFRz09F8HD5ZwD/CTVt6TV63hE1mZt++JvtsXfCWDtAegDUHikgXHQCiEAeg2s8xdA== X-Received: by 2002:a05:620a:15ac:: with SMTP id f12mr27633534qkk.19.1600353352699; Thu, 17 Sep 2020 07:35:52 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id m36sm20906770qtd.10.2020.09.17.07.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 07:35:52 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kIv0p-000VC1-Ed; Thu, 17 Sep 2020 11:35:51 -0300 Date: Thu, 17 Sep 2020 11:35:51 -0300 From: Jason Gunthorpe To: christian.koenig@amd.com Cc: Linux Kernel Mailing List , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Linux MM , Daniel Vetter , Andrew Morton , "open list:DMA BUFFER SHARING FRAMEWORK" Subject: Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap() Message-ID: <20200917143551.GG8409@ziepe.ca> References: <8db2474f-ecb7-0e17-5f5b-145708fe44d5@amd.com> <8d8693db-a3f0-4f5f-3e32-57d23ca620f8@amd.com> <20200917113110.GE8409@ziepe.ca> <6fd74b84-959c-8b3b-c27b-e9fbf66396c7@gmail.com> <20200917121858.GF8409@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Sep 17, 2020 at 02:24:29PM +0200, Christian König wrote: > Am 17.09.20 um 14:18 schrieb Jason Gunthorpe: > > On Thu, Sep 17, 2020 at 02:03:48PM +0200, Christian König wrote: > > > Am 17.09.20 um 13:31 schrieb Jason Gunthorpe: > > > > On Thu, Sep 17, 2020 at 10:09:12AM +0200, Daniel Vetter wrote: > > > > > > > > > Yeah, but it doesn't work when forwarding from the drm chardev to the > > > > > dma-buf on the importer side, since you'd need a ton of different > > > > > address spaces. And you still rely on the core code picking up your > > > > > pgoff mangling, which feels about as risky to me as the vma file > > > > > pointer wrangling - if it's not consistently applied the reverse map > > > > > is toast and unmap_mapping_range doesn't work correctly for our needs. > > > > I would think the pgoff has to be translated at the same time the > > > > vm->vm_file is changed? > > > > > > > > The owner of the dma_buf should have one virtual address space and FD, > > > > all its dma bufs should be linked to it, and all pgoffs translated to > > > > that space. > > > Yeah, that is exactly like amdgpu is doing it. > > > > > > Going to document that somehow when I'm done with TTM cleanups. > > BTW, while people are looking at this, is there a way to go from a VMA > > to a dma_buf that owns it? > > Only a driver specific one. Sounds OK > For TTM drivers vma->vm_private_data points to the buffer object. Not sure > about the drivers using GEM only. Why are drivers in control of the vma? I would think dma_buf should be the vma owner. IIRC module lifetime correctness essentially hings on the module owner of the struct file > Why are you asking? I'm thinking about using find_vma on something that is not get_user_pages()'able to go to the underlying object, in this case dma buf. So, user VA -> find_vma -> dma_buf object -> dma_buf operations on the memory it represents Jason