From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/4] mkfs: don't allow creation of realtime files from a proto file
Date: Thu, 17 Sep 2020 09:25:46 -0700 [thread overview]
Message-ID: <20200917162546.GE7955@magnolia> (raw)
In-Reply-To: <20200917080234.GV26262@infradead.org>
On Thu, Sep 17, 2020 at 09:02:34AM +0100, Christoph Hellwig wrote:
> On Mon, Sep 14, 2020 at 06:51:23PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > If someone runs mkfs with rtinherit=1, a realtime volume configured, and
> > a protofile that creates a regular file in the filesystem, mkfs will
> > error out with "Function not implemented" because userspace doesn't know
> > how to allocate extents from the rt bitmap. Catch this specific case
> > and hand back a somewhat nicer explanation of what happened.
>
> Would this be so hard to fix?
Probably not, but I'd prefer to see users asking for this feature before
porting more code to userspace.
I guess I could take a look for 5.10, maybe it's not that difficult.
Though given the amount of bitrot and math errors I've seen recently, I
get the funny sense that my crash test box and TV are the only things
using rt support.
--D
next prev parent reply other threads:[~2020-09-17 16:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 1:51 [PATCH 0/4] xfsprogs: even more fixes for 5.9 Darrick J. Wong
2020-09-15 1:51 ` [PATCH 1/4] libxfs: refactor inode flags propagation code Darrick J. Wong
2020-09-17 8:01 ` Christoph Hellwig
2020-09-17 16:22 ` Darrick J. Wong
2020-09-15 1:51 ` [PATCH 2/4] libxfs: don't propagate RTINHERIT -> REALTIME when there is no rtdev Darrick J. Wong
2020-09-17 8:02 ` Christoph Hellwig
2020-09-28 21:26 ` Eric Sandeen
2020-09-15 1:51 ` [PATCH 3/4] mkfs: don't allow creation of realtime files from a proto file Darrick J. Wong
2020-09-17 8:02 ` Christoph Hellwig
2020-09-17 16:25 ` Darrick J. Wong [this message]
2020-09-28 21:10 ` Eric Sandeen
2020-09-15 1:51 ` [PATCH 4/4] xfs_repair: don't flag RTINHERIT files when no rt volume Darrick J. Wong
2020-09-17 8:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917162546.GE7955@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.