From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kIws5-0004Lb-V3 for mharc-grub-devel@gnu.org; Thu, 17 Sep 2020 12:34:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIws4-0004H0-4S for grub-devel@gnu.org; Thu, 17 Sep 2020 12:34:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:55976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIws2-0001T7-9m for grub-devel@gnu.org; Thu, 17 Sep 2020 12:34:55 -0400 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DBEB214D8; Thu, 17 Sep 2020 16:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600360491; bh=7RoizVpaSplMV32W5jrEs/o6sqX9yU/Ebj9rhvQ10yI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rpHWKrJLMQZaISS8y1hWYca/EfKLufi4ZyXGo8vbmqi/be+ocu6PjYlf66hVTltx+ lFmviuhWojBsgheDWQD4+4RxK4irxUUUbdWZe94NKOvtFm6MROyya5KkTfV8dl/Hci kVVD1HdjHnxS2XIs2qgE/9yaYADOA/jQDFPm1ypI= Date: Thu, 17 Sep 2020 09:34:50 -0700 From: Jaegeuk Kim To: Daniel Kiper Cc: Glenn Washburn , grub-devel@gnu.org, pmenzel@molgen.mpg.de Subject: Re: [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests. Message-ID: <20200917163450.GA2391422@google.com> References: <8e758731-64db-ebe7-eb2b-94376ddf11a8@molgen.mpg.de> <20200828233025.2269002-1-development@efficientek.com> <20200917141956.bnmhmocizf4hqb7m@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917141956.bnmhmocizf4hqb7m@tomti.i.net-space.pl> Received-SPF: pass client-ip=198.145.29.99; envelope-from=jaegeuk@kernel.org; helo=mail.kernel.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/17 12:34:51 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -100 X-Spam_score: -10.1 X-Spam_bar: ---------- X-Spam_report: (-10.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.997, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 16:34:56 -0000 On 09/17, Daniel Kiper wrote: > Adding Jaegeuk and Paul... > > On Fri, Aug 28, 2020 at 06:30:25PM -0500, Glenn Washburn wrote: > > LODEVICES is not an array variable and should not be accessed as such. This > > allows the f2fs test to pass as it was failing because a device name had a > > space prepended to the path. > > > > Signed-off-by: Glenn Washburn > > --- > > tests/util/grub-fs-tester.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in > > index bc14a05ca..bfc425e1f 100644 > > --- a/tests/util/grub-fs-tester.in > > +++ b/tests/util/grub-fs-tester.in > > @@ -796,7 +796,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do > > MOUNTFS=ext2 > > "mkfs.ext2" -L "$FSLABEL" -q "${MOUNTDEVICE}" ;; > > xf2fs) > > - "mkfs.f2fs" -l "$FSLABEL" -q "${LODEVICES[0]}" ;; > > + "mkfs.f2fs" -l "$FSLABEL" -q "${MOUNTDEVICE}" ;; > > LGTM... > > Jaegeuk, Paul does this fix work for you? Thank you. I'm okay and should follow the others. Acked-by: Jaegeuk Kim > > Daniel