From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jin Yao <yao.jin@linux.intel.com>,
jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v6 0/7] perf: Stream comparison
Date: Thu, 17 Sep 2020 17:13:20 -0300 [thread overview]
Message-ID: <20200917201320.GB1431236@kernel.org> (raw)
In-Reply-To: <20200917130556.GA2511679@krava>
Em Thu, Sep 17, 2020 at 03:05:56PM +0200, Jiri Olsa escreveu:
> On Fri, Sep 11, 2020 at 04:03:46PM +0800, Jin Yao wrote:
>
> SNIP
>
> > main div.c:40
> > main div.c:40
> > main div.c:39
> >
> > [ Hot streams in new perf data only ]
> >
> > hot chain 1:
> > cycles: 4, hits: 4.54%
> > --------------------------
> > main div.c:42
> > compute_flag div.c:28
> >
> > hot chain 2:
> > cycles: 5, hits: 3.51%
> > --------------------------
> > main div.c:39
> > main div.c:44
> > main div.c:42
> > compute_flag div.c:28
> >
> > v6:
> > ---
> > Rebase to perf/core
>
> it looks good to me
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Jin,
I'm sorry I only got to look at this now, there are some issues,
I'll try to point them out patch by patch,
Thanks,
- Arnaldo
next prev parent reply other threads:[~2020-09-17 20:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 8:03 [PATCH v6 0/7] perf: Stream comparison Jin Yao
2020-09-11 8:03 ` [PATCH v6 1/7] perf util: Create streams Jin Yao
2020-09-17 20:20 ` Arnaldo Carvalho de Melo
2020-09-11 8:03 ` [PATCH v6 2/7] perf util: Get the evsel_streams by evsel_idx Jin Yao
2020-09-17 20:23 ` Arnaldo Carvalho de Melo
2020-09-11 8:03 ` [PATCH v6 3/7] perf util: Compare two streams Jin Yao
2020-09-11 8:03 ` [PATCH v6 4/7] perf util: Link stream pair Jin Yao
2020-09-17 20:23 ` Arnaldo Carvalho de Melo
2020-09-11 8:03 ` [PATCH v6 5/7] perf util: Calculate the sum of total streams hits Jin Yao
2020-09-11 8:03 ` [PATCH v6 6/7] perf util: Report hot streams Jin Yao
2020-09-11 8:03 ` [PATCH v6 7/7] perf diff: Support hot streams comparison Jin Yao
2020-09-17 20:26 ` Arnaldo Carvalho de Melo
2020-09-18 6:58 ` Jin, Yao
2020-09-19 4:41 ` Jin, Yao
2020-09-21 12:17 ` Arnaldo Carvalho de Melo
2020-09-17 13:05 ` [PATCH v6 0/7] perf: Stream comparison Jiri Olsa
2020-09-17 20:13 ` Arnaldo Carvalho de Melo [this message]
2020-09-18 6:54 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917201320.GB1431236@kernel.org \
--to=acme@kernel.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.