All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dennis Zhou <dennis@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [GIT PULL] percpu fix for v5.9-rc6
Date: Thu, 17 Sep 2020 20:45:14 +0000	[thread overview]
Message-ID: <20200917204514.GA2880159@google.com> (raw)

Hi Linus,

This is a fix for the first chunk size calculation where the variable
length array incorrectly used # of longs instead of bytes of longs. This
came in as a code fix and not a bug report, so I don't think it was
widely problematic. I believe it worked out due to it being memblock
memory and alignment requirements working in our favor.

Thanks,
Dennis

The following changes since commit f75aef392f869018f78cfedf3c320a6b3fcfda6b:

  Linux 5.9-rc3 (2020-08-30 16:01:54 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu.git for-5.9-fixes

for you to fetch changes up to b3b33d3c43bbe0177d70653f4e889c78cc37f097:

  percpu: fix first chunk size calculation for populated bitmap (2020-09-17 17:34:39 +0000)

----------------------------------------------------------------
Sunghyun Jin (1):
      percpu: fix first chunk size calculation for populated bitmap

 mm/percpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/percpu.c b/mm/percpu.c
index f4709629e6de..1ed1a349eab8 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -1316,7 +1316,7 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr,
 
 	/* allocate chunk */
 	alloc_size = sizeof(struct pcpu_chunk) +
-		BITS_TO_LONGS(region_size >> PAGE_SHIFT);
+		BITS_TO_LONGS(region_size >> PAGE_SHIFT) * sizeof(unsigned long);
 	chunk = memblock_alloc(alloc_size, SMP_CACHE_BYTES);
 	if (!chunk)
 		panic("%s: Failed to allocate %zu bytes\n", __func__,


             reply	other threads:[~2020-09-17 20:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 20:45 Dennis Zhou [this message]
2020-09-18  1:05 ` [GIT PULL] percpu fix for v5.9-rc6 Linus Torvalds
2020-09-18 16:23   ` Gustavo A. R. Silva
2020-09-18 17:23     ` Linus Torvalds
2020-09-18 19:34       ` Gustavo A. R. Silva
2020-09-18 19:37         ` Linus Torvalds
2020-09-18 20:02           ` Matthew Wilcox
2020-09-18 20:14             ` Linus Torvalds
2020-09-18 20:29               ` Arvind Sankar
2020-09-18 20:40                 ` Linus Torvalds
2020-09-18 21:00                   ` Arvind Sankar
2020-09-18 21:18                     ` Linus Torvalds
2020-09-18 22:39                       ` Arvind Sankar
2020-09-19  1:28                         ` Linus Torvalds
2020-09-19  2:53                           ` Arvind Sankar
2020-09-19  3:02                             ` Matthew Wilcox
2020-09-19  3:04                             ` Linus Torvalds
2020-09-19  2:45                         ` Matthew Wilcox
2020-09-19  3:37                           ` Arvind Sankar
2020-09-19 15:15                         ` David Laight
2020-09-18 20:03           ` Gustavo A. R. Silva
2020-09-18  1:10 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917204514.GA2880159@google.com \
    --to=dennis@kernel.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.