From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA394C43465 for ; Fri, 18 Sep 2020 02:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D81220870 for ; Fri, 18 Sep 2020 02:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600397848; bh=ie++nir9f+2nD4AZK2bbGTkmWoKC3p+A/hsee9XYrIo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RdwyQ4T+XQookrGc8bziC86oVbtbtKAgzzpdk38tifxqGgZTCyNuWEFQ4uZq5dVlm VjKrp41OvEDNwTRdn1FKk228mTmVz+Be5oF9VlgJPb59CIV6Hnwh5tQ4zkTS0xVLfD rjJm9kxHiuLcwd3eijapNgDTILq+4N58mPrhS4vg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbgIRC50 (ORCPT ); Thu, 17 Sep 2020 22:57:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:55092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727774AbgIRCGc (ORCPT ); Thu, 17 Sep 2020 22:06:32 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 359782399C; Fri, 18 Sep 2020 02:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600394788; bh=ie++nir9f+2nD4AZK2bbGTkmWoKC3p+A/hsee9XYrIo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iNTwE+dJ1g+apDM9ANSTT+zZagt7rz0Qn4+sshEB5NvLv3kTpboM+/SrlzgxRQzc4 7KugYqaBQGdGOxcYjLZduck+KvMQKl1u9mIqHtM2TgTmFbPLQCQqbpXNNp1bLtsdgR Zhs+iUIWWaGVU7/zRiCz9WvLwMdgD58vWXkQqAmU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jonathan Bakker , Sebastian Reichel , Sasha Levin , linux-pm@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 259/330] power: supply: max17040: Correct voltage reading Date: Thu, 17 Sep 2020 21:59:59 -0400 Message-Id: <20200918020110.2063155-259-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918020110.2063155-1-sashal@kernel.org> References: <20200918020110.2063155-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org From: Jonathan Bakker [ Upstream commit 0383024f811aa469df258039807810fc3793a105 ] According to the datasheet available at (1), the bottom four bits are always zero and the actual voltage is 1.25x this value in mV. Since the kernel API specifies that voltages should be in uV, it should report 1250x the shifted value. 1) https://datasheets.maximintegrated.com/en/ds/MAX17040-MAX17041.pdf Signed-off-by: Jonathan Bakker Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/max17040_battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c index 62499018e68bf..2e845045a3fc0 100644 --- a/drivers/power/supply/max17040_battery.c +++ b/drivers/power/supply/max17040_battery.c @@ -105,7 +105,7 @@ static void max17040_get_vcell(struct i2c_client *client) vcell = max17040_read_reg(client, MAX17040_VCELL); - chip->vcell = vcell; + chip->vcell = (vcell >> 4) * 1250; } static void max17040_get_soc(struct i2c_client *client) -- 2.25.1