From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84500C43464 for ; Fri, 18 Sep 2020 02:40:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 454E323730 for ; Fri, 18 Sep 2020 02:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600396813; bh=hmulrnIkEYI8JDSnMLlamNVyn1HLJuvqeL0H9PVOlVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=G0QY4hWlgmqYdENUcKFdE7XnI5t2/Kt3+y0s2ICkaNisNQsmMACkQPDwbSm9ZePRW ukg6V9rlixXApyI3Imldf3H++xMpaPG6pYEosCMNu5Jdi06+D4ayFG4RLlaOgDwe1a l7Pg6vMRj2Zn8i11EsDAiI+HsynkIKxPg1R7zgKQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729306AbgIRCkK (ORCPT ); Thu, 17 Sep 2020 22:40:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:37546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726490AbgIRCLp (ORCPT ); Thu, 17 Sep 2020 22:11:45 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30BB1238E6; Fri, 18 Sep 2020 02:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395105; bh=hmulrnIkEYI8JDSnMLlamNVyn1HLJuvqeL0H9PVOlVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GKau1jnNv7dyitQK7++vEizED1s3vNSxH8NXi/0BZs9rJXkewRRW7Y0Zlz1asVraK lA6sf6I/AIMoXpxqq6ULF9m3uj5eiRHTshr1vBPbRx7QyY3GJYmCuPqxSHZnB2uqrn DKGmIzf4vEfG6ja59NdQBKZ3pU3l+Fps+i6+D8jg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xie XiuQi , Alexander Shishkin , Hongbo Yao , Jiri Olsa , Li Bin , Mark Rutland , Namhyung Kim , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH AUTOSEL 4.19 182/206] perf util: Fix memory leak of prefix_if_not_in Date: Thu, 17 Sep 2020 22:07:38 -0400 Message-Id: <20200918020802.2065198-182-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918020802.2065198-1-sashal@kernel.org> References: <20200918020802.2065198-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xie XiuQi [ Upstream commit 07e9a6f538cbeecaf5c55b6f2991416f873cdcbd ] Need to free "str" before return when asprintf() failed to avoid memory leak. Signed-off-by: Xie XiuQi Cc: Alexander Shishkin Cc: Hongbo Yao Cc: Jiri Olsa Cc: Li Bin Cc: Mark Rutland Cc: Namhyung Kim Link: http://lore.kernel.org/lkml/20200521133218.30150-4-liwei391@huawei.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index 46daa22b86e3b..85ff4f68adc00 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -2690,7 +2690,7 @@ static char *prefix_if_not_in(const char *pre, char *str) return str; if (asprintf(&n, "%s,%s", pre, str) < 0) - return NULL; + n = NULL; free(str); return n; -- 2.25.1