From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16FF0C43465 for ; Fri, 18 Sep 2020 02:59:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D715D20870 for ; Fri, 18 Sep 2020 02:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600397959; bh=UxyESt/K75+rUqzJRmabdg0mnMv1VHXCfyIK+f5CqpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tyHz0BHWvhYuMtEzbxzsm+dvzhIg9Ptl8N9S+nbLVwUarnG+9zOcKMjfmj/p6+1rt +N8arA7c7UKGGonxCtb/WGpOBGLdzC26UNFY71gDb0niBkApte2ZEPIPH6HxBSM0kL znrHLKuIO2iCDNSwpHK+HOYqtEqhe1UJT08Dw54E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728588AbgIRC7O (ORCPT ); Thu, 17 Sep 2020 22:59:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:57978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbgIRC7B (ORCPT ); Thu, 17 Sep 2020 22:59:01 -0400 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E4DAB2083B; Fri, 18 Sep 2020 02:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600397941; bh=UxyESt/K75+rUqzJRmabdg0mnMv1VHXCfyIK+f5CqpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uO19MVTx3NWJ9usXy2oKKEIPkmosZEXtgFGOe6IEnE3qkk4VXDca0g/Z9bOhX3W/9 2VfiWBgEYVCbm9UsWLG0XDoHFFvdK4qPQtPCzp3/bbSfQHYaNmfbliTMlnA7lLUN07 /P37UsqT9PPJF9YTBQT4K/8fX84LKNaKv2DigGmk= Date: Thu, 17 Sep 2020 19:58:59 -0700 From: Eric Biggers To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Theodore Ts'o , linux-ext4@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.19 059/206] ext4: make dioread_nolock the default Message-ID: <20200918025859.GB3518637@gmail.com> References: <20200918020802.2065198-1-sashal@kernel.org> <20200918020802.2065198-59-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200918020802.2065198-59-sashal@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Sep 17, 2020 at 10:05:35PM -0400, Sasha Levin wrote: > From: Theodore Ts'o > > [ Upstream commit 244adf6426ee31a83f397b700d964cff12a247d3 ] > > This fixes the direct I/O versus writeback race which can reveal stale > data, and it improves the tail latency of commits on slow devices. > > Link: https://lore.kernel.org/r/20200125022254.1101588-1-tytso@mit.edu > Signed-off-by: Theodore Ts'o > Signed-off-by: Sasha Levin Any particular reason to be backporting this? I thought I saw some fixes for dioread_nolock go by, after it was made the default. Are you getting all of those fixes too? - Eric