From: Alex Riesen <alexander.riesen@cetitec.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH] config: option transfer.ipversion to set transport protocol version for network fetches
Date: Fri, 18 Sep 2020 09:16:47 +0200 [thread overview]
Message-ID: <20200918071647.GA17896@pflmari> (raw)
In-Reply-To: <xmqqbli4ox0h.fsf@gitster.c.googlers.com>
Junio C Hamano, Fri, Sep 18, 2020 00:31:58 +0200:
> Alex Riesen <alexander.riesen@cetitec.com> writes:
>
> > If the configuration variable is allowed to be set to that "lack of
> > preference" value, we kind of have a command line option for it:
> >
> > git -c transfer.protocolFamily=any fetch ...
>
> Yes.
>
> But we typically do not count that as being able to override from
> the command line. If "git fetch --ipv4" will defeat the configured
> "transfer.protoclFamily=ipv6", the users will expect there is some
> way to do the same and say they accept any protocol family to be
> used.
Makes sense. I even wondered myself why there is no way to override
an --ipv4/--ipv6 in command-line back to "any" with an option added
after it:
$ cat my-fetch
#!/bin/sh
git fetch --ipv4 "$@"
$ ./my-fetch --ipv46
But how about making the command-line and config option a list?
(renaming it to ipversion, as elsewhere in the discussion)
git fetch --ipversions=ipv6,ipv8
Given multiple times, the last option wins, as usual:
$ cat my-fetch
#!/bin/sh
git fetch --ipversions=ipv4 "$@"
$ ./my-fetch --ipversions=all
BTW, transport.c already converts transport->family to bit-flags in
connect_setup.
next prev parent reply other threads:[~2020-09-18 7:17 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 12:19 sub-fetches discard --ipv4|6 option Alex Riesen
2020-09-14 19:49 ` Jeff King
2020-09-15 11:50 ` Alex Riesen
2020-09-15 11:54 ` [PATCH] Pass --ipv4 and --ipv6 options to sub-fetches when fetching multiple remotes and submodules Alex Riesen
2020-09-15 13:06 ` Jeff King
2020-09-16 4:17 ` Junio C Hamano
2020-09-16 7:27 ` Alex Riesen
2020-09-15 21:19 ` Junio C Hamano
2020-09-16 7:25 ` Alex Riesen
2020-09-15 13:05 ` sub-fetches discard --ipv4|6 option Jeff King
2020-09-15 13:54 ` [PATCH] config: option transfer.ipversion to set transport protocol version for network fetches Alex Riesen
2020-09-16 20:02 ` Jeff King
2020-09-17 8:07 ` Alex Riesen
2020-09-17 13:20 ` [PATCH] Config option to set the " Alex Riesen
2020-09-17 13:26 ` Alex Riesen
2020-09-17 13:31 ` Jeff King
2020-09-17 13:35 ` Alex Riesen
2020-09-17 14:51 ` Jeff King
2020-09-17 15:17 ` Alex Riesen
2020-12-22 19:55 ` Junio C Hamano
2021-01-07 10:06 ` Alex Riesen
2020-09-17 16:05 ` Alex Riesen
2020-09-16 20:14 ` [PATCH] config: option transfer.ipversion to set " Junio C Hamano
2020-09-16 20:18 ` Jeff King
2020-09-16 22:50 ` Junio C Hamano
2020-09-16 22:52 ` Junio C Hamano
2020-09-17 0:48 ` Jeff King
2020-09-17 0:57 ` Junio C Hamano
2020-09-16 21:35 ` Junio C Hamano
2020-09-17 14:02 ` Alex Riesen
2020-09-17 22:31 ` Junio C Hamano
2020-09-18 7:16 ` Alex Riesen [this message]
2020-09-18 16:37 ` Junio C Hamano
2020-09-21 16:39 ` Alex Riesen
2020-09-22 5:03 ` Jeff King
2020-09-17 8:04 ` Alex Riesen
2020-09-17 8:18 ` Alex Riesen
2020-09-15 14:06 ` sub-fetches discard --ipv4|6 option Alex Riesen
2020-09-15 15:27 ` Jeff King
2020-09-15 16:03 ` Alex Riesen
2020-09-16 16:32 ` Jeff King
2020-09-17 14:33 ` Alex Riesen
2020-09-22 5:08 ` Jeff King
2020-09-15 20:09 ` Junio C Hamano
2020-09-15 21:23 ` Jeff King
2020-09-15 21:32 ` Junio C Hamano
2020-09-16 16:34 ` Jeff King
2020-09-16 21:20 ` Junio C Hamano
2020-09-14 20:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918071647.GA17896@pflmari \
--to=alexander.riesen@cetitec.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.