From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] ionic: dynamic interrupt moderation
Date: Fri, 18 Sep 2020 10:24:34 +0000 [thread overview]
Message-ID: <20200918102434.GA892838@mwanda> (raw)
Hello Shannon Nelson,
This is a semi-automatic email about new static checker warnings.
The patch 04a834592bf5: "ionic: dynamic interrupt moderation" from
Sep 15, 2020, leads to the following Smatch complaint:
drivers/net/ethernet/pensando/ionic/ionic_lif.c:855 ionic_adminq_napi()
error: we previously assumed 'lif->adminqcq' could be null (see line 848)
drivers/net/ethernet/pensando/ionic/ionic_lif.c
847
848 if (lif->adminqcq && lif->adminqcq->flags & IONIC_QCQ_F_INITED)
^^^^^^^^^^^^^
Existing code checks for NULL
849 a_work = ionic_cq_service(&lif->adminqcq->cq, budget,
850 ionic_adminq_service, NULL, NULL);
851
852 work_done = max(n_work, a_work);
853 if (work_done < budget && napi_complete_done(napi, work_done)) {
854 flags |= IONIC_INTR_CRED_UNMASK;
855 lif->adminqcq->cq.bound_intr->rearm_count++;
^^^^^^^^^^^^^^^
The patch adds a new unchecked dereference
856 }
857
regards,
dan carpenter
reply other threads:[~2020-09-18 10:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918102434.GA892838@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.