From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Karthik B S <karthik.b.s@intel.com>
Cc: igt-dev@lists.freedesktop.org, daniel.vetter@intel.com,
michel@daenzer.net, petri.latvala@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t v8] tests/kms_async_flips: Add test to validate asynchronous flips
Date: Fri, 18 Sep 2020 14:45:49 +0300 [thread overview]
Message-ID: <20200918114549.GH6112@intel.com> (raw)
In-Reply-To: <20200918113248.GG6112@intel.com>
On Fri, Sep 18, 2020 at 02:32:48PM +0300, Ville Syrjälä wrote:
> On Fri, Sep 18, 2020 at 12:13:18PM +0530, Karthik B S wrote:
> > +static bool has_async(int fd)
>
> has_async_flip() or has_async_page_flip() would be more descriptive.
>
> > +{
> > + struct drm_get_cap cap = { .capability = DRM_CAP_ASYNC_PAGE_FLIP };
> > +
> > + igt_assert(drmIoctl(fd, DRM_IOCTL_GET_CAP, &cap) == 0);
> > + return cap.value;
> > +}
I guess having a generic has_drm_cap() helper might be
nice throughout igt. Not sure if we have one already.
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-09-18 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 6:43 [igt-dev] [PATCH i-g-t v8] tests/kms_async_flips: Add test to validate asynchronous flips Karthik B S
2020-09-18 7:50 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Add test to validate asynchronous flips (rev6) Patchwork
2020-09-18 8:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-09-18 11:32 ` [igt-dev] [PATCH i-g-t v8] tests/kms_async_flips: Add test to validate asynchronous flips Ville Syrjälä
2020-09-18 11:45 ` Ville Syrjälä [this message]
2020-09-23 2:56 ` Karthik B S
2020-09-18 21:18 ` Zanoni, Paulo R
2020-09-23 2:53 ` Karthik B S
2020-09-23 9:55 ` Ville Syrjälä
2020-09-23 14:12 ` Karthik B S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918114549.GH6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=michel@daenzer.net \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.