From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CF3C4346D for ; Fri, 18 Sep 2020 12:47:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 974CF208B8 for ; Fri, 18 Sep 2020 12:47:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="cFL7Cr4f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 974CF208B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 162B36ECE3; Fri, 18 Sep 2020 12:47:00 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id E723D6ECE3 for ; Fri, 18 Sep 2020 12:46:58 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id l9so5450410wme.3 for ; Fri, 18 Sep 2020 05:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9nKWEv4dqtFaB3khWsO7OhilKhzjQuKg+zNG2DgVNfc=; b=cFL7Cr4fUlm88EsXHo2hZseg3GRSaZWTh67y+zgK8c0H4jnh9UkA2cRbpMRisyIUSR y2qGpNBpez/O5wzmGAyy8L/YInTvZnCoOMFi7eLa0U4I9VCjGVrV4zNOGcTBj14oB4Id rmqQ8WdtNVC1hHRmicQsddqOEQPIgSo1V/LTI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9nKWEv4dqtFaB3khWsO7OhilKhzjQuKg+zNG2DgVNfc=; b=F7HhBAji5XSIgYrNUsiw1ZuA+cCC4T8qdETkEP4P2DVGYivg8ADeV5cOyiKQfFZyrp nIvV/vQ3jo4g3hsackJqFO9nlHx7lAup3N8MXZ2riwbj/01n+QOOETUH/DoQLHM3JMlZ dImrcN4cm4j/8gpiruGZm4XgvyfSE0WvtjVbP3YYjvR4i2rPD0zjeyZjxdFO5/JY8OL4 6Y7MJEuGiEeuOs/UxXgw8aBJqe5T1S5NaC5TsmBZt+I2efYaYehRgIiImNbHrGJ0IVNk 0sf9uovGeaxAZAOui0CIhEDpeI9dxfegKYgKlcK6WO8oqqirsd6Exx5F91eo0XqisQcK Jv7A== X-Gm-Message-State: AOAM532piOPIORdvz3qTL8eR0/kfLZVqhS874B6g8I9aK9hMmGC3ioRy uTsgK5U8xxbBwLPdWFogt7oSOuGmd5PdiRmw X-Google-Smtp-Source: ABdhPJxa+Ko/uTyz0A9Rq71hnhe4gvteY4mBBhDwvfQb7Q4UmniiepKLTBQ4xSA0TQmDqnOqHrOFPA== X-Received: by 2002:a1c:610b:: with SMTP id v11mr15920556wmb.181.1600433217590; Fri, 18 Sep 2020 05:46:57 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p1sm19827390wma.0.2020.09.18.05.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 05:46:56 -0700 (PDT) Date: Fri, 18 Sep 2020 14:46:54 +0200 From: Daniel Vetter To: Huang Rui Subject: Re: [PATCH] drm/ttm: update kernel-doc line comments Message-ID: <20200918124654.GC438822@phenom.ffwll.local> References: <1600422778-888-1-git-send-email-tiantao6@hisilicon.com> <20200918104425.GA2644518@hr-amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200918104425.GA2644518@hr-amd> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "airlied@linux.ie" , "linuxarm@huawei.com" , "dri-devel@lists.freedesktop.org" , Tian Tao , "Koenig, Christian" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Sep 18, 2020 at 06:44:25PM +0800, Huang Rui wrote: > On Fri, Sep 18, 2020 at 05:52:58PM +0800, Tian Tao wrote: > > Update kernel-doc line comments to fix warnings reported by make W=1. > > > > drivers/gpu/drm/ttm/ttm_memory.c:271: warning: Function parameter or > > member 'glob' not described in 'ttm_shrink' > > drivers/gpu/drm/ttm/ttm_memory.c:271: warning: Function parameter or > > member 'from_wq' not described in 'ttm_shrink' > > drivers/gpu/drm/ttm/ttm_memory.c:271: warning: Function parameter or > > member 'extra' not described in 'ttm_shrink' > > drivers/gpu/drm/ttm/ttm_memory.c:271: warning: Function parameter or > > member 'ctx' not described in 'ttm_shrink' > > > > Signed-off-by: Tian Tao > > Acked-by: Huang Rui It would be nice to go through ttm docs and polish them so their proper. This patch here just shuts up the warning without fixing any of the documentation issues. Fixing the docs would be much better. -Daniel > > > --- > > drivers/gpu/drm/ttm/ttm_memory.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/ttm/ttm_memory.c b/drivers/gpu/drm/ttm/ttm_memory.c > > index acd63b7..0b51773 100644 > > --- a/drivers/gpu/drm/ttm/ttm_memory.c > > +++ b/drivers/gpu/drm/ttm/ttm_memory.c > > @@ -259,7 +259,7 @@ static bool ttm_zones_above_swap_target(struct ttm_mem_global *glob, > > return false; > > } > > > > -/** > > +/* > > * At this point we only support a single shrink callback. > > * Extend this if needed, perhaps using a linked list of callbacks. > > * Note that this function is reentrant: > > -- > > 2.7.4 > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel